[iOS] Fix VoiceOver focus not shifting to Picker/DatePicker/TimePicker popups - #31912
Closed
jsuarezruiz wants to merge 3 commits into
Closed
jsuarezruiz wants to merge 3 commits into
jsuarezruiz wants to merge 3 commits into
Conversation
jsuarezruiz
added
platform/ios
area-controls-picker
jsuarezruiz
changed the title
Member
|
/rebase |
github-actions
Bot
force-pushed
the
fix-30746
branch
from
October 16, 2025 16:37
ef51b34 to
e0b8847
Compare
…e window hierarchy
jsuarezruiz
marked this pull request as ready for review
October 17, 2025 08:59
Contributor
There was a problem hiding this comment.
Pull Request Overview
Adds iOS accessibility support so VoiceOver focus shifts correctly when Picker, DatePicker, and TimePicker popups (input views or alert controllers) open and closes. Introduces internal extension methods to post UIAccessibility ScreenChanged notifications and wires them into the handlers' start/end events.
- Adds PostAccessibilityFocusNotification extension overloads in SemanticExtensions
- Invokes notifications on open (start/editing) and close (end) for Picker/DatePicker/TimePicker
- Adjusts Picker alert presentation to await controller presentation before posting accessibility notification
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| src/Core/src/Platform/iOS/SemanticExtensions.cs | Adds internal extension methods to post VoiceOver screen change notifications for input view focus management. |
| src/Core/src/Handlers/TimePicker/TimePickerHandler.iOS.cs | Calls accessibility notifications on popup open and close to shift/restore VoiceOver focus. |
| src/Core/src/Handlers/Picker/PickerHandler.iOS.cs | Adds notifications for picker input view / alert presentation and dismissal; changes to async presentation. |
| src/Core/src/Handlers/DatePicker/DatePickerHandler.iOS.cs | Adds notifications on date picker open and close to manage VoiceOver focus. |
Contributor
|
Closed in favour of #33152 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
This PR include some extension methods to use
UIAccessibility.PostNotificationcalls to notify VoiceOver when picker popups appear and close for Picker, DatePicker, and TimePicker.Based on the issue description, the picker should:
UIAccessibility.PostNotification(ScreenChanged, inputView)is called with theUIPickerView, VoiceOver focuses on the picker control.UIPickerView, VoiceOver users can naturally navigate through the individual items. This try to follow iOS accessibility patterns where you first focus on the container control, then navigate within it.Draft PR until include some related tests.
Issues Fixed
Fixes #30746