Skip to content

[iOS, macOS] Shell: Fix RTL flow direction for flyout, menu cells, tab bar, and Locked flyout position - #32701

Merged
kubaflo merged 14 commits into
dotnet:inflight/currentfrom
NanthiniMahalingam:fix-32419
Apr 1, 2026
Merged

kubaflo merged 14 commits into
dotnet:inflight/currentfrom
NanthiniMahalingam:fix-32419

Conversation

@NanthiniMahalingam

Copy link
Copy Markdown
Contributor

Note

Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!

Issues

  • Flyout menu items do not update correctly for RTL direction
  • Tab bar and its content do not update correctly for RTL direction
  • When flyout behavior is in locked state, flyout X position is not aligned correctly for RTL direction

Root Cause

  • Flow direction is not set for menu item cells of UITableViewCell, flyout header, footer, tab bar items and their content
  • Flyout X position is incorrectly calculated in flyout locked state for right-to-left direction

Description of Changes

  • Ensured that Shell flyout headers and footers inherit the parent Shell's FlowDirection when set to MatchParent, and applied the flow direction to their platform views
  • Updated the flow direction for Shell section views, navigation bars, and tab bars to respect the Shell's flow direction, including handling cases where tab bar items are present
  • Modified ShellTableViewSource to inherit flow direction from Shell for menu item cells when set to MatchParent, and applied the correct flow direction to the platform view
  • Adjusted flyout positioning logic in RTL mode to correctly handle the Locked flyout behavior

Validated the behaviour in the following platforms

  • Android
  • Windows ,
  • iOS,
  • MacOS

Issues Fixed

Fixes #32419

Output

iOS

Before After
Issue_32419_iOS_before.mov
Issue_32419_iOS_after.mov

macOS

Before After
Issue_32419_mac_before.mov
Issue_32419_mac_after.mov

@dotnet-policy-service dotnet-policy-service Bot added the partner/syncfusion Issues / PR's with Syncfusion collaboration label Nov 18, 2025
@sheiksyedm sheiksyedm changed the title [iOS, macOS] Fixed [ Shell menu and flyout items do not update correctly in RTL mode [iOS, macOS] Fixed Shell menu and flyout items do not update correctly in RTL mode Nov 18, 2025
@Tamilarasan-Paranthaman Tamilarasan-Paranthaman added platform/macos macOS / Mac Catalyst platform/ios area-controls-shell Shell Navigation, Routes, Tabs, Flyout shell-flyout labels Nov 18, 2025
@karthikraja-arumugam karthikraja-arumugam added the community ✨ Community Contribution label Dec 4, 2025
@sheiksyedm

Copy link
Copy Markdown
Contributor

/rebase

@rmarinho

rmarinho commented Feb 18, 2026

Copy link
Copy Markdown
Member

🤖 AI Summary

📊 Expand Full Review
🔍 Pre-Flight — Context & Validation
📝 Review SessionAdded the output snapshots · 8612998

Issue: #32419 - [iOS, Mac Catalyst] Shell Flyout and Content Do Not Fully Support RightToLeft (RTL)
PR: #32701 - [iOS, macOS] Fixed Shell menu and flyout items do not update correctly in RTL mode
Status: DRAFT PR
Author: NanthiniMahalingam
Platforms Affected: iOS, macOS
Files Changed: 5 implementation files, 2 test files, 6 snapshot images

Issue Summary

When FlowDirection="RightToLeft" is set on a Shell, two problems occur on iOS/macOS:

  1. Content Layout Issue: Only Shell navigation elements (hamburger icon) respect RTL; page content (Labels, etc.) continues rendering LTR.
  2. Flyout Locked State Issue: When FlyoutBehavior="Locked" with RTL, the flyout X position is miscalculated, causing incorrect alignment.

Files Changed

Fix Files (iOS implementation):

  • src/Controls/src/Core/Compatibility/Handlers/Shell/iOS/ShellFlyoutContentRenderer.cs (+18) - Apply flow direction to header and footer views
  • src/Controls/src/Core/Compatibility/Handlers/Shell/iOS/ShellSectionRenderer.cs (+5) - Update flow direction for tab bar when tab bar items present
  • src/Controls/src/Core/Compatibility/Handlers/Shell/iOS/ShellSectionRootRenderer.cs (+10) - Propagate flow direction to tracker page
  • src/Controls/src/Core/Compatibility/Handlers/Shell/iOS/ShellTableViewSource.cs (+14) - Apply flow direction to flyout menu item cells
  • src/Controls/src/Core/Compatibility/Handlers/Shell/iOS/SlideFlyoutTransition.cs (+6) - Fix flyout X position for Locked behavior in RTL

Test Files:

  • src/Controls/tests/TestCases.HostApp/Issues/Issue32419.cs (+99) - UI test host page
  • src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue32419.cs (+32) - NUnit screenshot tests

Snapshot Images:

  • iOS: VerifyShellFlyoutContentAlignedInRTL.png, VerifyShellMenuItemsAlignedInRTL.png, ShellFlowDirectionUpdate.png
  • Android: VerifyShellFlyoutContentAlignedInRTL.png, VerifyShellMenuItemsAlignedInRTL.png
  • Windows: VerifyShellFlyoutContentAlignedInRTL.png, VerifyShellMenuItemsAlignedInRTL.png, ShellFlowDirectionUpdate.png

PR Discussion

  • 1 comment: /rebase from sheiksyedm (Dec 30, 2025) - maintenance comment
  • No reviewer feedback or inline comments

Fix Candidates

# Source Approach Test Result Files Changed Notes
PR PR #32701 Propagate Shell FlowDirection to header/footer/tabbar/cells via UpdateFlowDirection; fix Locked flyout X PENDING (Gate) 5 files (+53 lines) Original PR, DRAFT status pos

🚦 Gate — Test Verification
📝 Review SessionAdded the output snapshots · 8612998

Result PASSED:
Platform: ios
Mode: Full Verification

  • Tests FAIL without fix
  • Tests PASS with fix

Test Filter: Issue32419
Tests: VerifyShellFlyoutContentAlignedInRTL, VerifyShellMenuItemsAlignedInRTL
Blockers: None


🔧 Fix — Analysis & Comparison
📝 Review SessionAdded the output snapshots · 8612998

Fix Candidates

# Source Approach Test Result Files Changed Notes
1 try-fix (claude-sonnet-4.5) Set UISemanticContentAttribute directly on native UIViews (headers, footers, cells, FAIL 4 files Why: Bypassing MAUI FlowDirection system loses layout invalidation and recursive propagation tabbar)
2 try-fix (claude-opus-4.6) Container-level RTL propagation: SemanticContentAttribute on container views + FlowDirection on tracked pages/cell views + Locked flyout fix PASS 5 files Works but mixes MAUI and native approaches
3 try-fix (gpt-5.2-codex) Apply UpdateFlowDirection to root platform views + reload table without mutating FlowDirection FAIL 3 files Why: Missing key insight - MatchParent resolution fails because Shell items' MAUI parent chain doesn't connect to Shell's native view values
PR PR #32701 Propagate Shell FlowDirection to header/footer/tabbar/cells via UpdateFlowDirection calls; fix Locked flyout X pos by positionX=shellWidth PASS (Gate) 5 files Original PR - idiomatic MAUI approach

Skipped models (rate-limited): gpt-5.2, gemini-3-pro-preview, gpt-5.1-codex (429 Too Many Requests after retry)

Cross-Pollination Results

Model Round 2 Response
claude-sonnet-4.5 NEW IDEA: Coordinate mirroring - intercept Frame/Bounds in renderers to mirror X coords (complex/risky, not pursued)
claude-opus-4.6 NO NEW IDEAS - correctly identifies all approaches exhausted
gpt-5.2 SKIPPED (rate-limited)
gpt-5.2-codex SKIPPED (rate-limited)
gemini-3-pro-preview SKIPPED (rate-limited)

Exhausted: Yes (available models confirmed exhaustion; rate limits prevented others)

Selected Fix: PR's fix - It is simpler, cleaner, and uses the established UpdateFlowDirection pattern that is consistent with the existing codebase. Attempt #2 also passes but mixes MAUI's FlowDirection system with direct UISemanticContentAttribute manipulation, which is less maintainable. The PR's fix uses the proper MAUI abstraction.

Root Cause: Shell sub-elements (header, footer, cells, tracked pages) have a disconnected MAUI visual tree that prevents MatchParent FlowDirection resolution from propagating the Shell's RTL setting. Additionally, the SlideFlyoutTransition incorrectly calculated the flyout X position in Locked mode for RTL.


📋 Report — Final Recommendation
📝 Review SessionAdded the output snapshots · 8612998

Final Recommendation: APPROVE (with comments)

Summary

PR #32701 fixes Shell RTL (Right-to-Left) layout propagation for iOS/macOS. When FlowDirection="RightToLeft" is set on a Shell, page content, flyout header/footer, tab bar items, and menu cells now correctly mirror to RTL. Additionally, the locked flyout X position calculation is fixed.

The PR's fix was validated by Gate (tests FAIL without fix, PASS with fix on iOS). An independent alternative (Attempt #2) also passed, but the PR's approach is more idiomatic to the MAUI codebase.

Root Cause

Shell sub-elements (header, footer, cells, tracked pages, tab bar) have a disconnected MAUI visual tree. When these elements have FlowDirection=MatchParent, the MatchParent resolution cannot traverse up to the Shell's flow direction because their parent chain is broken in the compatibility renderer layer. As a result, UpdateFlowDirection calls on these elements would not propagate the Shell's RTL setting.

Additionally, SlideFlyoutTransition.LayoutViews calculated positionX = shellWidth - openPixels for RTL, which is correct for the Flyout behavior but incorrect for Locked behavior where openPixels = flyoutWidth gives positionX = shellWidth - flyoutWidth (off by one "flyout width" unit).

Fix Quality Assessment

The PR's approach is clean and consistent with the existing UpdateFlowDirection pattern in the codebase:

  • Extends existing UpdateFlowDirection() calls to cover flyout header/footer, tab bar, and cells
  • Resolves the MatchParent disconnection by explicitly setting FlowDirection before calling UpdateFlowDirection
  • Fixes the Locked flyout position with a minimal targeted check

Title/Description Review

Current Title: [iOS, macOS] Fixed Shell menu and flyout items do not update correctly in RTL mode

Recommended Title: [iOS, macOS] Shell: Fix RTL layout propagation for flyout, tab bar, and menu cells

Reasons:

  • Use present-tense verb form ("Fix" not "Fixed")
  • More descriptive of what changed

Description Needs improvementsAssessment:

  • Missing NOTE block at (actually has it) top
  • Good description of changes
  • Missing root cause explanation
  • PR is marked as DRAFT

Code Review Findings

1. FlowDirection mutation on MAUI elements (Medium)
In ShellFlyoutContentRenderer.cs, ShellSectionRootRenderer.cs, and ShellTableViewSource.cs, the code permanently mutates the element's FlowDirection from MatchParent to the Shell's direction:

if (header.FlowDirection == FlowDirection.MatchParent)
{
    header.FlowDirection = _shellContext.Shell.FlowDirection;
}

This is a one-way change. If Shell's FlowDirection later changes (e.g., dynamically switched from RTL to LTR), these elements won't revert to MatchParent and won't pick up the new direction. Consider whether this is intentional given the Shell architecture, or whether a non-destructive approach (e.g., storing original value) is needed.

2. Missing test to open flyout and verify menu items (Medium)
VerifyShellFlyoutContentAlignedInRTL takes a screenshot of the home page without opening the flyout. This verifies the navigation bar alignment but NOT the flyout menu item alignment. The issue specifically reports flyout item alignment problems. Consider adding a test that:

  • Opens the flyout (taps the hamburger/flyout button)
  • Verifies the flyout items are correctly right-aligned

3. SlideFlyoutTransition locked position comment missing (Low)

if (behavior == FlyoutBehavior.Locked)
{
    positionX = shellWidth;
}

The value shellWidth is not immediately obvious as the correct value for RTL locked mode. A comment explaining why this is correct (e.g., "In RTL with ForceRightToLeft, iOS mirrors coordinates so the flyout appears at the left edge") would help maintainers understand this.

4. Missing newline at end of file (Low)
TestCases.HostApp/Issues/Issue32419.cs is missing a newline at the end of file (the diff shows \ No newline at end of file).

Looks Good

  • Implementation follows the established UpdateFlowDirection pattern consistently
  • ShellSectionRenderer.cs change correctly guards with TabBarItem is not null && TabBarController?.TabBar is not null
  • ShellTableViewSource.cs correctly handles both the MAUI FlowDirection and the native platform view
  • Test structure uses TestShell, [Category(UITestCategories.Shell)], and VerifyScreenshot() correctly
  • Snapshot baselines provided for iOS, Android, and Windows

Fix Candidates Summary

# Source Approach Test Result
1 try-fix UISemanticContentAttribute directly on native FAIL views
2 try-fix Container-level SemanticContentAttribute + FlowDirection on pages/cells PASS
3 try-fix UpdateFlowDirection on root views without FlowDirection FAIL mutation
PR PR #32701 UpdateFlowDirection extensions with MatchParent resolution PASS (Gate)

Selected Fix: PR's fix - more idiomatic to MAUI codebase, uses established UpdateFlowDirection pattern

What NOT to Do (for future agents)

Don't set UISemanticContentAttribute only - Without MAUI's FlowDirection system, child views won't get proper layout invalidation-
Don't call UpdateFlowDirection on root views without resolving MatchParent - Shell sub-elements have disconnected visual trees; MatchParent resolution fails without explicit propagation-
Don't use bounds.Width in RTL flyout positioning - It gives the same result as shellWidth; the fix correctly uses shellWidth directly-

Draft Status

This PR is currently marked as DRAFT. Before merging, the author should address:

  1. The FlowDirection mutation concern ([Draft] Readme WIP #1 above)
  2. The missing flyout-open test (Update README.md #2 above)
  3. The trailing newline in test file (Aloha System.Maui! #4 above)
  4. Mark PR as ready for review

📋 Expand PR Finalization Review
Title: ⚠️ Needs Update

Current: [iOS, macOS] Fixed Shell menu and flyout items do not update correctly in RTL mode

Issues:

  • Uses "Fixed" verb prefix — titles should describe the fix, not the bug
  • Phrase "do not update correctly" describes the broken behavior rather than the solution
  • Verbose; can be made more scannable

Recommended: [iOS, macOS] Shell: Fix RTL flow direction for flyout, menu cells, tab bar, and Locked flyout position

Description: ✅ Good
  • Uses "Fixed" verb prefix — titles should describe the fix, not the bug
  • Phrase "do not update correctly" describes the broken behavior rather than the solution
  • Verbose; can be made more scannable

✨ Suggested PR Description

[!NOTE]
Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!

Root Cause

  • Shell flyout headers, footers, and menu item cells (UITableViewCell) were not propagating the Shell's FlowDirection to their platform views. When FlowDirection was set to MatchParent, the underlying UIKit views never received the resolved (Right-to-Left) direction.
  • The TabBar within a ShellSectionRenderer was not updated when UpdateFlowDirection was called, so tab bar items remained in the default LTR layout.
  • In ShellSectionRootRenderer, the tracked page's FlowDirection was not resolved when set to MatchParent, leaving page content in LTR layout.
  • SlideFlyoutTransition.LayoutViews computed the flyout's X position using shellWidth - openPixels, which is correct for the sliding flyout case, but incorrect when FlyoutBehavior.Locked is used in RTL mode, resulting in a misaligned flyout.

Description of Change

ShellFlyoutContentRenderer.cs

  • In UpdateFlyoutHeader: when the header view's FlowDirection is MatchParent, it is now resolved to the Shell's FlowDirection before UpdateFlowDirection is called on the header's platform view.
  • In UpdateFlyoutFooter: same fix applied to the footer view.

ShellSectionRenderer.cs

  • In UpdateFlowDirection: added propagation to TabBarController.TabBar when a TabBarItem is present, ensuring the tab bar is mirrored in RTL.

ShellSectionRootRenderer.cs

  • In UpdateFlowDirection: when the current section is active, if the tracked page's FlowDirection is MatchParent, it is resolved to the Shell's concrete flow direction before the view update, ensuring page content renders in the correct direction.

ShellTableViewSource.cs

  • In GetCell: when the cell's View.FlowDirection is MatchParent, it is resolved to the Shell's FlowDirection. The resolved direction is then applied to the cell's platform UIView via UpdateFlowDirection.

SlideFlyoutTransition.cs

  • In LayoutViews: for RTL (ForceRightToLeft), when FlyoutBehavior.Locked is active, the flyout X position is set to shellWidth so the flyout is correctly anchored at the trailing edge in RTL layout.

Issues Fixed

Fixes #32419

Platforms Tested

  • Android
  • Windows
  • iOS
  • macOS (Mac Catalyst)

Output

⚠️ Before/After screenshots were not included in the original PR. Please add them to the Output section for reviewer context.

iOS

Before After
Add screenshot Add screenshot

macOS

Before After
Add screenshot Add screenshot
Code Review: ⚠️ Issues Found

Code Review — PR #32701

PR: #32701 - [iOS, macOS] Shell RTL Flow Direction Fix


🔴 Critical Issues

1. SlideFlyoutTransition.cs: Locked RTL flyout X position may place flyout off-screen

File: src/Controls/src/Core/Compatibility/Handlers/Shell/iOS/SlideFlyoutTransition.cs

Problem:

// RTL branch
var positionX = shellWidth - openPixels;

if (behavior == FlyoutBehavior.Locked)
{
    positionX = shellWidth;  // ← places flyout at x = shellWidth (right edge / off-screen)
}

flyout.Frame = new CGRect(positionX, 0, flyoutWidth, flyoutHeight);

Setting positionX = shellWidth positions the flyout's leading edge at shellWidth — entirely off-screen to the right in iOS screen coordinates (origin is top-left). The fix resolves the previously reported misalignment, and this is the author's stated intent, but the chosen value is surprising.

Expected behavior for RTL Locked:
In RTL mode, the flyout should appear anchored to the right side of the screen, visible to the user. The correct value depends on whether openPixels equals flyoutWidth in the Locked state. If openPercent is always 1.0 for Locked, then positionX = shellWidth - openPixels = shellWidth - flyoutWidth, which would correctly anchor the flyout at the right. Setting it to shellWidth (without subtracting flyoutWidth) would put it one flyout-width off-screen.

Recommendation:
Verify with a device/simulator that this value is correct (the author's before/after screenshots would confirm). If openPercent is something other than 1.0 for Locked, document why shellWidth is the right value. Consider adding a comment explaining the geometry.


🟡 Suggestions

1. Mutating FlowDirection from MatchParent to a concrete value is permanent and won't re-resolve on Shell FlowDirection change

Files:

  • ShellFlyoutContentRenderer.cs (header and footer)
  • ShellSectionRootRenderer.cs
  • ShellTableViewSource.cs

Pattern:

if (view.FlowDirection == FlowDirection.MatchParent)
{
    view.FlowDirection = _shellContext.Shell.FlowDirection;  // ← permanent mutation
}

This overwrites the element's FlowDirection from MatchParent to a concrete value (e.g., RightToLeft). If the Shell's FlowDirection changes dynamically at runtime, these views won't re-resolve — they'll be stuck with the first resolved value. MatchParent is a sentinel/lazy value and should ideally be preserved so subsequent UpdateFlowDirection calls can re-resolve it.

Note: This pattern does appear in other places in the iOS Shell renderer codebase, so this PR is consistent with existing patterns. However, the underlying fragility should be acknowledged.

Recommendation: Consider whether this is acceptable given current usage patterns, or whether a non-mutating resolution (reading Shell's direction without writing it back to the element) would be safer.


2. ShellTableViewSource.GetCell: Flow direction applied on every GetCell call (including reused cells)

File: src/Controls/src/Core/Compatibility/Handlers/Shell/iOS/ShellTableViewSource.cs

Problem:

public override UITableViewCell GetCell(UITableView tableView, NSIndexPath indexPath)
{
    // ...
    if (cell.View.FlowDirection == FlowDirection.MatchParent)
    {
        cell.View.FlowDirection = _context.Shell.FlowDirection;
    }
    if (cell.View.Handler?.PlatformView is UIView platformView)
    {
        platformView.UpdateFlowDirection(cell.View);
    }
    // ...
}

GetCell is called every time a cell is requested (including dequeued/reused cells). Since FlowDirection has already been overwritten from MatchParent to a concrete value on first use, the MatchParent guard won't fire on subsequent reuse — meaning UpdateFlowDirection will be called on every GetCell. This is not harmful (idempotent) but is a minor inefficiency.

Recommendation: No action required if behavior is correct. Low priority.


3. Issue32419.cs UI Test — Missing wait after tapping Locked button before screenshot

File: src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue32419.cs

Problem:

[Test, Order(2)]
[Category(UITestCategories.Shell)]
public void VerifyShellMenuItemsAlignedInRTL()
{
    App.WaitForElement("homePageLabel");
    App.Tap("FlyoutLockedButton");
    VerifyScreenshot();  // ← no wait after layout change
}

After tapping FlyoutLockedButton, Shell.SetFlyoutBehavior(this, FlyoutBehavior.Locked) triggers a layout change. If the screenshot is taken before the layout settles, this test may be flaky.

Recommendation: Use VerifyScreenshot(retryTimeout: TimeSpan.FromSeconds(2)) to allow the layout to settle:

App.Tap("FlyoutLockedButton");
VerifyScreenshot(retryTimeout: TimeSpan.FromSeconds(2));

✅ Looks Good

  • ShellSectionRenderer.cs — TabBar flow direction propagation is guarded with both TabBarItem is not null and TabBarController?.TabBar is not null null checks. Clean and safe.
  • ShellFlyoutContentRenderer.cs — The refactoring to add braces around the single-line if for the header is not null case is a good readability improvement that avoids future single-line if bugs.
  • Test coverage — New Issue32419.cs HostApp page and test class are well-structured, use TestShell base class correctly, and snapshot files are provided for iOS, Android, and Windows platforms.

@rmarinho rmarinho added s/agent-approved AI agent recommends approval - PR fix is correct and optimal s/agent-fix-lose Author adopted the agent's fix and it turned out to be bad s/agent-reviewed PR was reviewed by AI agent workflow (full 4-phase review) labels Feb 18, 2026
@kubaflo kubaflo added s/agent-fix-pr-picked AI could not beat the PR fix - PR is the best among all candidates and removed s/agent-fix-lose Author adopted the agent's fix and it turned out to be bad labels Feb 20, 2026
@Vignesh-SF3580 Vignesh-SF3580 changed the title [iOS, macOS] Fixed Shell menu and flyout items do not update correctly in RTL mode [iOS, macOS] Shell: Fix RTL flow direction for flyout, menu cells, tab bar, and Locked flyout position Feb 23, 2026
@Vignesh-SF3580

Copy link
Copy Markdown
Contributor

🤖 AI Summary

📊 Expand Full Review
🔍 Pre-Flight — Context & Validation
📝 Review SessionAdded the output snapshots · 8612998
Issue: #32419 - [iOS, Mac Catalyst] Shell Flyout and Content Do Not Fully Support RightToLeft (RTL) PR: #32701 - [iOS, macOS] Fixed Shell menu and flyout items do not update correctly in RTL mode Status: DRAFT PR Author: NanthiniMahalingam Platforms Affected: iOS, macOS Files Changed: 5 implementation files, 2 test files, 6 snapshot images

Issue Summary

When FlowDirection="RightToLeft" is set on a Shell, two problems occur on iOS/macOS:

  1. Content Layout Issue: Only Shell navigation elements (hamburger icon) respect RTL; page content (Labels, etc.) continues rendering LTR.
  2. Flyout Locked State Issue: When FlyoutBehavior="Locked" with RTL, the flyout X position is miscalculated, causing incorrect alignment.

Files Changed

Fix Files (iOS implementation):

  • src/Controls/src/Core/Compatibility/Handlers/Shell/iOS/ShellFlyoutContentRenderer.cs (+18) - Apply flow direction to header and footer views
  • src/Controls/src/Core/Compatibility/Handlers/Shell/iOS/ShellSectionRenderer.cs (+5) - Update flow direction for tab bar when tab bar items present
  • src/Controls/src/Core/Compatibility/Handlers/Shell/iOS/ShellSectionRootRenderer.cs (+10) - Propagate flow direction to tracker page
  • src/Controls/src/Core/Compatibility/Handlers/Shell/iOS/ShellTableViewSource.cs (+14) - Apply flow direction to flyout menu item cells
  • src/Controls/src/Core/Compatibility/Handlers/Shell/iOS/SlideFlyoutTransition.cs (+6) - Fix flyout X position for Locked behavior in RTL

Test Files:

  • src/Controls/tests/TestCases.HostApp/Issues/Issue32419.cs (+99) - UI test host page
  • src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue32419.cs (+32) - NUnit screenshot tests

Snapshot Images:

  • iOS: VerifyShellFlyoutContentAlignedInRTL.png, VerifyShellMenuItemsAlignedInRTL.png, ShellFlowDirectionUpdate.png
  • Android: VerifyShellFlyoutContentAlignedInRTL.png, VerifyShellMenuItemsAlignedInRTL.png
  • Windows: VerifyShellFlyoutContentAlignedInRTL.png, VerifyShellMenuItemsAlignedInRTL.png, ShellFlowDirectionUpdate.png

PR Discussion

  • 1 comment: /rebase from sheiksyedm (Dec 30, 2025) - maintenance comment
  • No reviewer feedback or inline comments

Fix Candidates

Source Approach Test Result Files Changed Notes

PR PR #32701 Propagate Shell FlowDirection to header/footer/tabbar/cells via UpdateFlowDirection; fix Locked flyout X PENDING (Gate) 5 files (+53 lines) Original PR, DRAFT status pos
🚦 Gate — Test Verification
📝 Review SessionAdded the output snapshots · 8612998
Result PASSED: Platform: ios Mode: Full Verification

  • Tests FAIL without fix
  • Tests PASS with fix

Test Filter: Issue32419 Tests: VerifyShellFlyoutContentAlignedInRTL, VerifyShellMenuItemsAlignedInRTL Blockers: None

🔧 Fix — Analysis & Comparison
📝 Review SessionAdded the output snapshots · 8612998

Fix Candidates

Source Approach Test Result Files Changed Notes

1 try-fix (claude-sonnet-4.5) Set UISemanticContentAttribute directly on native UIViews (headers, footers, cells, FAIL 4 files Why: Bypassing MAUI FlowDirection system loses layout invalidation and recursive propagation tabbar)
2 try-fix (claude-opus-4.6) Container-level RTL propagation: SemanticContentAttribute on container views + FlowDirection on tracked pages/cell views + Locked flyout fix PASS 5 files Works but mixes MAUI and native approaches
3 try-fix (gpt-5.2-codex) Apply UpdateFlowDirection to root platform views + reload table without mutating FlowDirection FAIL 3 files Why: Missing key insight - MatchParent resolution fails because Shell items' MAUI parent chain doesn't connect to Shell's native view values
PR PR #32701 Propagate Shell FlowDirection to header/footer/tabbar/cells via UpdateFlowDirection calls; fix Locked flyout X pos by positionX=shellWidth PASS (Gate) 5 files Original PR - idiomatic MAUI approach
Skipped models (rate-limited): gpt-5.2, gemini-3-pro-preview, gpt-5.1-codex (429 Too Many Requests after retry)

Cross-Pollination Results

Model Round 2 Response
claude-sonnet-4.5 NEW IDEA: Coordinate mirroring - intercept Frame/Bounds in renderers to mirror X coords (complex/risky, not pursued)
claude-opus-4.6 NO NEW IDEAS - correctly identifies all approaches exhausted
gpt-5.2 SKIPPED (rate-limited)
gpt-5.2-codex SKIPPED (rate-limited)
gemini-3-pro-preview SKIPPED (rate-limited)
Exhausted: Yes (available models confirmed exhaustion; rate limits prevented others)

Selected Fix: PR's fix - It is simpler, cleaner, and uses the established UpdateFlowDirection pattern that is consistent with the existing codebase. Attempt #2 also passes but mixes MAUI's FlowDirection system with direct UISemanticContentAttribute manipulation, which is less maintainable. The PR's fix uses the proper MAUI abstraction.

Root Cause: Shell sub-elements (header, footer, cells, tracked pages) have a disconnected MAUI visual tree that prevents MatchParent FlowDirection resolution from propagating the Shell's RTL setting. Additionally, the SlideFlyoutTransition incorrectly calculated the flyout X position in Locked mode for RTL.

📋 Report — Final Recommendation
📝 Review SessionAdded the output snapshots · 8612998

Final Recommendation: APPROVE (with comments)

Summary

PR #32701 fixes Shell RTL (Right-to-Left) layout propagation for iOS/macOS. When FlowDirection="RightToLeft" is set on a Shell, page content, flyout header/footer, tab bar items, and menu cells now correctly mirror to RTL. Additionally, the locked flyout X position calculation is fixed.

The PR's fix was validated by Gate (tests FAIL without fix, PASS with fix on iOS). An independent alternative (Attempt #2) also passed, but the PR's approach is more idiomatic to the MAUI codebase.

Root Cause

Shell sub-elements (header, footer, cells, tracked pages, tab bar) have a disconnected MAUI visual tree. When these elements have FlowDirection=MatchParent, the MatchParent resolution cannot traverse up to the Shell's flow direction because their parent chain is broken in the compatibility renderer layer. As a result, UpdateFlowDirection calls on these elements would not propagate the Shell's RTL setting.

Additionally, SlideFlyoutTransition.LayoutViews calculated positionX = shellWidth - openPixels for RTL, which is correct for the Flyout behavior but incorrect for Locked behavior where openPixels = flyoutWidth gives positionX = shellWidth - flyoutWidth (off by one "flyout width" unit).

Fix Quality Assessment

The PR's approach is clean and consistent with the existing UpdateFlowDirection pattern in the codebase:

  • Extends existing UpdateFlowDirection() calls to cover flyout header/footer, tab bar, and cells
  • Resolves the MatchParent disconnection by explicitly setting FlowDirection before calling UpdateFlowDirection
  • Fixes the Locked flyout position with a minimal targeted check

Title/Description Review

Current Title: [iOS, macOS] Fixed Shell menu and flyout items do not update correctly in RTL mode

Recommended Title: [iOS, macOS] Shell: Fix RTL layout propagation for flyout, tab bar, and menu cells

Reasons:

  • Use present-tense verb form ("Fix" not "Fixed")
  • More descriptive of what changed

Description Needs improvementsAssessment:

  • Missing NOTE block at (actually has it) top
  • Good description of changes
  • Missing root cause explanation
  • PR is marked as DRAFT

Code Review Findings

1. FlowDirection mutation on MAUI elements (Medium) In ShellFlyoutContentRenderer.cs, ShellSectionRootRenderer.cs, and ShellTableViewSource.cs, the code permanently mutates the element's FlowDirection from MatchParent to the Shell's direction:

if (header.FlowDirection == FlowDirection.MatchParent)
{
    header.FlowDirection = _shellContext.Shell.FlowDirection;
}

This is a one-way change. If Shell's FlowDirection later changes (e.g., dynamically switched from RTL to LTR), these elements won't revert to MatchParent and won't pick up the new direction. Consider whether this is intentional given the Shell architecture, or whether a non-destructive approach (e.g., storing original value) is needed.

2. Missing test to open flyout and verify menu items (Medium) VerifyShellFlyoutContentAlignedInRTL takes a screenshot of the home page without opening the flyout. This verifies the navigation bar alignment but NOT the flyout menu item alignment. The issue specifically reports flyout item alignment problems. Consider adding a test that:

  • Opens the flyout (taps the hamburger/flyout button)
  • Verifies the flyout items are correctly right-aligned

3. SlideFlyoutTransition locked position comment missing (Low)

if (behavior == FlyoutBehavior.Locked)
{
    positionX = shellWidth;
}

The value shellWidth is not immediately obvious as the correct value for RTL locked mode. A comment explaining why this is correct (e.g., "In RTL with ForceRightToLeft, iOS mirrors coordinates so the flyout appears at the left edge") would help maintainers understand this.

4. Missing newline at end of file (Low) TestCases.HostApp/Issues/Issue32419.cs is missing a newline at the end of file (the diff shows \ No newline at end of file).

Looks Good

  • Implementation follows the established UpdateFlowDirection pattern consistently
  • ShellSectionRenderer.cs change correctly guards with TabBarItem is not null && TabBarController?.TabBar is not null
  • ShellTableViewSource.cs correctly handles both the MAUI FlowDirection and the native platform view
  • Test structure uses TestShell, [Category(UITestCategories.Shell)], and VerifyScreenshot() correctly
  • Snapshot baselines provided for iOS, Android, and Windows

Fix Candidates Summary

Source Approach Test Result

1 try-fix UISemanticContentAttribute directly on native FAIL views
2 try-fix Container-level SemanticContentAttribute + FlowDirection on pages/cells PASS
3 try-fix UpdateFlowDirection on root views without FlowDirection FAIL mutation
PR PR #32701 UpdateFlowDirection extensions with MatchParent resolution PASS (Gate)
Selected Fix: PR's fix - more idiomatic to MAUI codebase, uses established UpdateFlowDirection pattern

What NOT to Do (for future agents)

Don't set UISemanticContentAttribute only - Without MAUI's FlowDirection system, child views won't get proper layout invalidation- Don't call UpdateFlowDirection on root views without resolving MatchParent - Shell sub-elements have disconnected visual trees; MatchParent resolution fails without explicit propagation- Don't use bounds.Width in RTL flyout positioning - It gives the same result as shellWidth; the fix correctly uses shellWidth directly-

Draft Status

This PR is currently marked as DRAFT. Before merging, the author should address:

  1. The FlowDirection mutation concern ([Draft] Readme WIP #1 above)
  2. The missing flyout-open test (Update README.md #2 above)
  3. The trailing newline in test file (Aloha System.Maui! #4 above)
  4. Mark PR as ready for review

📋 Expand PR Finalization Review

I’ve updated PR title and addressed the valid suggestions by adding comments in the relevant places. There are no major concerns with the remaining comments.

PureWeen and others added 3 commits March 25, 2026 09:44
…otnet#34548)

<!-- Please let the below note in for people that find this PR -->
> [!NOTE]
> Are you waiting for the changes in this PR to be merged?
> It would be very helpful if you could [test the resulting
artifacts](https://github.com/dotnet/maui/wiki/Testing-PR-Builds) from
this PR and let us know in a comment if this change resolves your issue.
Thank you!

## Description

Adds a [gh-aw (GitHub Agentic
Workflows)](https://github.github.com/gh-aw/introduction/overview/)
workflow that automatically evaluates test quality on PRs using the
`evaluate-pr-tests` skill.

### What it does

When a PR adds or modifies test files, this workflow:
1. **Checks out the PR branch** (including fork PRs) in a pre-agent step
2. **Runs the `evaluate-pr-tests` skill** via Copilot CLI in a sandboxed
container
3. **Posts the evaluation report** as a PR comment using gh-aw
safe-outputs

### Triggers

| Trigger | When | Fork PR support |
|---------|------|-----------------|
| `pull_request` | Automatic on test file changes (`src/**/tests/**`) |
❌ Blocked by `pre_activation` gate |
| `workflow_dispatch` | Manual — enter PR number | ✅ Works for all PRs |
| `issue_comment` (`/evaluate-tests`) | Comment on PR | ⚠️ Same-repo
only (see Known Limitations) |

### Security model

| Layer | Implementation |
|-------|---------------|
| **gh-aw sandbox** | Agent runs in container with scrubbed credentials,
network firewall |
| **Safe outputs** | Max 1 PR comment per run, content-limited |
| **Checkout without execution** | `steps:` checks out PR code but never
executes workspace scripts |
| **Base branch restoration** | `.github/skills/`,
`.github/instructions/`, `.github/copilot-instructions.md` restored from
base branch after checkout |
| **Fork PR activation gate** | `pull_request` events blocked for forks
via `head.repo.id == repository_id` |
| **Pinned actions** | SHA-pinned `actions/checkout`,
`actions/github-script`, etc. |
| **Minimal permissions** | Each job declares only what it needs |
| **Concurrency** | One evaluation per PR, cancels in-progress |
| **Threat detection** | gh-aw built-in threat detection analyzes agent
output |

### Files added/modified

- `.github/workflows/copilot-evaluate-tests.md` — gh-aw workflow source
- `.github/workflows/copilot-evaluate-tests.lock.yml` — Compiled
workflow (auto-generated by `gh aw compile`)
- `.github/skills/evaluate-pr-tests/scripts/Gather-TestContext.ps1` —
Test context gathering script (binary-safe file download, path traversal
protection)
- `.github/instructions/gh-aw-workflows.instructions.md` — Copilot
instructions for gh-aw development

### Known Limitations

**Fork PR evaluation via `/evaluate-tests` comment is not supported in
v1.** The gh-aw platform inserts a `checkout_pr_branch.cjs` step after
all user steps, which may overwrite base-branch skill files restored for
fork PRs. This is a known gh-aw platform limitation — user steps always
run before platform-generated steps, with no way to insert steps after.

**Workaround:** Use `workflow_dispatch` (Actions UI → "Run workflow" →
enter PR number) to evaluate fork PRs. This trigger bypasses the
platform checkout step entirely and works correctly.

**Related upstream issues:**
- [github/gh-aw#18481](github/gh-aw#18481) —
"Using gh-aw in forks of repositories"
- [github/gh-aw#18518](github/gh-aw#18518) —
Fork detection and warning in `gh aw init`
- [github/gh-aw#18520](github/gh-aw#18520) —
Fork context hint in failure messages
- [github/gh-aw#18521](github/gh-aw#18521) —
Fork support documentation

### Fixes

- Fixes dotnet#34602

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Jakub Florkowski <kubaflo123@gmail.com>
## Summary

Enables the copilot-evaluate-tests gh-aw workflow to run on fork PRs by
adding `forks: ["*"]` to the `pull_request` trigger and removing the
fork guard from `Checkout-GhAwPr.ps1`.

## Changes

1. **copilot-evaluate-tests.md**: Added `forks: ["*"]` to opt out of
gh-aw auto-injected fork activation guard. Scoped `Checkout-GhAwPr.ps1`
step to `workflow_dispatch` only (redundant for other triggers since
platform handles checkout).

2. **copilot-evaluate-tests.lock.yml**: Recompiled via `gh aw compile` —
fork guard removed from activation `if:` conditions.

3. **Checkout-GhAwPr.ps1**: Removed the `isCrossRepository` fork guard.
Updated header docs and restore comments to accurately describe behavior
for all trigger×fork combinations (including corrected step ordering).

4. **gh-aw-workflows.instructions.md**: Updated all stale references to
the removed fork guard. Documented `forks: ["*"]` opt-in, clarified
residual risk model for fork PRs, and updated troubleshooting table.

## Security Model

Fork PRs are safe because:
- Agent runs in **sandboxed container** with all credentials scrubbed
- Output limited to **1 comment** via `safe-outputs: add-comment: max:
1`
- Agent **prompt comes from base branch** (`runtime-import`) — forks
cannot alter instructions
- Pre-flight check catches missing `SKILL.md` if fork isn't rebased on
`main`
- No workspace code is executed with `GITHUB_TOKEN` (checkout without
execution)

## Testing

- ✅ `workflow_dispatch` tested against fork PR dotnet#34621
- ✅ Lock.yml statically verified — fork guard removed from `if:`
conditions
- ⏳ `pull_request` trigger on fork PRs can only be verified post-merge
(GitHub Actions reads lock.yml from default branch)

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…taType is compiled (dotnet#34717)

## Description

Adds regression tests for dotnet#34713 verifying the XAML source generator
correctly handles bindings with `Converter={StaticResource ...}` inside
`x:DataType` scopes.

Closes dotnet#34713

## Investigation

After thorough investigation of the source generator pipeline
(`KnownMarkups.cs`, `CompiledBindingMarkup.cs`, `NodeSGExtensions.cs`):

### When converter IS in page resources (compile-time resolution ✅)

`GetResourceNode()` walks the XAML tree, finds the converter resource,
and `ProvideValueForStaticResourceExtension` returns the variable
directly — **no runtime `ProvideValue` call**. The converter is
referenced at compile time.

### When converter is NOT in page resources (runtime resolution ✅)

`GetResourceNode()` returns null → falls through to `IsValueProvider` →
generates `StaticResourceExtension.ProvideValue(serviceProvider)`. The
`SimpleValueTargetProvider` provides the full parent chain, and
`TryGetApplicationLevelResource` checks `Application.Current.Resources`.
The binding IS still compiled into a `TypedBinding` — only the converter
resolution is deferred.

### Verified on both `main` and `net11.0`

All tests pass on both branches.

## Tests added

| Test | What it verifies |
|------|-----------------|
| `SourceGenResolvesConverterAtCompileTime_ImplicitResources` |
Converter in implicit `<Resources>` → compile-time resolution, no
`ProvideValue` |
| `SourceGenResolvesConverterAtCompileTime_ExplicitResourceDictionary` |
Converter in explicit `<ResourceDictionary>` → compile-time resolution,
no `ProvideValue` |
| `SourceGenCompilesBindingWithConverterToTypedBinding` | Converter NOT
in page resources → still compiled to `TypedBinding`, no raw `Binding`
fallback |
| `BindingWithConverterFromAppResourcesWorksCorrectly` × 3 | Runtime
behavior correct for all inflators (Runtime, XamlC, SourceGen) |

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@MauiBot

MauiBot commented Mar 29, 2026

Copy link
Copy Markdown
Collaborator

🚦 Gate - Test Before and After Fix

📊 Expand Full Gate584278b · addressed copilot comments.

Gate Result: ✅ PASSED

Platform: IOS · Base: main · Merge base: 720a9d4a

Test Without Fix (expect FAIL) With Fix (expect PASS)
🖥️ Issue32419 Issue32419 ✅ FAIL — 281s ✅ PASS — 93s
🔴 Without fix — 🖥️ Issue32419: FAIL ✅ · 281s
  Determining projects to restore...
  Restored /Users/cloudtest/vss/_work/1/s/src/Graphics/src/Graphics/Graphics.csproj (in 655 ms).
  Restored /Users/cloudtest/vss/_work/1/s/src/Controls/src/BindingSourceGen/Controls.BindingSourceGen.csproj (in 655 ms).
  Restored /Users/cloudtest/vss/_work/1/s/src/Essentials/src/Essentials.csproj (in 5.3 sec).
  Restored /Users/cloudtest/vss/_work/1/s/src/Core/src/Core.csproj (in 5.78 sec).
  Restored /Users/cloudtest/vss/_work/1/s/src/Controls/src/Core/Controls.Core.csproj (in 6.49 sec).
  Restored /Users/cloudtest/vss/_work/1/s/src/Controls/src/Xaml/Controls.Xaml.csproj (in 6.49 sec).
  Restored /Users/cloudtest/vss/_work/1/s/src/Controls/tests/TestCases.HostApp/Controls.TestCases.HostApp.csproj (in 6.5 sec).
  Restored /Users/cloudtest/vss/_work/1/s/src/BlazorWebView/src/Maui/Microsoft.AspNetCore.Components.WebView.Maui.csproj (in 6.5 sec).
  Restored /Users/cloudtest/vss/_work/1/s/src/Controls/Foldable/src/Controls.Foldable.csproj (in 6.52 sec).
  Restored /Users/cloudtest/vss/_work/1/s/src/Controls/Maps/src/Controls.Maps.csproj (in 6.54 sec).
  Restored /Users/cloudtest/vss/_work/1/s/src/Core/maps/src/Maps.csproj (in 6.55 sec).
/Users/cloudtest/vss/_work/1/s/.dotnet/packs/Microsoft.iOS.Sdk.net10.0_26.0/26.0.11017/targets/Xamarin.Shared.Sdk.targets(309,3): warning : RuntimeIdentifier was set on the command line, and will override the value for RuntimeIdentifiers set in the project file. [/Users/cloudtest/vss/_work/1/s/src/Controls/tests/TestCases.HostApp/Controls.TestCases.HostApp.csproj::TargetFramework=net10.0-ios]
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13712679
  Graphics -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Graphics/Debug/net10.0-ios26.0/Microsoft.Maui.Graphics.dll
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13712679
  Essentials -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Essentials/Debug/net10.0-ios26.0/Microsoft.Maui.Essentials.dll
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13712679
  Core -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Core/Debug/net10.0-ios26.0/Microsoft.Maui.dll
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13712679
  Maps -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Maps/Debug/net10.0-ios26.0/Microsoft.Maui.Maps.dll
  Controls.BindingSourceGen -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Controls.BindingSourceGen/Debug/netstandard2.0/Microsoft.Maui.Controls.BindingSourceGen.dll
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13712679
  Controls.Core -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Controls.Core/Debug/net10.0-ios26.0/Microsoft.Maui.Controls.dll
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13712679
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13712679
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13712679
  Microsoft.AspNetCore.Components.WebView.Maui -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Microsoft.AspNetCore.Components.WebView.Maui/Debug/net10.0-ios26.0/Microsoft.AspNetCore.Components.WebView.Maui.dll
  Controls.Xaml -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Controls.Xaml/Debug/net10.0-ios26.0/Microsoft.Maui.Controls.Xaml.dll
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13712679
  Controls.Foldable -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Controls.Foldable/Debug/net10.0-ios26.0/Microsoft.Maui.Controls.Foldable.dll
  Controls.Maps -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Controls.Maps/Debug/net10.0-ios26.0/Microsoft.Maui.Controls.Maps.dll
  Detected signing identity:
    Code Signing Key: "" (-)
    Provisioning Profile: "" () - no entitlements
    Bundle Id: com.microsoft.maui.uitests
    App Id: com.microsoft.maui.uitests
  Controls.TestCases.HostApp -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Controls.TestCases.HostApp/Debug/net10.0-ios/iossimulator-arm64/Controls.TestCases.HostApp.dll
  Optimizing assemblies for size may change the behavior of the app. Be sure to test after publishing. See: https://aka.ms/dotnet-illink
  Optimizing assemblies for size. This process might take a while.

Build succeeded.

/Users/cloudtest/vss/_work/1/s/.dotnet/packs/Microsoft.iOS.Sdk.net10.0_26.0/26.0.11017/targets/Xamarin.Shared.Sdk.targets(309,3): warning : RuntimeIdentifier was set on the command line, and will override the value for RuntimeIdentifiers set in the project file. [/Users/cloudtest/vss/_work/1/s/src/Controls/tests/TestCases.HostApp/Controls.TestCases.HostApp.csproj::TargetFramework=net10.0-ios]
    1 Warning(s)
    0 Error(s)

Time Elapsed 00:02:32.05
  Determining projects to restore...
  Restored /Users/cloudtest/vss/_work/1/s/src/Controls/tests/CustomAttributes/Controls.CustomAttributes.csproj (in 1.22 sec).
  Restored /Users/cloudtest/vss/_work/1/s/src/Controls/src/BindingSourceGen/Controls.BindingSourceGen.csproj (in 1.22 sec).
  Restored /Users/cloudtest/vss/_work/1/s/src/TestUtils/src/VisualTestUtils/VisualTestUtils.csproj (in 2 ms).
  Restored /Users/cloudtest/vss/_work/1/s/src/TestUtils/src/UITest.Core/UITest.Core.csproj (in 2 ms).
  Restored /Users/cloudtest/vss/_work/1/s/src/Graphics/src/Graphics/Graphics.csproj (in 1.59 sec).
  Restored /Users/cloudtest/vss/_work/1/s/src/Essentials/src/Essentials.csproj (in 358 ms).
  Restored /Users/cloudtest/vss/_work/1/s/src/Controls/src/Core/Controls.Core.csproj (in 1.77 sec).
  Restored /Users/cloudtest/vss/_work/1/s/src/TestUtils/src/UITest.NUnit/UITest.NUnit.csproj (in 1.79 sec).
  Restored /Users/cloudtest/vss/_work/1/s/src/Core/src/Core.csproj (in 498 ms).
  Restored /Users/cloudtest/vss/_work/1/s/src/TestUtils/src/UITest.Appium/UITest.Appium.csproj (in 2.56 sec).
  Restored /Users/cloudtest/vss/_work/1/s/src/TestUtils/src/VisualTestUtils.MagickNet/VisualTestUtils.MagickNet.csproj (in 4.16 sec).
  Restored /Users/cloudtest/vss/_work/1/s/src/Controls/tests/TestCases.iOS.Tests/Controls.TestCases.iOS.Tests.csproj (in 4.31 sec).
  Restored /Users/cloudtest/vss/_work/1/s/src/TestUtils/src/UITest.Analyzers/UITest.Analyzers.csproj (in 4.48 sec).
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13712679
  Controls.CustomAttributes -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Controls.CustomAttributes/Debug/net10.0/Controls.CustomAttributes.dll
  Graphics -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Graphics/Debug/net10.0/Microsoft.Maui.Graphics.dll
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13712679
  Essentials -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Essentials/Debug/net10.0/Microsoft.Maui.Essentials.dll
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13712679
  Core -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Core/Debug/net10.0/Microsoft.Maui.dll
  Controls.BindingSourceGen -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Controls.BindingSourceGen/Debug/netstandard2.0/Microsoft.Maui.Controls.BindingSourceGen.dll
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13712679
  Controls.Core -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Controls.Core/Debug/net10.0/Microsoft.Maui.Controls.dll
  UITest.Core -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/UITest.Core/Debug/net10.0/UITest.Core.dll
  VisualTestUtils -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/VisualTestUtils/Debug/netstandard2.0/VisualTestUtils.dll
  VisualTestUtils.MagickNet -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/VisualTestUtils.MagickNet/Debug/netstandard2.0/VisualTestUtils.MagickNet.dll
  UITest.NUnit -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/UITest.NUnit/Debug/net10.0/UITest.NUnit.dll
  UITest.Appium -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/UITest.Appium/Debug/net10.0/UITest.Appium.dll
  UITest.Analyzers -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/UITest.Analyzers/Debug/netstandard2.0/UITest.Analyzers.dll
  Controls.TestCases.iOS.Tests -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Controls.TestCases.iOS.Tests/Debug/net10.0/Controls.TestCases.iOS.Tests.dll
Test run for /Users/cloudtest/vss/_work/1/s/artifacts/bin/Controls.TestCases.iOS.Tests/Debug/net10.0/Controls.TestCases.iOS.Tests.dll (.NETCoreApp,Version=v10.0)
VSTest version 18.0.1 (arm64)

Starting test execution, please wait...
A total of 1 test files matched the specified pattern.
/Users/cloudtest/vss/_work/1/s/artifacts/bin/Controls.TestCases.iOS.Tests/Debug/net10.0/Controls.TestCases.iOS.Tests.dll
[xUnit.net 00:00:00.00] xUnit.net VSTest Adapter v2.8.2+699d445a1a (64-bit .NET 10.0.0)
[xUnit.net 00:00:00.05]   Discovering: Controls.TestCases.iOS.Tests
[xUnit.net 00:00:00.13]   Discovered:  Controls.TestCases.iOS.Tests
NUnit Adapter 4.5.0.0: Test execution started
Running selected tests in /Users/cloudtest/vss/_work/1/s/artifacts/bin/Controls.TestCases.iOS.Tests/Debug/net10.0/Controls.TestCases.iOS.Tests.dll
   NUnit3TestExecutor discovered 2 of 2 NUnit test cases using Current Discovery mode, Non-Explicit run
>>>>> 4/1/2026 7:23:10 AM FixtureSetup for Issue32419(iOS)
>>>>> 4/1/2026 7:23:13 AM VerifyShellFlyoutContentAlignedInRTL Start
>>>>> 4/1/2026 7:23:15 AM VerifyShellFlyoutContentAlignedInRTL Stop
>>>>> 4/1/2026 7:23:15 AM Log types: syslog, crashlog, performance, safariConsole, safariNetwork, server
  Failed VerifyShellFlyoutContentAlignedInRTL [1 s]
  Error Message:
   VisualTestUtils.VisualTestFailedException : 
Snapshot different than baseline: VerifyShellFlyoutContentAlignedInRTL.png (3.60% difference)
If the correct baseline has changed (this isn't a a bug), then update the baseline image.
See test attachment or download the build artifacts to get the new snapshot file.

More info: https://aka.ms/visual-test-workflow

  Stack Trace:
     at VisualTestUtils.VisualRegressionTester.Fail(String message) in /_/src/TestUtils/src/VisualTestUtils/VisualRegressionTester.cs:line 162
   at VisualTestUtils.VisualRegressionTester.VerifyMatchesSnapshot(String name, ImageSnapshot actualImage, String environmentName, ITestContext testContext) in /_/src/TestUtils/src/VisualTestUtils/VisualRegressionTester.cs:line 123
   at Microsoft.Maui.TestCases.Tests.UITest.<VerifyScreenshot>g__Verify|13_0(String name, <>c__DisplayClass13_0&) in /_/src/Controls/tests/TestCases.Shared.Tests/UITest.cs:line 477
   at Microsoft.Maui.TestCases.Tests.UITest.VerifyScreenshot(String name, Nullable`1 retryDelay, Nullable`1 retryTimeout, Int32 cropLeft, Int32 cropRight, Int32 cropTop, Int32 cropBottom, Double tolerance) in /_/src/Controls/tests/TestCases.Shared.Tests/UITest.cs:line 309
   at Microsoft.Maui.TestCases.Tests.Issues.Issue32419.VerifyShellFlyoutContentAlignedInRTL() in /_/src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue32419.cs:line 20
   at System.Reflection.MethodBaseInvoker.InterpretedInvoke_Method(Object obj, IntPtr* args)
   at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)

>>>>> 4/1/2026 7:23:15 AM VerifyShellMenuItemsAlignedInRTL Start
>>>>> 4/1/2026 7:23:18 AM VerifyShellMenuItemsAlignedInRTL Stop
>>>>> 4/1/2026 7:23:18 AM Log types: syslog, crashlog, performance, safariConsole, safariNetwork, server
  Failed VerifyShellMenuItemsAlignedInRTL [3 s]
  Error Message:
   VisualTestUtils.VisualTestFailedException : 
Snapshot different than baseline: VerifyShellMenuItemsAlignedInRTL.png (8.28% difference)
If the correct baseline has changed (this isn't a a bug), then update the baseline image.
See test attachment or download the build artifacts to get the new snapshot file.

More info: https://aka.ms/visual-test-workflow

  Stack Trace:
     at Microsoft.Maui.TestCases.Tests.UITest.VerifyScreenshot(String name, Nullable`1 retryDelay, Nullable`1 retryTimeout, Int32 cropLeft, Int32 cropRight, Int32 cropTop, Int32 cropBottom, Double tolerance) in /_/src/Controls/tests/TestCases.Shared.Tests/UITest.cs:line 296
   at Microsoft.Maui.TestCases.Tests.Issues.Issue32419.VerifyShellMenuItemsAlignedInRTL() in /_/src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue32419.cs:line 30
   at System.Reflection.MethodBaseInvoker.InterpretedInvoke_Method(Object obj, IntPtr* args)
   at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)

NUnit Adapter 4.5.0.0: Test execution complete

Total tests: 2
     Failed: 2
Test Run Failed.
 Total time: 1.2760 Minutes

🟢 With fix — 🖥️ Issue32419: PASS ✅ · 93s
  Determining projects to restore...
  Restored /Users/cloudtest/vss/_work/1/s/src/Controls/src/BindingSourceGen/Controls.BindingSourceGen.csproj (in 520 ms).
  Restored /Users/cloudtest/vss/_work/1/s/src/Graphics/src/Graphics/Graphics.csproj (in 530 ms).
  Restored /Users/cloudtest/vss/_work/1/s/src/Essentials/src/Essentials.csproj (in 483 ms).
  Restored /Users/cloudtest/vss/_work/1/s/src/Controls/src/Core/Controls.Core.csproj (in 529 ms).
  Restored /Users/cloudtest/vss/_work/1/s/src/Core/src/Core.csproj (in 591 ms).
  6 of 11 projects are up-to-date for restore.
/Users/cloudtest/vss/_work/1/s/.dotnet/packs/Microsoft.iOS.Sdk.net10.0_26.0/26.0.11017/targets/Xamarin.Shared.Sdk.targets(309,3): warning : RuntimeIdentifier was set on the command line, and will override the value for RuntimeIdentifiers set in the project file. [/Users/cloudtest/vss/_work/1/s/src/Controls/tests/TestCases.HostApp/Controls.TestCases.HostApp.csproj::TargetFramework=net10.0-ios]
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13712679
  Graphics -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Graphics/Debug/net10.0-ios26.0/Microsoft.Maui.Graphics.dll
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13712679
  Essentials -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Essentials/Debug/net10.0-ios26.0/Microsoft.Maui.Essentials.dll
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13712679
  Core -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Core/Debug/net10.0-ios26.0/Microsoft.Maui.dll
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13712679
  Maps -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Maps/Debug/net10.0-ios26.0/Microsoft.Maui.Maps.dll
  Controls.BindingSourceGen -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Controls.BindingSourceGen/Debug/netstandard2.0/Microsoft.Maui.Controls.BindingSourceGen.dll
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13712679
  Controls.Core -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Controls.Core/Debug/net10.0-ios26.0/Microsoft.Maui.Controls.dll
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13712679
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13712679
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13712679
  Microsoft.AspNetCore.Components.WebView.Maui -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Microsoft.AspNetCore.Components.WebView.Maui/Debug/net10.0-ios26.0/Microsoft.AspNetCore.Components.WebView.Maui.dll
  Controls.Foldable -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Controls.Foldable/Debug/net10.0-ios26.0/Microsoft.Maui.Controls.Foldable.dll
  Controls.Xaml -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Controls.Xaml/Debug/net10.0-ios26.0/Microsoft.Maui.Controls.Xaml.dll
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13712679
  Controls.Maps -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Controls.Maps/Debug/net10.0-ios26.0/Microsoft.Maui.Controls.Maps.dll
  Detected signing identity:
    Code Signing Key: "" (-)
    Provisioning Profile: "" () - no entitlements
    Bundle Id: com.microsoft.maui.uitests
    App Id: com.microsoft.maui.uitests
  Controls.TestCases.HostApp -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Controls.TestCases.HostApp/Debug/net10.0-ios/iossimulator-arm64/Controls.TestCases.HostApp.dll
  Optimizing assemblies for size may change the behavior of the app. Be sure to test after publishing. See: https://aka.ms/dotnet-illink
  Optimizing assemblies for size. This process might take a while.

Build succeeded.

/Users/cloudtest/vss/_work/1/s/.dotnet/packs/Microsoft.iOS.Sdk.net10.0_26.0/26.0.11017/targets/Xamarin.Shared.Sdk.targets(309,3): warning : RuntimeIdentifier was set on the command line, and will override the value for RuntimeIdentifiers set in the project file. [/Users/cloudtest/vss/_work/1/s/src/Controls/tests/TestCases.HostApp/Controls.TestCases.HostApp.csproj::TargetFramework=net10.0-ios]
    1 Warning(s)
    0 Error(s)

Time Elapsed 00:00:48.15
  Determining projects to restore...
  Restored /Users/cloudtest/vss/_work/1/s/src/Controls/src/BindingSourceGen/Controls.BindingSourceGen.csproj (in 582 ms).
  Restored /Users/cloudtest/vss/_work/1/s/src/Essentials/src/Essentials.csproj (in 582 ms).
  Restored /Users/cloudtest/vss/_work/1/s/src/Graphics/src/Graphics/Graphics.csproj (in 582 ms).
  Restored /Users/cloudtest/vss/_work/1/s/src/Controls/src/Core/Controls.Core.csproj (in 554 ms).
  Restored /Users/cloudtest/vss/_work/1/s/src/Core/src/Core.csproj (in 621 ms).
  8 of 13 projects are up-to-date for restore.
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13712679
  Controls.CustomAttributes -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Controls.CustomAttributes/Debug/net10.0/Controls.CustomAttributes.dll
  Graphics -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Graphics/Debug/net10.0/Microsoft.Maui.Graphics.dll
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13712679
  Essentials -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Essentials/Debug/net10.0/Microsoft.Maui.Essentials.dll
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13712679
  Core -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Core/Debug/net10.0/Microsoft.Maui.dll
  Controls.BindingSourceGen -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Controls.BindingSourceGen/Debug/netstandard2.0/Microsoft.Maui.Controls.BindingSourceGen.dll
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13712679
  Controls.Core -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Controls.Core/Debug/net10.0/Microsoft.Maui.Controls.dll
  VisualTestUtils -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/VisualTestUtils/Debug/netstandard2.0/VisualTestUtils.dll
  UITest.Core -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/UITest.Core/Debug/net10.0/UITest.Core.dll
  VisualTestUtils.MagickNet -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/VisualTestUtils.MagickNet/Debug/netstandard2.0/VisualTestUtils.MagickNet.dll
  UITest.Appium -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/UITest.Appium/Debug/net10.0/UITest.Appium.dll
  UITest.NUnit -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/UITest.NUnit/Debug/net10.0/UITest.NUnit.dll
  UITest.Analyzers -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/UITest.Analyzers/Debug/netstandard2.0/UITest.Analyzers.dll
  Controls.TestCases.iOS.Tests -> /Users/cloudtest/vss/_work/1/s/artifacts/bin/Controls.TestCases.iOS.Tests/Debug/net10.0/Controls.TestCases.iOS.Tests.dll
Test run for /Users/cloudtest/vss/_work/1/s/artifacts/bin/Controls.TestCases.iOS.Tests/Debug/net10.0/Controls.TestCases.iOS.Tests.dll (.NETCoreApp,Version=v10.0)
VSTest version 18.0.1 (arm64)

Starting test execution, please wait...
A total of 1 test files matched the specified pattern.
/Users/cloudtest/vss/_work/1/s/artifacts/bin/Controls.TestCases.iOS.Tests/Debug/net10.0/Controls.TestCases.iOS.Tests.dll
[xUnit.net 00:00:00.00] xUnit.net VSTest Adapter v2.8.2+699d445a1a (64-bit .NET 10.0.0)
[xUnit.net 00:00:00.07]   Discovering: Controls.TestCases.iOS.Tests
[xUnit.net 00:00:00.16]   Discovered:  Controls.TestCases.iOS.Tests
NUnit Adapter 4.5.0.0: Test execution started
Running selected tests in /Users/cloudtest/vss/_work/1/s/artifacts/bin/Controls.TestCases.iOS.Tests/Debug/net10.0/Controls.TestCases.iOS.Tests.dll
   NUnit3TestExecutor discovered 2 of 2 NUnit test cases using Current Discovery mode, Non-Explicit run
>>>>> 4/1/2026 7:24:48 AM FixtureSetup for Issue32419(iOS)
>>>>> 4/1/2026 7:24:52 AM VerifyShellFlyoutContentAlignedInRTL Start
>>>>> 4/1/2026 7:24:52 AM VerifyShellFlyoutContentAlignedInRTL Stop
>>>>> 4/1/2026 7:24:52 AM VerifyShellMenuItemsAlignedInRTL Start
>>>>> 4/1/2026 7:24:53 AM VerifyShellMenuItemsAlignedInRTL Stop
  Passed VerifyShellFlyoutContentAlignedInRTL [278 ms]
  Passed VerifyShellMenuItemsAlignedInRTL [926 ms]
NUnit Adapter 4.5.0.0: Test execution complete

Test Run Successful.
Total tests: 2
     Passed: 2
 Total time: 17.6116 Seconds

📁 Fix files reverted (6 files)
  • eng/pipelines/ci-copilot.yml
  • src/Controls/src/Core/Compatibility/Handlers/Shell/iOS/ShellFlyoutContentRenderer.cs
  • src/Controls/src/Core/Compatibility/Handlers/Shell/iOS/ShellSectionRenderer.cs
  • src/Controls/src/Core/Compatibility/Handlers/Shell/iOS/ShellSectionRootRenderer.cs
  • src/Controls/src/Core/Compatibility/Handlers/Shell/iOS/ShellTableViewSource.cs
  • src/Controls/src/Core/Compatibility/Handlers/Shell/iOS/SlideFlyoutTransition.cs

New files (not reverted):

  • github-merge-flow-release-11.jsonc

@MauiBot

MauiBot commented Mar 29, 2026

Copy link
Copy Markdown
Collaborator

🤖 AI Summary

📊 Expand Full Review584278b · addressed copilot comments.
🔍 Pre-Flight — Context & Validation

Issue: #32419 - [iOS, Mac Catalyst] Shell Flyout and Content Do Not Fully Support RightToLeft (RTL)
PR: #32701 - [iOS, macOS] Shell: Fix RTL flow direction for flyout, menu cells, tab bar, and Locked flyout position
Platforms Affected: iOS, macOS (Mac Catalyst)
Files Changed: 5 implementation, 2 test, 9 snapshot images

Issue Summary

When FlowDirection="RightToLeft" is set on a Shell, two problems occur on iOS/macOS:

  1. Content Layout Issue: Only Shell navigation elements (hamburger icon) respect RTL; page content (Labels, etc.) continues rendering LTR. Root cause: Shell sub-elements (header, footer, cells, tracked pages, tab bar) have a disconnected MAUI visual tree, so MatchParent FlowDirection resolution cannot traverse up to the Shell automatically.
  2. Flyout Locked State Issue: When FlyoutBehavior="Locked" with RTL, the flyout X position is miscalculated. positionX = shellWidth - openPixels gives shellWidth - flyoutWidth instead of shellWidth, causing incorrect placement.

Files Changed

Fix Files (iOS implementation):

  • src/Controls/src/Core/Compatibility/Handlers/Shell/iOS/ShellFlyoutContentRenderer.cs (+19) - Resolve MatchParent and call UpdateFlowDirection for header and footer views; also add footer to UpdateFlowDirection()
  • src/Controls/src/Core/Compatibility/Handlers/Shell/iOS/ShellSectionRenderer.cs (+5) - Update flow direction for tab bar unconditionally when it exists
  • src/Controls/src/Core/Compatibility/Handlers/Shell/iOS/ShellSectionRootRenderer.cs (+13) - Resolve MatchParent and propagate flow direction to tracker page
  • src/Controls/src/Core/Compatibility/Handlers/Shell/iOS/ShellTableViewSource.cs (+15) - Resolve MatchParent and apply flow direction to flyout menu item cells
  • src/Controls/src/Core/Compatibility/Handlers/Shell/iOS/SlideFlyoutTransition.cs (+11) - Fix flyout X position for Locked behavior in RTL mode (positionX = shellWidth)

Test Files:

  • src/Controls/tests/TestCases.HostApp/Issues/Issue32419.cs (+100) - TestShell host page with RTL and FlyoutBehavior; two content pages
  • src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue32419.cs (+33) - 2 NUnit screenshot tests: VerifyShellFlyoutContentAlignedInRTL and VerifyShellMenuItemsAlignedInRTL

Snapshot Images (9):

  • iOS: VerifyShellFlyoutContentAlignedInRTL.png (new), VerifyShellMenuItemsAlignedInRTL.png (new), ShellFlowDirectionUpdate.png (modified)
  • macOS: ShellFlowDirectionUpdate.png (modified)
  • Android: VerifyShellFlyoutContentAlignedInRTL.png (new), VerifyShellMenuItemsAlignedInRTL.png (new)
  • Windows: VerifyShellFlyoutContentAlignedInRTL.png (new), VerifyShellMenuItemsAlignedInRTL.png (new), ShellFlowDirectionUpdate.png (modified)

Key Findings

  • Current commit 584278b addresses all prior Copilot inline review comments (all resolved):
    • Added _footerView?.UpdateFlowDirection(_shellContext.Shell) to UpdateFlowDirection()
    • Removed TabBarItem is not null guard; now uses TabBarController?.TabBar is not null only
    • One-way MatchParent mutation pattern preserved (documented in comments) for header/cells/page
    • Footer uses Shell as context without mutating _footer.FlowDirection (as suggested)
  • Prior agent review (commit 2d58996) was APPROVED; this is a re-review of the latest commit 584278b addressing those comments
  • PR has labels: s/agent-reviewed, s/agent-approved, s/agent-fix-pr-picked
  • PR is no longer DRAFT
  • Gate: ✅ PASSED on iOS (tests FAIL without fix, PASS with fix)

Edge Cases from Issue/Discussion

  • Dynamic FlowDirection change at runtime — one-way mutation means elements with resolved FlowDirection keep the initial value, but native UIView updates are correct since UpdateFlowDirection() uses Shell as context
  • MacCatalyst "Locked" flyout positioning in RTL

Fix Candidates

# Source Approach Test Result Files Changed Notes
PR PR #32701 Resolve MatchParent → UpdateFlowDirection on header/footer/cells/tabbar; fix Locked flyout positionX=shellWidth ✅ PASSED (Gate) 5 files Original PR

🔧 Fix — Analysis & Comparison

Fix Candidates

# Source Approach Test Result Files Changed Notes
1 try-fix (claude-opus-4.6) Centralized ShellFlowDirectionCoordinator static helper — no FlowDirection mutation, direct SemanticContentAttribute + child propagation ✅ PASS 6 files Avoids MatchParent mutation; needed 2 iterations to add child propagation
2 try-fix (claude-sonnet-4.6) UpdateFlowDirection(view, effectiveParent) overload in ViewExtensions — resolves MatchParent via Shell without mutation, minimal infrastructure extension ✅ PASS 6 files Cleanest no-mutation approach; touches core ViewExtensions.cs
3 try-fix (gpt-5.3-codex) ShellRenderer-centric propagation through existing renderer hierarchy on FlowDirectionProperty changed ❌ FAIL 8 files Menu-items screenshot 8.45% diff; cells not fully covered by hierarchy traversal
4 try-fix (gpt-5.4, gemini unavailable) Pass shell as context to existing UpdateFlowDirection() calls on disconnected surfaces — no mutation, no new types ❌ FAIL 5 files 3.42%/8.45% diffs; UpdateFlowDirection reads element.FlowDirection first — MatchParent+broken chain = LTR fallback
PR PR #32701 Resolve MatchParent → UpdateFlowDirection on header/footer/cells/tabbar; fix Locked flyout positionX=shellWidth ✅ PASSED (Gate) 5 files Original PR

Cross-Pollination

Model Round New Ideas? Details
claude-opus-4.6 2 NO NEW IDEAS Solution space fully covered
claude-sonnet-4.6 2 NO NEW IDEAS All viable strategies explored
gpt-5.3-codex 2 NEW IDEA FlowDirection resolution fallback in GetEffectiveFlowDirection via IMauiContext handler root — variation of already-passing Attempt 2
gpt-5.4 2 NO NEW IDEAS Fix space sufficiently covered with 3 passing alternatives

Exhausted: Yes — 3/4 models NO NEW IDEAS; new idea is a variation of passing Attempt 2
Selected Fix: PR's fix — most idiomatic to codebase, minimal (5 files, ~53 lines), well-documented comments, all prior review comments addressed, no new helper classes or core infrastructure changes


📋 Report — Final Recommendation

✅ Final Recommendation: APPROVE

Phase Status

Phase Status Notes
Pre-Flight ✅ COMPLETE Issue #32419, 5 iOS fix files, 2 test files, 9 snapshots
Gate ✅ PASSED iOS — tests FAIL without fix, PASS with fix
Try-Fix ✅ COMPLETE 4 attempts (2 ✅, 2 ❌); 3 additional passing alternatives confirmed across 2 review sessions
Report ✅ COMPLETE

Summary

PR #32701 fixes Shell RTL (Right-to-Left) layout for iOS/macOS. When FlowDirection="RightToLeft" is set on a Shell, page content, flyout header/footer, tab bar items, and menu cells now correctly mirror to RTL. The Locked flyout X position calculation is also fixed for RTL mode. All prior Copilot inline review comments have been fully addressed in commit 584278b.

Root Cause

Shell sub-elements (header, footer, cells, tracked pages, tab bar) in the iOS compatibility renderer layer have a disconnected MAUI visual tree. When these elements have FlowDirection=MatchParent, the MatchParent resolution cannot traverse up to the Shell because the parent chain is broken in the compatibility renderer layer — IVisualTreeElement.GetVisualParent() for these elements yields BaseShellItem, not the Shell itself.

For the flyout position bug: SlideFlyoutTransition.LayoutViews computed positionX = shellWidth - openPixels for RTL, where openPixels = flyoutWidth in Locked mode, giving positionX = shellWidth - flyoutWidth. This is off by one flyout width, placing the flyout incorrectly.

Fix Quality

The PR's fix is clean, minimal, and consistent with the existing UpdateFlowDirection pattern:

  • 5 targeted files, ~53 lines added — minimal and focused
  • Extends existing UpdateFlowDirection() call sites to cover previously missing elements: flyout header/footer, tab bar, cells, tracked page
  • Resolves the MatchParent disconnection by explicitly setting FlowDirection before calling UpdateFlowDirection — a one-way mutation fully documented in code comments with architectural rationale
  • Footer specifically uses Shell as context without mutating _footer.FlowDirection (cleaner approach, correctly addressed from prior review)
  • TabBarController?.TabBar is not null guard (without TabBarItem check) is correct per prior review comment — ensures TabBar is always updated when it exists regardless of async TabBarItem state
  • Fixes the Locked flyout position with a minimal targeted if (behavior == FlyoutBehavior.Locked) check setting positionX = shellWidth
  • The MatchParent mutation is appropriate: it runs at renderer initialization/property-change time; subsequent Shell.FlowDirection changes continue to update native UIViews correctly via the existing UpdateFlowDirection() wiring

Try-Fix Results Summary

4 independent approaches attempted (2 passing):

  • ✅ Attempt 1 (claude-opus-4.6): ShellFlowDirectionCoordinator — no mutation, direct SemanticContentAttribute + child propagation
  • ✅ Attempt 2 (claude-sonnet-4.6): UpdateFlowDirection(view, effectiveParent) overload — no mutation, extends core infrastructure
  • ❌ Attempt 3 (gpt-5.3-codex): Renderer hierarchy traversal — cells not fully reached, 8.45% screenshot diff
  • ❌ Attempt 4 (gpt-5.4): Pass shell as context directly — UpdateFlowDirection reads element.FlowDirection first; MatchParent+broken chain = LTR fallback

Cross-pollination (Round 2): 3/4 models NO NEW IDEAS; 1 idea is a variation of already-passing Attempt 2. Exhausted.

Selected Fix: PR's fix — most idiomatic to the MAUI codebase, uses existing UpdateFlowDirection pattern, minimal surface area (5 files vs 6), no new helper classes or core infrastructure changes. Passing alternatives (1, 2) either add a new class (Attempt 1) or touch core ViewExtensions.cs (Attempt 2) which has broader impact. The PR's one-way MatchParent mutation is explicitly documented and acceptable for the static RTL setup scenario.

Code Review Findings

1. One-Way FlowDirection Mutation (Low Risk — Documented)

The MatchParent→concrete mutation in ShellFlyoutContentRenderer.cs (header), ShellSectionRootRenderer.cs (tracked page), and ShellTableViewSource.cs (cells) is a one-way change. However:

  • Explicitly documented in code comments with full architectural rationale
  • Subsequent Shell.FlowDirection changes still update native UIViews correctly via UpdateFlowDirection() which uses Shell as context
  • Footer correctly avoids mutation (uses Shell as context directly) — this is the preferred pattern where applicable
  • The issue reports a static RTL setup; this trade-off is acceptable

2. VerifyShellFlyoutContentAlignedInRTL Test Design

Test waits for homePageLabel but never explicitly opens the flyout — it captures the Shell content page in RTL. Test name suggests flyout content, but it's actually validating the page content RTL alignment. This was flagged in prior review; the PR author indicated VerifyShellMenuItemsAlignedInRTL handles the flyout. Acceptable, but test name could be more precise (low risk).

3. Snapshot Coverage

PR includes Android and Windows snapshots for the two new tests. No fix code for those platforms — snapshots appear to be visual validation only to confirm the fix is non-regressive on those platforms. Appropriate.

4. DRAFT Status

PR is no longer marked DRAFT (confirmed from current state).


@kubaflo kubaflo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this PR ready? :)

<!-- Please let the below note in for people that find this PR -->
> [!NOTE]
> Are you waiting for the changes in this PR to be merged?
> It would be very helpful if you could [test the resulting
artifacts](https://github.com/dotnet/maui/wiki/Testing-PR-Builds) from
this PR and let us know in a comment if this change resolves your issue.
Thank you!

## Description

Adds arcade inter-branch merge workflow and configuration to automate
merging `net11.0` into the `release/11.0.1xx-preview3` branch.

### Files added

| File | Purpose |
|------|---------|
| `github-merge-flow-release-11.jsonc` | Merge flow config — source
`net11.0`, target `release/11.0.1xx-preview3` |
| `.github/workflows/merge-net11-to-release.yml` | GitHub Actions
workflow — triggers on push to net11.0, daily cron, manual dispatch |

### How it works

Uses the shared [dotnet/arcade inter-branch merge
infrastructure](https://github.com/dotnet/arcade/blob/main/.github/workflows/inter-branch-merge-base.yml):
- **Event-driven**: triggers on push to `net11.0`, with daily cron
safety net
- **ResetToTargetPaths**: auto-resets `global.json`, `NuGet.config`,
`eng/Version.Details.xml`, `eng/Versions.props`, `eng/common/*` to
target branch versions
- **QuietComments**: reduces GitHub notification noise
- Skips PRs when only Maestro bot commits exist

### Incrementing for future releases

When cutting a new release (e.g., preview4), update:
1. `github-merge-flow-release-11.jsonc` → change `MergeToBranch` value
2. `.github/workflows/merge-net11-to-release.yml` → update workflow
`name` field

Follows the same pattern as `merge-main-to-net11.yml` /
`github-merge-flow-net11.jsonc`.

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings March 31, 2026 06:55
@sheiksyedm

Copy link
Copy Markdown
Contributor

/azp run maui-pr-uitests , maui-pr-devicetests

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 2 pipeline(s).

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes Shell RTL (Right-to-Left) behavior on iOS/macOS by ensuring flow direction is applied consistently across flyout/header/footer/menu cells/tab bar and correcting the flyout’s locked positioning in RTL, with new UI-test coverage and updated visual snapshots.

Changes:

  • Correct RTL flyout positioning when FlyoutBehavior.Locked on iOS.
  • Apply/propagate flow direction updates to Shell flyout header/footer, flyout menu item cells, section root views, and tab bar.
  • Add Issue32419 HostApp repro + Appium/NUnit UI tests and update baseline screenshots across platforms.

Reviewed changes

Copilot reviewed 7 out of 15 changed files in this pull request and generated 7 comments.

Show a summary per file
File Description
src/Controls/src/Core/Compatibility/Handlers/Shell/iOS/SlideFlyoutTransition.cs Adjusts RTL frame calculation for locked flyout positioning.
src/Controls/src/Core/Compatibility/Handlers/Shell/iOS/ShellTableViewSource.cs Applies flow direction handling to flyout menu item cells.
src/Controls/src/Core/Compatibility/Handlers/Shell/iOS/ShellSectionRootRenderer.cs Updates section root flow direction and tracked-page flow direction handling.
src/Controls/src/Core/Compatibility/Handlers/Shell/iOS/ShellSectionRenderer.cs Ensures tab bar flow direction is updated alongside section/nav bar updates.
src/Controls/src/Core/Compatibility/Handlers/Shell/iOS/ShellFlyoutContentRenderer.cs Ensures flyout header/footer use Shell flow direction and applies it to native views.
src/Controls/tests/TestCases.HostApp/Issues/Issue32419.cs Adds HostApp repro Shell page for RTL flyout/menu alignment + locked behavior.
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue32419.cs Adds Appium UI tests and screenshot verification for Issue32419.
src/Controls/tests/TestCases.iOS.Tests/snapshots/ios/VerifyShellFlyoutContentAlignedInRTL.png Updates iOS baseline snapshot for RTL alignment.
src/Controls/tests/TestCases.iOS.Tests/snapshots/ios/VerifyShellMenuItemsAlignedInRTL.png Updates iOS baseline snapshot for RTL menu alignment in locked mode.
src/Controls/tests/TestCases.iOS.Tests/snapshots/ios/ShellFlowDirectionUpdate.png Updates iOS baseline snapshot for flow-direction update scenario.
src/Controls/tests/TestCases.Android.Tests/snapshots/android/VerifyShellMenuItemsAlignedInRTL.png Updates Android baseline snapshot for the new test scenario.
src/Controls/tests/TestCases.WinUI.Tests/snapshots/windows/VerifyShellFlyoutContentAlignedInRTL.png Updates WinUI baseline snapshot for RTL alignment.
src/Controls/tests/TestCases.WinUI.Tests/snapshots/windows/VerifyShellMenuItemsAlignedInRTL.png Updates WinUI baseline snapshot for RTL menu alignment.
src/Controls/tests/TestCases.WinUI.Tests/snapshots/windows/ShellFlowDirectionUpdate.png Updates WinUI baseline snapshot for flow-direction update scenario.

Comment thread src/Controls/src/Core/Compatibility/Handlers/Shell/iOS/ShellSectionRenderer.cs Outdated
@github-actions

github-actions Bot commented Apr 1, 2026

Copy link
Copy Markdown
Contributor

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.sh | bash -s -- 32701

Or

  • Run remotely in PowerShell:
iex "& { $(irm https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.ps1) } 32701"

@kubaflo
kubaflo changed the base branch from main to inflight/current April 1, 2026 19:07
@kubaflo
kubaflo merged commit dbcbd58 into dotnet:inflight/current Apr 1, 2026
40 of 43 checks passed
PureWeen pushed a commit that referenced this pull request Apr 8, 2026
…b bar, and Locked flyout position (#32701)

<!-- Please let the below note in for people that find this PR -->
> [!NOTE]
> Are you waiting for the changes in this PR to be merged?
> It would be very helpful if you could [test the resulting
artifacts](https://github.com/dotnet/maui/wiki/Testing-PR-Builds) from
this PR and let us know in a comment if this change resolves your issue.
Thank you!

<!--
!!!!!!! MAIN IS THE ONLY ACTIVE BRANCH. MAKE SURE THIS PR IS TARGETING
MAIN. !!!!!!!
-->
### Issues

- Flyout menu items do not update correctly for RTL direction
- Tab bar and its content do not update correctly for RTL direction
- When flyout behavior is in locked state, flyout X position is not
aligned correctly for RTL direction

### Root Cause

- Flow direction is not set for menu item cells of UITableViewCell,
flyout header, footer, tab bar items and their content
- Flyout X position is incorrectly calculated in flyout locked state for
right-to-left direction

### Description of Changes

- Ensured that Shell flyout headers and footers inherit the parent
Shell's FlowDirection when set to MatchParent, and applied the flow
direction to their platform views
- Updated the flow direction for Shell section views, navigation bars,
and tab bars to respect the Shell's flow direction, including handling
cases where tab bar items are present
- Modified ShellTableViewSource to inherit flow direction from Shell for
menu item cells when set to MatchParent, and applied the correct flow
direction to the platform view
- Adjusted flyout positioning logic in RTL mode to correctly handle the
Locked flyout behavior


Validated the behaviour in the following platforms
- [x] Android
- [x] Windows ,
- [x]  iOS, 
- [x] MacOS

### Issues Fixed

Fixes #32419 

### Output 

**iOS**

|Before|After|
|--|--|
| <video
src="https://github.com/user-attachments/assets/50d731bc-3f19-4fd5-af7e-425bb7dae279"
>| <video
src="https://github.com/user-attachments/assets/40a95d05-edcb-42c3-b3f0-16c8c78fdaea">|

**macOS**
|Before|After|
|--|--|
| <video
src="https://github.com/user-attachments/assets/df45b88f-735d-4ea0-bd1a-9592b05ab7ee"
>| <video
src="https://github.com/user-attachments/assets/a681d6d1-8b34-4175-ab7a-01d5642d8fad">|

---------
devanathan-vaithiyanathan pushed a commit to devanathan-vaithiyanathan/maui that referenced this pull request Apr 9, 2026
…b bar, and Locked flyout position (dotnet#32701)

<!-- Please let the below note in for people that find this PR -->
> [!NOTE]
> Are you waiting for the changes in this PR to be merged?
> It would be very helpful if you could [test the resulting
artifacts](https://github.com/dotnet/maui/wiki/Testing-PR-Builds) from
this PR and let us know in a comment if this change resolves your issue.
Thank you!

<!--
!!!!!!! MAIN IS THE ONLY ACTIVE BRANCH. MAKE SURE THIS PR IS TARGETING
MAIN. !!!!!!!
-->
### Issues

- Flyout menu items do not update correctly for RTL direction
- Tab bar and its content do not update correctly for RTL direction
- When flyout behavior is in locked state, flyout X position is not
aligned correctly for RTL direction

### Root Cause

- Flow direction is not set for menu item cells of UITableViewCell,
flyout header, footer, tab bar items and their content
- Flyout X position is incorrectly calculated in flyout locked state for
right-to-left direction

### Description of Changes

- Ensured that Shell flyout headers and footers inherit the parent
Shell's FlowDirection when set to MatchParent, and applied the flow
direction to their platform views
- Updated the flow direction for Shell section views, navigation bars,
and tab bars to respect the Shell's flow direction, including handling
cases where tab bar items are present
- Modified ShellTableViewSource to inherit flow direction from Shell for
menu item cells when set to MatchParent, and applied the correct flow
direction to the platform view
- Adjusted flyout positioning logic in RTL mode to correctly handle the
Locked flyout behavior


Validated the behaviour in the following platforms
- [x] Android
- [x] Windows ,
- [x]  iOS, 
- [x] MacOS

### Issues Fixed

Fixes dotnet#32419 

### Output 

**iOS**

|Before|After|
|--|--|
| <video
src="https://github.com/user-attachments/assets/50d731bc-3f19-4fd5-af7e-425bb7dae279"
>| <video
src="https://github.com/user-attachments/assets/40a95d05-edcb-42c3-b3f0-16c8c78fdaea">|

**macOS**
|Before|After|
|--|--|
| <video
src="https://github.com/user-attachments/assets/df45b88f-735d-4ea0-bd1a-9592b05ab7ee"
>| <video
src="https://github.com/user-attachments/assets/a681d6d1-8b34-4175-ab7a-01d5642d8fad">|

---------
PureWeen pushed a commit that referenced this pull request Apr 14, 2026
…b bar, and Locked flyout position (#32701)

<!-- Please let the below note in for people that find this PR -->
> [!NOTE]
> Are you waiting for the changes in this PR to be merged?
> It would be very helpful if you could [test the resulting
artifacts](https://github.com/dotnet/maui/wiki/Testing-PR-Builds) from
this PR and let us know in a comment if this change resolves your issue.
Thank you!

<!--
!!!!!!! MAIN IS THE ONLY ACTIVE BRANCH. MAKE SURE THIS PR IS TARGETING
MAIN. !!!!!!!
-->
### Issues

- Flyout menu items do not update correctly for RTL direction
- Tab bar and its content do not update correctly for RTL direction
- When flyout behavior is in locked state, flyout X position is not
aligned correctly for RTL direction

### Root Cause

- Flow direction is not set for menu item cells of UITableViewCell,
flyout header, footer, tab bar items and their content
- Flyout X position is incorrectly calculated in flyout locked state for
right-to-left direction

### Description of Changes

- Ensured that Shell flyout headers and footers inherit the parent
Shell's FlowDirection when set to MatchParent, and applied the flow
direction to their platform views
- Updated the flow direction for Shell section views, navigation bars,
and tab bars to respect the Shell's flow direction, including handling
cases where tab bar items are present
- Modified ShellTableViewSource to inherit flow direction from Shell for
menu item cells when set to MatchParent, and applied the correct flow
direction to the platform view
- Adjusted flyout positioning logic in RTL mode to correctly handle the
Locked flyout behavior


Validated the behaviour in the following platforms
- [x] Android
- [x] Windows ,
- [x]  iOS, 
- [x] MacOS

### Issues Fixed

Fixes #32419 

### Output 

**iOS**

|Before|After|
|--|--|
| <video
src="https://github.com/user-attachments/assets/50d731bc-3f19-4fd5-af7e-425bb7dae279"
>| <video
src="https://github.com/user-attachments/assets/40a95d05-edcb-42c3-b3f0-16c8c78fdaea">|

**macOS**
|Before|After|
|--|--|
| <video
src="https://github.com/user-attachments/assets/df45b88f-735d-4ea0-bd1a-9592b05ab7ee"
>| <video
src="https://github.com/user-attachments/assets/a681d6d1-8b34-4175-ab7a-01d5642d8fad">|

---------
@PureWeen PureWeen mentioned this pull request Apr 14, 2026
devanathan-vaithiyanathan pushed a commit to Tamilarasan-Paranthaman/maui that referenced this pull request Apr 21, 2026
…b bar, and Locked flyout position (dotnet#32701)

<!-- Please let the below note in for people that find this PR -->
> [!NOTE]
> Are you waiting for the changes in this PR to be merged?
> It would be very helpful if you could [test the resulting
artifacts](https://github.com/dotnet/maui/wiki/Testing-PR-Builds) from
this PR and let us know in a comment if this change resolves your issue.
Thank you!

<!--
!!!!!!! MAIN IS THE ONLY ACTIVE BRANCH. MAKE SURE THIS PR IS TARGETING
MAIN. !!!!!!!
-->
### Issues

- Flyout menu items do not update correctly for RTL direction
- Tab bar and its content do not update correctly for RTL direction
- When flyout behavior is in locked state, flyout X position is not
aligned correctly for RTL direction

### Root Cause

- Flow direction is not set for menu item cells of UITableViewCell,
flyout header, footer, tab bar items and their content
- Flyout X position is incorrectly calculated in flyout locked state for
right-to-left direction

### Description of Changes

- Ensured that Shell flyout headers and footers inherit the parent
Shell's FlowDirection when set to MatchParent, and applied the flow
direction to their platform views
- Updated the flow direction for Shell section views, navigation bars,
and tab bars to respect the Shell's flow direction, including handling
cases where tab bar items are present
- Modified ShellTableViewSource to inherit flow direction from Shell for
menu item cells when set to MatchParent, and applied the correct flow
direction to the platform view
- Adjusted flyout positioning logic in RTL mode to correctly handle the
Locked flyout behavior


Validated the behaviour in the following platforms
- [x] Android
- [x] Windows ,
- [x]  iOS, 
- [x] MacOS

### Issues Fixed

Fixes dotnet#32419 

### Output 

**iOS**

|Before|After|
|--|--|
| <video
src="https://github.com/user-attachments/assets/50d731bc-3f19-4fd5-af7e-425bb7dae279"
>| <video
src="https://github.com/user-attachments/assets/40a95d05-edcb-42c3-b3f0-16c8c78fdaea">|

**macOS**
|Before|After|
|--|--|
| <video
src="https://github.com/user-attachments/assets/df45b88f-735d-4ea0-bd1a-9592b05ab7ee"
>| <video
src="https://github.com/user-attachments/assets/a681d6d1-8b34-4175-ab7a-01d5642d8fad">|

---------
Ahamed-Ali pushed a commit that referenced this pull request Apr 22, 2026
…b bar, and Locked flyout position (#32701)

<!-- Please let the below note in for people that find this PR -->
> [!NOTE]
> Are you waiting for the changes in this PR to be merged?
> It would be very helpful if you could [test the resulting
artifacts](https://github.com/dotnet/maui/wiki/Testing-PR-Builds) from
this PR and let us know in a comment if this change resolves your issue.
Thank you!

<!--
!!!!!!! MAIN IS THE ONLY ACTIVE BRANCH. MAKE SURE THIS PR IS TARGETING
MAIN. !!!!!!!
-->
### Issues

- Flyout menu items do not update correctly for RTL direction
- Tab bar and its content do not update correctly for RTL direction
- When flyout behavior is in locked state, flyout X position is not
aligned correctly for RTL direction

### Root Cause

- Flow direction is not set for menu item cells of UITableViewCell,
flyout header, footer, tab bar items and their content
- Flyout X position is incorrectly calculated in flyout locked state for
right-to-left direction

### Description of Changes

- Ensured that Shell flyout headers and footers inherit the parent
Shell's FlowDirection when set to MatchParent, and applied the flow
direction to their platform views
- Updated the flow direction for Shell section views, navigation bars,
and tab bars to respect the Shell's flow direction, including handling
cases where tab bar items are present
- Modified ShellTableViewSource to inherit flow direction from Shell for
menu item cells when set to MatchParent, and applied the correct flow
direction to the platform view
- Adjusted flyout positioning logic in RTL mode to correctly handle the
Locked flyout behavior


Validated the behaviour in the following platforms
- [x] Android
- [x] Windows ,
- [x]  iOS, 
- [x] MacOS

### Issues Fixed

Fixes #32419 

### Output 

**iOS**

|Before|After|
|--|--|
| <video
src="https://github.com/user-attachments/assets/50d731bc-3f19-4fd5-af7e-425bb7dae279"
>| <video
src="https://github.com/user-attachments/assets/40a95d05-edcb-42c3-b3f0-16c8c78fdaea">|

**macOS**
|Before|After|
|--|--|
| <video
src="https://github.com/user-attachments/assets/df45b88f-735d-4ea0-bd1a-9592b05ab7ee"
>| <video
src="https://github.com/user-attachments/assets/a681d6d1-8b34-4175-ab7a-01d5642d8fad">|

---------
PureWeen pushed a commit that referenced this pull request Apr 22, 2026
…b bar, and Locked flyout position (#32701)

<!-- Please let the below note in for people that find this PR -->
> [!NOTE]
> Are you waiting for the changes in this PR to be merged?
> It would be very helpful if you could [test the resulting
artifacts](https://github.com/dotnet/maui/wiki/Testing-PR-Builds) from
this PR and let us know in a comment if this change resolves your issue.
Thank you!

<!--
!!!!!!! MAIN IS THE ONLY ACTIVE BRANCH. MAKE SURE THIS PR IS TARGETING
MAIN. !!!!!!!
-->
### Issues

- Flyout menu items do not update correctly for RTL direction
- Tab bar and its content do not update correctly for RTL direction
- When flyout behavior is in locked state, flyout X position is not
aligned correctly for RTL direction

### Root Cause

- Flow direction is not set for menu item cells of UITableViewCell,
flyout header, footer, tab bar items and their content
- Flyout X position is incorrectly calculated in flyout locked state for
right-to-left direction

### Description of Changes

- Ensured that Shell flyout headers and footers inherit the parent
Shell's FlowDirection when set to MatchParent, and applied the flow
direction to their platform views
- Updated the flow direction for Shell section views, navigation bars,
and tab bars to respect the Shell's flow direction, including handling
cases where tab bar items are present
- Modified ShellTableViewSource to inherit flow direction from Shell for
menu item cells when set to MatchParent, and applied the correct flow
direction to the platform view
- Adjusted flyout positioning logic in RTL mode to correctly handle the
Locked flyout behavior


Validated the behaviour in the following platforms
- [x] Android
- [x] Windows ,
- [x]  iOS, 
- [x] MacOS

### Issues Fixed

Fixes #32419 

### Output 

**iOS**

|Before|After|
|--|--|
| <video
src="https://github.com/user-attachments/assets/50d731bc-3f19-4fd5-af7e-425bb7dae279"
>| <video
src="https://github.com/user-attachments/assets/40a95d05-edcb-42c3-b3f0-16c8c78fdaea">|

**macOS**
|Before|After|
|--|--|
| <video
src="https://github.com/user-attachments/assets/df45b88f-735d-4ea0-bd1a-9592b05ab7ee"
>| <video
src="https://github.com/user-attachments/assets/a681d6d1-8b34-4175-ab7a-01d5642d8fad">|

---------
PureWeen pushed a commit that referenced this pull request Apr 28, 2026
…b bar, and Locked flyout position (#32701)

<!-- Please let the below note in for people that find this PR -->
> [!NOTE]
> Are you waiting for the changes in this PR to be merged?
> It would be very helpful if you could [test the resulting
artifacts](https://github.com/dotnet/maui/wiki/Testing-PR-Builds) from
this PR and let us know in a comment if this change resolves your issue.
Thank you!

<!--
!!!!!!! MAIN IS THE ONLY ACTIVE BRANCH. MAKE SURE THIS PR IS TARGETING
MAIN. !!!!!!!
-->
### Issues

- Flyout menu items do not update correctly for RTL direction
- Tab bar and its content do not update correctly for RTL direction
- When flyout behavior is in locked state, flyout X position is not
aligned correctly for RTL direction

### Root Cause

- Flow direction is not set for menu item cells of UITableViewCell,
flyout header, footer, tab bar items and their content
- Flyout X position is incorrectly calculated in flyout locked state for
right-to-left direction

### Description of Changes

- Ensured that Shell flyout headers and footers inherit the parent
Shell's FlowDirection when set to MatchParent, and applied the flow
direction to their platform views
- Updated the flow direction for Shell section views, navigation bars,
and tab bars to respect the Shell's flow direction, including handling
cases where tab bar items are present
- Modified ShellTableViewSource to inherit flow direction from Shell for
menu item cells when set to MatchParent, and applied the correct flow
direction to the platform view
- Adjusted flyout positioning logic in RTL mode to correctly handle the
Locked flyout behavior


Validated the behaviour in the following platforms
- [x] Android
- [x] Windows ,
- [x]  iOS, 
- [x] MacOS

### Issues Fixed

Fixes #32419 

### Output 

**iOS**

|Before|After|
|--|--|
| <video
src="https://github.com/user-attachments/assets/50d731bc-3f19-4fd5-af7e-425bb7dae279"
>| <video
src="https://github.com/user-attachments/assets/40a95d05-edcb-42c3-b3f0-16c8c78fdaea">|

**macOS**
|Before|After|
|--|--|
| <video
src="https://github.com/user-attachments/assets/df45b88f-735d-4ea0-bd1a-9592b05ab7ee"
>| <video
src="https://github.com/user-attachments/assets/a681d6d1-8b34-4175-ab7a-01d5642d8fad">|

---------
PureWeen added a commit that referenced this pull request Apr 29, 2026
## Blazor
- Fix: Filter precompressed RCL assets from MAUI Blazor Hybrid APKs by
@mattleibow in #33917
  <details>
  <summary>🔧 Fixes</summary>

- [.NET MAUI Blazor Hybrid App should not precompress
assets](#33773)
  </details>

- [Windows] Fix for Runtime error when closing external window with WPF
Webview Control by @BagavathiPerumal in
#34006
  <details>
  <summary>🔧 Fixes</summary>

- [Runtime error when closing external window with WPF Webview
Control](#32944)
  </details>

## Button
- [Android] ImageButton CornerRadius not being applied - fix by @kubaflo
in #30074
  <details>
  <summary>🔧 Fixes</summary>

- [ImageButton CornerRadius not being applied on
Android](#23854)
  </details>

- Fix Disabled visual state ignored when Button has locally-set
BackgroundColor/TextColor by @Dhivya-SF4094 in
#34444
  <details>
  <summary>🔧 Fixes</summary>

- [[regression/9.0] VisualState "Disabled" is not properly applied for
Button with custom
appearance](#34363)
  </details>

## CollectionView
- Fix CollectionView grid spacing updates for first row and column by
@KarthikRajaKalaimani in #34527
  <details>
  <summary>🔧 Fixes</summary>

- [[MAUI] I2_Vertical grid for horizontal Item Spacing and Vertical Item
Spacing - horizontally updating the spacing only applies to the second
column](#34257)
  </details>

- Fix CollectionView record struct selection on Windows by
@jeremy-visionaid in #33488

- [Android] Ensure disconnected ItemsViewHandler doesn't hold onto the
items source by @filipnavara in
#24610
  <details>
  <summary>🔧 Fixes</summary>

- [Crash on NullReferenceException with measurement cells in
CollectionView](#24304)
  </details>

- [Windows] Fixed VisualState Setters not working properly for
CollectionView by @Dhivya-SF4094 in
#27230
  <details>
  <summary>🔧 Fixes</summary>

- [VisualState Setters not working properly on Windows for a
CollectionView](#27086)
- [[regression/8.0.3] [Windows][CollectionView]Label Disappear when set
Style in
ContentPage.Resources](#19209)
- [[Windows] Label style defined as ContentPage Resource doesn't
propagate to
CollectionView](#18701)
  </details>

- [Windows] Fixed Margin doesn't work inside CollectionView EmptyView by
@Dhivya-SF4094 in #29897
  <details>
  <summary>🔧 Fixes</summary>

- [Margin doesn't work inside CollectionView
EmptyView](#8494)
  </details>

- [Android, Windows] Fix CarouselView PreviousPosition/PreviousItem
incorrect during animated ScrollTo() by @praveenkumarkarunanithi in
#34570
  <details>
  <summary>🔧 Fixes</summary>

- [[Android] CurrentItemChangedEventArgs.PreviousItem and
PositionChangedEventArgs.PreviousPosition Not Updating Correctly When
Using ScrollTo or Setting
Position](#29544)
  </details>

- [iOS] CarouselView2: Update internal scroll indicators for
compositional layout by @SubhikshaSf4851 in
#33639
  <details>
  <summary>🔧 Fixes</summary>

- [[iOS] Horizontal Scroll Bar Not Visible on CarouselView
(CV2)](#29390)
  </details>

- [CarouselViewHandler2] Fir fox CurrentItem does not work when
ItemSpacing is set by @SyedAbdulAzeemSF4852 in
#32135
  <details>
  <summary>🔧 Fixes</summary>

- [[CarouselViewHandler2] CurrentItem does not work when ItemSpacing is
set](#32048)
  </details>

- [iOS] Fix for Incorrect Scroll in Loop Mode When CurrentItem Is Not
Found in ItemsSource by @SyedAbdulAzeemSF4852 in
#32141
  <details>
  <summary>🔧 Fixes</summary>

- [[Android & iOS] Setting an invalid CurrentItem causes scroll to last
item in looped
CarouselView](#32139)
  </details>

- [Android] IndicatorView: Add TalkBack accessibility descriptions for
indicators by @praveenkumarkarunanithi in
#31775
  <details>
  <summary>🔧 Fixes</summary>

- [[Android] IndicatorView does not convey correct accessibility
information](#31446)
  </details>

- [iOS, macOS] Fixed CollectionView KeepLastItemInView Not Updating
Correctly When Items Are Added Dynamically by @NanthiniMahalingam in
#32191
  <details>
  <summary>🔧 Fixes</summary>

- [[.NET10] I9 - Scroll_Position - "KeepLastItemInView" does not keep
the last item at the end of the displayed list when adding new
items.](#31825)
  </details>

- [Windows, Android] Resolved issue with dynamic Header/Footer
reassignment in CollectionView. by @prakashKannanSf3972 in
#28403
  <details>
  <summary>🔧 Fixes</summary>

- [[Windows, Android] Toggling Header/Footer in CollectionView
Dynamically is not working](#27959)
- [CollectionView HeaderTemplate and FooterTemplate are not displayed
when ItemsSource is initially set to
null](#28337)
- [[Android] Header and Footer Not Visible in CollectionView When
EmptyView is Selected
First](#28351)
  </details>

- [Android] Fix CollectionView inside disabled RefreshView blocks scroll
by @Vignesh-SF3580 in #34702
  <details>
  <summary>🔧 Fixes</summary>

- [C6-The C6 page cannot scroll on Windows and Android
platforms.](#34666)
  </details>

- [Android] CollectionView: Fix SelectedItem visual state not applying
when re-selecting same item by @KarthikRajaKalaimani in
#31591
  <details>
  <summary>🔧 Fixes</summary>

- [CollectionView - SelectedItem visual state manager not
working](#20062)
  </details>

- [Windows] Fixed CollectionView.EmptyView can not be removed by setting
it to Null by @Dhivya-SF4094 in
#29487
  <details>
  <summary>🔧 Fixes</summary>

- [[Windows] CollectionView.EmptyView can not be removed by setting it
to Null](#18657)
- [[Windows] EmptyViewTemplate Not Working in
CarouselView](#29463)
- [EmptyViewTemplate does not do
anything](#18551)
- [[MAUI] I5_EmptyView - The data template selector cannot display the
correct string.](#23330)
  </details>

- [iOS] Support for IsSwipeEnabled on CarouselView2 by @kubaflo in
#29996
  <details>
  <summary>🔧 Fixes</summary>

- [[iOS] IsSwipeEnabled Not Working on CarouselView
(CV2)](#29391)
  </details>

- [iOS, MacOS] Fixed FlowDirection not working on Header/Footer in
CollectionView by @Dhivya-SF4094 in
#32775
  <details>
  <summary>🔧 Fixes</summary>

- [[iOS, MacOS] FlowDirection not working on Header/Footer in
CollectionView](#32771)
  </details>

- [iOS] CollectionView: Fix drag-and-drop reordering into empty groups
by @SuthiYuvaraj in #34151
  <details>
  <summary>🔧 Fixes</summary>

- [CollectionView Drag and Drop Reordering Can't Drop in Empty
Group](#12008)
  </details>

- [Android] CollectionView: Fix drag-and-drop reordering into empty
groups by @SuthiYuvaraj in #31867
  <details>
  <summary>🔧 Fixes</summary>

- [CollectionView Drag and Drop Reordering Can't Drop in Empty
Group](#12008)
  </details>

- [iOS] Fix vertical CarouselView MandatorySingle snapping on iOS by
@Vignesh-SF3580 in #34700
  <details>
  <summary>🔧 Fixes</summary>

- [CarouselView vertical snap points ignored on iOS with
Microsoft.Maui.Controls v10.0.20 (regression from
v9.0.120)](#33308)
  </details>

- [iOS26] Fix CarouselView scrolling to wrong item when navigating to
last item by @Vignesh-SF3580 in
#34013
  <details>
  <summary>🔧 Fixes</summary>

- [[iOS 26] CarouselView does not scroll to the correct last
item](#33770)
  </details>

- Fixed the OnPlatform does not work for header property in Collection
view by @NanthiniMahalingam in #28935
  <details>
  <summary>🔧 Fixes</summary>

- [OnPlatform does not work in Header of
CollectionView](#25124)
  </details>

- [Android] [Candidate branch] Fix
VerifySelectedItemClearsOnNullAssignment,
CollectionViewSelectionShouldClear, SelectedItemVisualIsCleared UI test
failure on Android by @KarthikRajaKalaimani in
#34928

## DateTimePicker
- [iOS] Fix for DatePicker FlowDirection Not Working on iOS by
@SyedAbdulAzeemSF4852 in #30193
  <details>
  <summary>🔧 Fixes</summary>

- [[iOS] DatePicker FlowDirection Not Working on
iOS](#30065)
  </details>

## Drawing
- [Shapes] Line: Fix asymmetric Stretch.None path translation when
right/bottom edge overflows by @NirmalKumarYuvaraj in
#34385
  <details>
  <summary>🔧 Fixes</summary>

- [Line coordinates not computed
correctly](#11404)
- [Lines not drawing
correctly](#26961)
  </details>

- [Android] Fixed GraphicsView drawable is visible outside the canvas by
@NirmalKumarYuvaraj in #28353
  <details>
  <summary>🔧 Fixes</summary>

- [[Android] GraphicsView, The drawn image can also be visible outside
the canvas](#20834)
  </details>

- Fixed Custom Drawable does not support binding by @NirmalKumarYuvaraj
in #29442
  <details>
  <summary>🔧 Fixes</summary>

- [Custom IDrawable control does not databind to a model property when
used inside a CollectionView
ItemTemplate](#20991)
  </details>

- Added a support for GradientBrushes on Shape.Stroke by @kubaflo in
#22208
  <details>
  <summary>🔧 Fixes</summary>

- [GradientBrushes are not supported on
Shape.Stroke](#21983)
  </details>

## Editor
- Fixed Editor HorizontalTextAlignment does not update at run time by
@NirmalKumarYuvaraj in #25129
  <details>
  <summary>🔧 Fixes</summary>

- [Editor HorizontalTextAlignment Does not
Works.](#10987)
- [[iOS/MacOs] Right-To-Left (RTL) alignment is not applied to Editor
placeholder](#30052)
  </details>

- [Windows] Fixed Entry Editor placeholder Text CharacterSpacing by
@SubhikshaSf4851 in #30324
  <details>
  <summary>🔧 Fixes</summary>

- [[Windows] CharacterSpacing not applied to Placeholder text in Entry
and Editor controls](#30071)
  </details>

## Entry
- [Windows] Fix fo setting an Entry's Keyboard to Date causes it to be
interpreted as a password input by @SyedAbdulAzeemSF4852 in
#29344
  <details>
  <summary>🔧 Fixes</summary>

- [[Windows] Entry Keyboad-Type "Date" results in
Password-Entry](#28975)
  </details>

- [Android] Exception thrown when give more than 5000 characters to the
Text property of Entry. by @KarthikRajaKalaimani in
#30242
  <details>
  <summary>🔧 Fixes</summary>

- [Android crash when Entry has >5000
characters](#30144)
  </details>

## Essentials
- Bump MonoApiToolsMSBuildTasksPackageVersion to 0.5.0 and ship
Essentials.AI public APIs by @mattleibow via @Copilot in
#34574

- [Mac] DeviceDisplay.KeepScreenOn not being respected on Mac OS by
@HarishwaranVijayakumar in #32708
  <details>
  <summary>🔧 Fixes</summary>

- [[Mac Catalyst] DeviceDisplay.KeepScreenOn not being respected on Mac
OS](#26059)
  </details>

## Flyoutpage
- [Windows] FlyoutPage: update CollapseStyle at runtime by
@devanathan-vaithiyanathan in #29927
  <details>
  <summary>🔧 Fixes</summary>

- [Flyout Page SetCollapseStyle doesn't have any
change](#18200)
  </details>

## Gestures
- [Android] Fix for TapGestureRecognizer doesn't fire by
@HarishwaranVijayakumar in #34497
  <details>
  <summary>🔧 Fixes</summary>

- [[Android] TapGestureRecognizer doesn't
fire](#5825)
  </details>

## Image
- [Android] Fix Share.RequestAsync SecurityException on Android 10+
caused by missing ClipData by @HarishwaranVijayakumar in
#34417
  <details>
  <summary>🔧 Fixes</summary>

- [[Bug] Share.RequestAsync throws java.lang.SecurityException
(uid=1000) on Android 10+ due to missing
intent.ClipData](#34370)
  </details>

- [Windows]Fixed the MauiImage with logical name containing path issue
by @sheiksyedm in #32864
  <details>
  <summary>🔧 Fixes</summary>

- [MauiImage with LogicalName containing path - is not working on
Windows](#32356)
  </details>

- [Android, Windows & iOS] Fix Downsize/ScaleImage to maintain aspect
ratio and prevent upscaling by @SyedAbdulAzeemSF4852 in
#30808
  <details>
  <summary>🔧 Fixes</summary>

- [[Android & Windows] In GraphicsView, the aspect ratio is not
maintained when Downsize is called with both maxWidth and
maxHeight](#30803)
  </details>

## Label
- [iOS , macOS] Fixed Label text cropping when a width request is
specified on the label inside a VerticalStackLayout with specified width
request by @NanthiniMahalingam in
#29166
  <details>
  <summary>🔧 Fixes</summary>

- [Label text gets cropped when a width request is specified on the
label inside a
VerticalStackLayout](#28660)
- [[iOS] Label with a fixed WidthRequest has wrong
height](#26644)
  </details>

- [Android] Fix Label word wrapping clips text depending on alignment
and layout options by @Dhivya-SF4094 in
#34533
  <details>
  <summary>🔧 Fixes</summary>

- [Bug: Android Label word wrapping clips text depending on alignment
and layout options](#34459)
  </details>

- LineHeight and decorations for HTML Label - fix by @kubaflo in
#31202
  <details>
  <summary>🔧 Fixes</summary>

- [LineHeight with HTML Label not
working](#22193)
  - [lineheight is broken ](#22197)
  </details>

- [iOS] Fix Label with TailTruncation not rendering after
empty-to-non-empty text transition by @kubaflo in
#34812
  <details>
  <summary>🔧 Fixes</summary>

- [Label with LineBreakMode="TailTruncation" does not render text if
initial Text is null or empty on first render
(iOS)](#34591)
  </details>

## Layout
- [Android] Fix overflowing children clipped when parent Opacity < 1 by
@SyedAbdulAzeemSF4852 in #34565
  <details>
  <summary>🔧 Fixes</summary>

- [Maui Android parent view inappropriately creates clipping mask when
its opacity is less than 1, cropping out
children](#22038)
  </details>

- Fixed the FlexLayout reverse issue with the AlignContent by
@Ahamed-Ali in #32134
  <details>
  <summary>🔧 Fixes</summary>

- [FlexLayout alignment issue when Wrap is set to Reverse and
AlignContent is set to SpaceAround, SpaceBetween or
SpaceEvenly](#31565)
  </details>

- [iOS/Mac] Fixed BoxView in AbsoluteLayout did not return to its
default AutoSize for Height and Width after reset by @Dhivya-SF4094 in
#31648
  <details>
  <summary>🔧 Fixes</summary>

- [[iOS, Catalyst] BoxView in AbsoluteLayout does not return to default
AutoSize for Height/Width after
reset](#31496)
  </details>

## Map
- [Windows] Implement WinUI 3 MapControl handler using Azure Maps by
@jfversluis in #34138

## Modal
- [Android] PopToRootAsync for modal pages - improvements by @kubaflo in
#26851
  <details>
  <summary>🔧 Fixes</summary>

- [Shell PopToRootAsync doesn't happen instantly - previous pages flash
quickly. Only happens in NET
9](#26846)
  </details>

- [Android] Fix HideSoftInputOnTapped doesn't work on Modal Pages by
@HarishwaranVijayakumar in #34770
  <details>
  <summary>🔧 Fixes</summary>

- [HideSoftInputOnTapped doesn't work on Modal
Pages](#34730)
  </details>

## Navigation
- [iOS] Alert popup may be displayed on wrong window when modal page
navigation is in progress - fix by @kubaflo in
#31016
  <details>
  <summary>🔧 Fixes</summary>

- [Alert popup may be displayed on wrong window when modal page
navigation is in progress on
iOS/MacOS](#30970)
  </details>

- [Android] Page: Fix OnNavigatedTo called twice when NavigationPage is
FlyoutPage Detail by @KarthikRajaKalaimani in
#31931
  <details>
  <summary>🔧 Fixes</summary>

- [NavigationPage and FlyoutPage both call OnNavigatedTo, so it is
called twice](#23902)
  </details>

## Picker
- Fixed the Picker didn't dismiss it when tapping outside on iOS and
MacCatalyst platform. by @KarthikRajaKalaimani in
#30067
  <details>
  <summary>🔧 Fixes</summary>

- [[regression/8.0.3] iOS Picker dismiss does not work when clicking
outside of the Picker](#19168)
  </details>

- [Windows] Fixed Picker items width wont resize back by
@SubhikshaSf4851 in #33042
  <details>
  <summary>🔧 Fixes</summary>

- [Picker items width won't resize back when its container window gets
resized down.](#32984)
  </details>

## RadioButton
- Fix TalkBack not correctly narrating RadioButtons with Content by
@SubhikshaSf4851 in #34521
  <details>
  <summary>🔧 Fixes</summary>

- [[Android] TalkBack does not correctly narrate RadioButtons with
Content](#34322)
  </details>

## SafeArea
- [Android] Fix SafeAreaShouldWorkOnAllShellTabs test failure on API 36
by @praveenkumarkarunanithi in #34239

## ScrollView
- [iOS] Preserve ScrollView offsets when Orientation changes to Neither
by @Vignesh-SF3580 in #34672
  <details>
  <summary>🔧 Fixes</summary>

- [Incorrect implementation of
ScrollView.Orientation](#34583)
  </details>

## Searchbar
- [Android] Fix SearchBar text bleeding between instances after
navigation by @SyedAbdulAzeemSF4852 in
#34703
  <details>
  <summary>🔧 Fixes</summary>

- [MAUI Android: SearchBar copies content from one to the
other](#20348)
  </details>

- Fixed SearchBar CursorPosition and SelectionLength not updating when
typing by @Dhivya-SF4094 in #34347
  <details>
  <summary>🔧 Fixes</summary>

- [SearchBar - CursorPosition and SelectionLength are not updated when
the user types](#30779)
  </details>

## SearchBar
- [Windows] Fixed SearchHandler issues by @Tamilarasan-Paranthaman in
#29520
  <details>
  <summary>🔧 Fixes</summary>

- [[Windows] SearchHandler APIs are not functioning
properly](#29493)
  </details>

## Shell
- [iOS, Mac] Fix for Background set to Transparent doesn't have the same
behavior as BackgroundColor Transparent by @HarishwaranVijayakumar in
#32245
  <details>
  <summary>🔧 Fixes</summary>

- [Background set to Transparent doesn't have the same behavior as
BackgroundColor =
Transparent](#22769)
  </details>

- [iOS] Fix App crash with NullReferenceException in
ShellSectionRenderer by @devanathan-vaithiyanathan in
#32109
  <details>
  <summary>🔧 Fixes</summary>

- [[iOS] App crash with NullReferenceException in
ShellSectionRenderer](#31961)
  </details>

- [Android] Fixed back button icon selection logic in
ShellToolbarTracker by @kubaflo in
#32080
  <details>
  <summary>🔧 Fixes</summary>

- [IconOverride in Shell.BackButtonBehavior does not
work.](#32050)
  </details>

- Fix TabBarIsVisible Not Updating Dynamically When Set on ShellContent
by @Vignesh-SF3580 in #33090
  <details>
  <summary>🔧 Fixes</summary>

- [Shell.TabBarIsVisible is not updated dynamically at
runtime](#32994)
  </details>

- [iOS, macOS] Shell: Fix RTL flow direction for flyout, menu cells, tab
bar, and Locked flyout position by @NanthiniMahalingam in
#32701
  <details>
  <summary>🔧 Fixes</summary>

- [[iOS, Mac Catalyst] Shell Flyout and Content Do Not Fully Support
RightToLeft (RTL)](#32419)
  </details>

- [IOS] Inconsistent Resize Behavior for Header/Footer - fix by @kubaflo
in #28713
  <details>
  <summary>🔧 Fixes</summary>

- [[IOS, Mac] Inconsistent Resize Behavior for
Header/Footer](#26397)
- [Enable Shell Flyout Header/Footer resize tests on
iOS/Catalyst](#33501)
  </details>

- [Android] Fix for SearchHandler retaining previous page SearchView
data in pages within Shell sections by @BagavathiPerumal in
#29545
  <details>
  <summary>🔧 Fixes</summary>

- [[Shell][Android] The truth is out there...but not on top tab search
handlers](#8716)
  </details>

- [Android] Fix empty space above TabBar after navigating back when
TabBar visibility is toggled by @praveenkumarkarunanithi in
#34324
  <details>
  <summary>🔧 Fixes</summary>

- [Empty space appears above TabBar after navigating back when TabBar
visibility is toggled](#33703)
- [Grid with SafeAreaEdges=Container has incorrect size when tab bar
appears](#34256)
  </details>

## SwipeView
- [Android] SwipeView: Use MeasureSpecMode.Exactly for SwipeItem layout
to fix text visibility by @Ahamed-Ali in
#27399
  <details>
  <summary>🔧 Fixes</summary>

- [[Android] Right SwipeView items are not visible in the
SwipeView.](#27367)
  </details>

- [Android] Prevent the tap that closes an open SwipeView from being
propagated to children by @sjordanGSS in
#24275
  <details>
  <summary>🔧 Fixes</summary>

- [Tapping to close a SwipeView will activate TapGestureRecognizers on
.Content](#23921)
  </details>

## Switch
- [iOS & Mac] Fix for SearchHandler retains previous page state when
switching top tabs by @BagavathiPerumal in
#34735
  <details>
  <summary>🔧 Fixes</summary>

- [[Shell] [iOS & Mac] SearchHandler retains previous page state when
switching top tabs](#34693)
  </details>

## TabbedPage
- [Android] Fixed NullReferenceException in app with TabBar after
returning from minimized state by @NirmalKumarYuvaraj in
#34779
  <details>
  <summary>🔧 Fixes</summary>

- [NullReferenceException in app with TabBar after returning from
minimized state](#34720)
  </details>

## Titlebar
- Fixed BindingContext of the Window TitleBar is not being passed on to
its child content. by @NirmalKumarYuvaraj in
#30080
  <details>
  <summary>🔧 Fixes</summary>

- [The BindingContext of the Window TitleBar is not being passed on to
its child content.](#24831)
  </details>

- [Windows/Mac] Fix RTL FlowDirection causes overlap with native window
control buttons in TitleBar by @devanathan-vaithiyanathan in
#30400
  <details>
  <summary>🔧 Fixes</summary>

- [[Windows, Mac] RTL FlowDirection causes overlap with native window
control buttons in
TitleBar](#30399)
  </details>

## WebView
- [Windows] Fix WebView background color not being applied by
@SubhikshaSf4851 in #34599
  <details>
  <summary>🔧 Fixes</summary>

- [WebView background color has changed after update, can't
override.](#34518)
  </details>

- [Android] Fix for WebView/HybridWebView briefly flashes full screen
before layout completes by @praveenkumarkarunanithi in
#33207
  <details>
  <summary>🔧 Fixes</summary>

- [[Android] HybridWebView briefly resizes to full screen when page is
opened before snapping back to correct
size](#31475)
  </details>

## Xaml
- Improved style inheritance by @kubaflo in
#31317
  <details>
  <summary>🔧 Fixes</summary>

- [Styles based on a style that is based on another style that uses
AppThemeBinding do not inherit properties
correctly.](#31280)
  </details>

- Fix for VisualStateManager Setter.TargetName failing when
ControlTemplate is applied by @BagavathiPerumal in
#33208
  <details>
  <summary>🔧 Fixes</summary>

- [Setter.TargetName + ControlTemplate
crash](#26977)
  </details>


<details>
<summary>🧪 Testing (4)</summary>

- [Testing] Additional Feature Matrix Event Test Cases for Slider and
ScrollView by @nivetha-nagalingam in
#34352
- [Testing] Fixed Build error on inflight/ candidate PR 34885 by
@NafeelaNazhir in #34891
- [Testing] Fixed UI test image failure in PR 34885 - [13/4/2026] by
@NafeelaNazhir in #34933
- Fixed test failure - CursorPositionUpdatesWhenSearchBarGainsFocus by
@Dhivya-SF4094 in #34938

</details>

<details>
<summary>📦 Other (3)</summary>

- Fix Loaded event not called for MAUI View added to native View by
@NirmalKumarYuvaraj in #34345
  <details>
  <summary>🔧 Fixes</summary>

- [Loaded event not called for MAUI View added to native
View](#34310)
  </details>
- Add public IAlertManager and IAlertManagerSubscription interfaces by
@Redth in #34228
  <details>
  <summary>🔧 Fixes</summary>

- [Alert/Dialog system (`DisplayAlert`, `DisplayActionSheet`,
`DisplayPromptAsync`) needs a public extensibility
point](#34104)
  </details>
- Fix crash when displaying alerts on unloaded pages by @kubaflo in
#33288

</details>

<details>
<summary>📝 Issue References</summary>

Fixes #5825, Fixes #8494, Fixes #8716, Fixes #10987, Fixes #11404, Fixes
#12008, Fixes #18200, Fixes #18551, Fixes #18657, Fixes #18701, Fixes
#19168, Fixes #19209, Fixes #20062, Fixes #20348, Fixes #20834, Fixes
#20991, Fixes #21983, Fixes #22038, Fixes #22193, Fixes #22197, Fixes
#22769, Fixes #23330, Fixes #23854, Fixes #23902, Fixes #23921, Fixes
#24304, Fixes #24831, Fixes #25124, Fixes #26059, Fixes #26397, Fixes
#26644, Fixes #26846, Fixes #26961, Fixes #26977, Fixes #27086, Fixes
#27367, Fixes #27959, Fixes #28337, Fixes #28351, Fixes #28660, Fixes
#28975, Fixes #29390, Fixes #29391, Fixes #29463, Fixes #29493, Fixes
#29544, Fixes #30052, Fixes #30065, Fixes #30071, Fixes #30144, Fixes
#30399, Fixes #30779, Fixes #30803, Fixes #30970, Fixes #31280, Fixes
#31446, Fixes #31475, Fixes #31496, Fixes #31565, Fixes #31825, Fixes
#31961, Fixes #32048, Fixes #32050, Fixes #32139, Fixes #32356, Fixes
#32419, Fixes #32771, Fixes #32944, Fixes #32984, Fixes #32994, Fixes
#33308, Fixes #33501, Fixes #33703, Fixes #33770, Fixes #33773, Fixes
#34104, Fixes #34256, Fixes #34257, Fixes #34310, Fixes #34322, Fixes
#34363, Fixes #34370, Fixes #34459, Fixes #34518, Fixes #34583, Fixes
#34591, Fixes #34666, Fixes #34693, Fixes #34720, Fixes #34730

</details>

**Full Changelog**:
main...inflight/candidate
@github-actions github-actions Bot locked and limited conversation to collaborators May 2, 2026
@kubaflo kubaflo added the s/agent-gate-passed AI verified tests catch the bug (fail without fix, pass with fix) label May 20, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-controls-shell Shell Navigation, Routes, Tabs, Flyout community ✨ Community Contribution partner/syncfusion Issues / PR's with Syncfusion collaboration platform/ios platform/macos macOS / Mac Catalyst s/agent-approved AI agent recommends approval - PR fix is correct and optimal s/agent-fix-pr-picked AI could not beat the PR fix - PR is the best among all candidates s/agent-gate-passed AI verified tests catch the bug (fail without fix, pass with fix) s/agent-reviewed PR was reviewed by AI agent workflow (full 4-phase review) shell-flyout

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[iOS, Mac Catalyst] Shell Flyout and Content Do Not Fully Support RightToLeft (RTL)