-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Remove code repetition in EventSourceSink.cs #10245
Copy link
Copy link
Closed
Labels
Priority:3Work that is nice to haveWork that is nice to haveRefactoringhelp wantedIssues that the core team doesn't plan to work on, but would accept a PR for. Comment to claim.Issues that the core team doesn't plan to work on, but would accept a PR for. Comment to claim.internal-team-onboardingtriaged
Description
Activity
Metadata
Metadata
Assignees
Labels
Priority:3Work that is nice to haveWork that is nice to haveRefactoringhelp wantedIssues that the core team doesn't plan to work on, but would accept a PR for. Comment to claim.Issues that the core team doesn't plan to work on, but would accept a PR for. Comment to claim.internal-team-onboardingtriaged
Context
There is large code repetition created by copy pasting the event handlers invoking
https://github.com/dotnet/msbuild/blob/main/src/Build/BackEnd/Components/Logging/EventSourceSink.cs#L321-L977
We should be able to easily extract tho code using generic delegates and reduce the size of class significantly
Impact
Engineering only - reduced codebase size (hence easier reading and lower chance for errors during mechanical copy-pasting)
How to