[SPIKE] Add Json Communication Protocol - #11458
Closed
YuliiaKovalova wants to merge 26 commits into
Closed
YuliiaKovalova wants to merge 26 commits into
YuliiaKovalova wants to merge 26 commits into
Conversation
YuliiaKovalova
force-pushed
the
dev/ykovalova/update_communication_protocol
branch
from
February 19, 2025 12:08
0ade4ae to
8dc4afb
Compare
…/github.com/YuliiaKovalova/msbuild into dev/ykovalova/update_communication_protocol
Member
Author
|
agreed to stick to the existing communication mechanism |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the changes are made on the top of #11393
many files were touched due to changes in
internal static INodePacket FactoryForDeserialization(ITranslatorBase translator)ITranslator -> ITranslatorBase
Summary
This PR introduces a new JSON-based protocol for communication with dotnet.exe in MSBuild, improving the extensibility and maintainability of our inter-process communication. The implementation includes new interfaces for JSON translation and packet handling, along with the necessary infrastructure to support this protocol.
Changes
ITranslatable2interface extendingITranslatablewith JSON translation supportINodePacket2interface implementingITranslatable2for packet handlingJsonTranslatorclassTaskHostConfigurationandNodeBuildCompleteto implementINodePacket2(these are registered byOutOfProcTaskHostNode)NodeEndpointOutOfProcBaseto instantiateJsonTranslatorfor .NET host scenariosImplementation Details
New Interfaces
Protocol Integration
The JSON protocol is instantiated in
NodeEndpointOutOfProcBasewhenisNetHostis true, providing a clean separation between different communication protocols while maintaining backward compatibility.Breaking Changes
None. This is a backward-compatible change that introduces new functionality without affecting existing behavior.
OPEN QUESTIONS