Fill holes in BuildEventContext construction and evaluation ID propagation - #12946

Closed

baronfel wants to merge 37 commits into

mainfrom

unify-buildeventcontext-id-tracking

Commits on Feb 26, 2026

Try to prevent direct creation of buildeventcontexts so we can control id propagation
baronfel
committed
e239862
Convert all other callsites to use the builder API
baronfel
committed
29a9003
update compat baselines - we'll likely need to revert this, but this is an accounting of what's changed and enables the rest of the build to occur
baronfel
committed
7b84cc8
Make the context type a ref struct builder for perf
baronfel
committed
8ae2981
remove useless tests
baronfel
committed
b112c5a
Resolve review comments about readonly/etc.
baronfel
committed
460385f
Try to stash project evaluation Ids so that we don't lose them for tracking purposes when project configurations are temporarily cached.
baronfel
committed
7c99f19
Fix this spot too
baronfel
committed
b9b82dd
try to rely only on cached data for eval ids
baronfel
committed
713f543
Add serialization of evaluation id to projectstarted event translation in a version-compatible way
baronfel
committed
8f98353
use safer accessor for project evaluation id for buildrequestconfigurations
baronfel
committed
e64739e
Correct some auto-migrated callsite chains so that test invariants are preserved
baronfel
committed
1af6b83
Fix a few more missed expectations
baronfel
committed
320682f
Reduce the direct use of CreateInitial in favor of flowing contexts through the system more directly
baronfel
committed
7b99811
Another refactoring to reduce direct usage of CreateInitial and flow more contexts
baronfel
committed
6af723f
Make submissions track their own build event context
baronfel
committed
f5ddbf7
Make it possible to send projectstarted events that represent the node the project lived on when sending cached results
baronfel
committed
985b26d
Transfer evaluation ids across nodes too!
baronfel
committed
fca1a1a
Try to make explicit pathways for cached and non-cached project start flows
baronfel
committed
61b994f
update callsites for use-case-specific constructors
baronfel
committed
866f60b
Fix some subtle invariants around needing new projectContextIds, especially for cached project contexts
baronfel
committed
2b07c50
Remove test that is meaningless due to API forcing good pathways
baronfel
committed
694f1e5
fix assert to check the correct invariant
baronfel
committed
cc49b33
Fix incorrect node context creation - we correctly only ever log the cache-based projectstarted messages from the scheduler node. Before we were incorrectly saying they came from the remote node.
baronfel
committed
14c0ce4
remove invalid assert because it was logically incorrect
baronfel
committed
90182ba
tighten up buildeventcontext creation APIs
baronfel
committed
dc96424
Remove unused field.
baronfel
committed
b58e86f

Commits on Mar 2, 2026

Merge branch 'main' into unify-buildeventcontext-id-tracking
JanProvaznik
authored
dabc165

Commits on Apr 9, 2026

Fix test hangs and failures in BuildEventContext PR

JanProvaznik
and
Copilot
committed
df81eda
Merge remote-tracking branch 'upstream/main' into pr-12946
JanProvaznik
committed
6d40989
Fix merge conflicts with main

JanProvaznik
and
Copilot
committed
5ca89fe
Add code review findings (review.md)

JanProvaznik
and
Copilot
committed
aa0759d

Commits on Apr 13, 2026

Fix child project evaluationId/nodeId in BuildEventContext

JanProvaznik
and
Copilot
committed
24ad176
Restore PropertiesToSerialize filtering in GetProjectProperties

JanProvaznik
and
Copilot
committed
a3ea370
Restore public BuildEventContext constructors, add BannedApiAnalyzer

JanProvaznik
and
Copilot
committed
eae6a86
Remove debug File.WriteAllText left in ConsoleLogger test

JanProvaznik
and
Copilot
committed
0f382c3

Commits on Apr 16, 2026

Merge main, resolve conflicts and deduplicate _evaluationId

JanProvaznik
and
Copilot
committed
8627921