Add escape hatch MSBUILDCOPYWITHOUTDELETE - #9257
Merged
rainersigwald merged 1 commit intoSep 22, 2023
Merged
Conversation
This allows an opt-in workaround for dotnet#9250 that affected deployment processes can use, mitigating the risk of entirely reverting dotnet#8685.
|
Hello! I noticed that you're targeting one of our servicing branches. Please consider updating the version. |
baronfel
approved these changes
Sep 22, 2023
baronfel
left a comment
baronfel
left a comment
Member
There was a problem hiding this comment.
More granular flag looks good.
Member
Author
The first 17.8.0 build failed because of missing optprof data for the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work item (Internal use): N/A
Summary
This allows an opt-in workaround for #9250 that affected deployment processes can use, mitigating the risk of entirely reverting #8685.
Customer Impact
Automated deployment of new versions of apps failed in some environments.
Regression?
Yes, from #8685 (in 7.0.400/MSBuild 17.7).
Testing
Tests in the affected environment using the more-broadly-scoped
MSBUILDDISABLEFEATURESFROMVERSION=17.8pass.Risk
Minimal--adds new scoped opt-out that is redundant with known successful opt-out, using established mechanisms.