Repository navigation
Consider MVID when testing EC cache validity - #1250
Merged
Merged
Conversation
Member
Author
Member
Author
|
@pnelsonmsft I got a good laugh out of this one. :) |
Contributor
There was a problem hiding this comment.
Perhaps test with Guid.NewGuid() rather than default(Guid).
Contributor
|
LGTM |
Our EvaluationContext cache invalidation computation was consuming the method token and version, but not the identity of the declaring assembly. This lead to a strange bug where we would reuse the cache across assembly boundaries if consecutive breakpoint happened to have the same method token (each in its own assembly). I believe this bug existed before I revised the cache invalidation computation and we were just getting lucky - we used to check the spans of all containing scopes, which are unlikely to match exactly across assemblies.
amcasey
added a commit
that referenced
this pull request
Mar 13, 2015
Consider MVID when testing EC cache validity
JoeRobich
pushed a commit
that referenced
this pull request
Aug 18, 2026
This was referenced Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our EvaluationContext cache invalidation computation was consuming the
method token and version, but not the identity of the declaring assembly.
This lead to a strange bug where we would reuse the cache across assembly
boundaries if consecutive breakpoint happened to have the same method
token (each in its own assembly).
I believe this bug existed before I revised the cache invalidation
computation and we were just getting lucky - we used to check the spans
of all containing scopes, which are unlikely to match exactly across
assemblies.