We don't need to build FakeSign before CodeAnalysis anymore

[jasonmalinowski]

This was how we were (trying) to ensure that FakeSign built before projects that needed to be FakeSigned. Now that it's a NuGet package, we don't need this.

[jasonmalinowski]

Possible reviewers include (but are not limited to) @jaredpar, @amcasey, @agocke.

[amcasey]

Oh, is that how that was happening? I guess we did need to make a change for Concord.csproj.

[amcasey]

👍

[jaredpar]

👍

[pharring]

Does FakeSign.exe still get copied to the output (Binaries\Release) folder? It's needed for perf tests (we have to undo the effects of FakeSign in order to ngen Roslyn assemblies)

[jaredpar]

@dotnet-bot test this please

[jaredpar]

@pharring this shouldn't change that. It just changes the dependency mapping.

Curious though can we change these tools to use the installed NuGet? We want to remove FakeSign from the build and put it in another repo.

[jaredpar]

@dotnet-bot test this please

[jaredpar]

@mmitche Jenkins seems to be ignoring our manual "test this please" commands. Have you seen this?

[pharring]

Are you asking for my permission? If so, I have no problem with you switching to use NuGet instead of building FakeSign locally. If you're asking whether it's possible for the perf scripts to get FakeSign via NuGet instead of from the drop, then I don't see a problem with that either. I just wanted to make you aware that we run FakeSign.exe as part of perf setup and that, if it disappears from the binaries drop, then the perf scripts will have to be changed.

[mmitche]

@jaredpar It seems to have picked that one up. Are you referring to earlier? It had queued all the builds but was waiting for shutdown for an update or something.

[jaredpar]

@pharring mostly just asking if it was possible to do this. If so I can take care of it. Can you point me in the direction of these scripts so I can update them?

@mmitche I think Jenkins was just waiting for me to complain to you so I could look the fool 😄

[pharring]

See [Closed]\Test\Performance\Perf-InstallRoslyn.cmd