Repository navigation
Handle pseudo-variables with pointer types - #1433
Merged
Merged
Conversation
Member
Author
|
FYI @pnelsonmsft @cston @KevinH-MS @ManishJayaswal |
Member
Author
|
I changed the compiler, @VSadov @AlekseyTs @gafter |
Contributor
There was a problem hiding this comment.
Consider using Symbol rather than TSymbol. That is, change to GetSpecialTypeMember that returns a possibly null Symbol and have the caller cast if needed.
Member
Author
There was a problem hiding this comment.
I tried and didn't see a meaningful improvement.
Contributor
|
LGTM |
Pointer types can appear in assembly-qualified names (AQNs). Our encoding mechanism handles them, but our decoding mechanism does not. Caveat: We now support arrays of pointers, but not pointers to arrays (since neither C# nor VB supports such types).
The intrinsic methods that we call to retrieve the values of pseudo-variables from the debugger return System.Object. Unfortunately, object cannot be converted (directly) to a pointer type. Instead, we need to unbox an IntPtr and then call an explicit conversion method to get a pointer. Caveat: This won't work until the debugger actually returns a boxed IntPtr.
Member
There was a problem hiding this comment.
Well, the TryGet method places null into its out parameter when it returns false, so you can simplify this to
TryGetSpecialTypeMember(this.Compilation, member, syntax, diagnostics, out memberSymbol);
return memberSymbol;Though I admit that may be less clear.
Member
Author
There was a problem hiding this comment.
I would, but the Jenkins run has already passed. ;)
Member
|
LGTM |
amcasey
added a commit
that referenced
this pull request
Mar 20, 2015
Handle pseudo-variables with pointer types
JoeRobich
pushed a commit
that referenced
this pull request
Aug 18, 2026
Add a changelog format that makes it easier to add a changelog for VS Code
This was referenced Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The intrinsic methods that we call to retrieve the values of pseudo-variables from the debugger return System.Object. Unfortunately, object cannot be converted (directly) to a pointer type. Instead, we need to unbox an IntPtr and then call an explicit conversion method to get a pointer.
Caveat: This won't work until the debugger actually returns a boxed IntPtr.