Repository navigation
Remove unnecessary toolset compiler - #84826
Merged
Merged
Conversation
|
Azure Pipelines: Successfully started running 2 pipeline(s). There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the explicit Microsoft.Net.Compilers.Toolset package reference from the caching compiler props, relying on the current .NET SDK toolset instead (aligned with the repo moving to .NET 11 preview), so enabling caching compilation no longer brings in an extra compiler/toolset package.
Changes:
- Delete the
Microsoft.Net.Compilers.ToolsetPackageReferencefromeng/targets/CachingCompiler.props. - Keep the caching-compiler feature/property setup (
Features,PathMap,EnableSourceLink) unchanged.
jjonescz
marked this pull request as draft
August 10, 2026 11:11
jjonescz
marked this pull request as ready for review
August 10, 2026 11:11
|
Azure Pipelines: Successfully started running 2 pipeline(s). There may be pipelines that require an authorized user to comment /azp run to run. |
akhera99
approved these changes
Aug 10, 2026
333fred
approved these changes
Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Toolset compiler should not be necessary anymore for the caching compiler features (since we are on .net 11 preview now).
Also fixes these warnings that appear in roslyn-CI (and locally if you have caching compiler enabled):
Microsoft Reviewers: Open in CodeFlow