Skip to content

Move insertion PR tagger pipeline - #84955

Merged
JoeRobich merged 3 commits into
dotnet:mainfrom
JoeRobich:dev/jorobich/move-insertion-pr-tagger
Aug 19, 2026
Merged

JoeRobich merged 3 commits into
dotnet:mainfrom
JoeRobich:dev/jorobich/move-insertion-pr-tagger

Conversation

@JoeRobich

@JoeRobich JoeRobich commented Aug 18, 2026 •

Copy link
Copy Markdown
Member

This is the last of the roslyn-tools code that was still active. We can move our pipeline over to this yml once merged and archive dotnet/roslyn-tools repo.

Microsoft Reviewers: Open in CodeFlow

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 1a94b267-96a7-4585-aed8-71aad787d33b
Copilot AI lite review requested due to automatic review settings August 18, 2026 23:37
@JoeRobich
JoeRobich requested a review from a team as a code owner August 18, 2026 23:37
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 2 pipeline(s).
There may be pipelines that require an authorized user to comment /azp run to run.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a dedicated Azure Pipelines YAML for the insertion PR tagger so the remaining active automation can live in dotnet/roslyn, enabling eventual archival of dotnet/roslyn-tools.

Changes:

  • Added a new scheduled pipeline (eng/pipelines/insertion-pr-tagger.yml) that runs pr-tagger via dnx using WIF-acquired Azure DevOps tokens plus a configured GitHub PAT.
  • Updated the repository file map documentation to point contributors to eng/pipelines/ for pipeline definitions/templates.
Show a summary per file
File Description
eng/pipelines/insertion-pr-tagger.yml Introduces the scheduled PR tagger pipeline using 1ES templates, UseDotNet, and AzureCLI.
.github/memory/FILE_MAP.md Documents that pipeline definitions/templates live under eng/pipelines/.

Review details

  • Files reviewed: 2/2 changed files
  • Comments generated: 1
  • Review effort level: Lite

Comment thread eng/pipelines/insertion-pr-tagger.yml
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings August 18, 2026 23:53

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

Suppressed comments (1)

Previously missed (1) — in code that hasn't changed since the last review.

eng/pipelines/insertion-pr-tagger.yml:75

  • The inline script invokes pr-tagger without --ci (so interactive AzDO auth fallback can be enabled) and depends on dnx being available on the agent. For CI reliability, pass --ci and run the tool via dotnet tool install (similar to eng/pipelines/insert.yml) so the pipeline is self-contained and won’t hang if tokens are invalid/expired.
              $arguments = @(
                "Microsoft.RoslynTools"
                "--prerelease"
                "--add-source", "https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-eng/nuget/v3/index.json"
                "--"
  • Files reviewed: 2/2 changed files
  • Comments generated: 0 new
  • Review effort level: Lite

Comment thread eng/pipelines/insertion-pr-tagger.yml
Copilot AI review requested due to automatic review settings August 19, 2026 00:04

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

Suppressed comments (1)

Previously missed (1) — in code that hasn't changed since the last review.

eng/pipelines/insertion-pr-tagger.yml:76

  • The script invokes dnx to run Microsoft.RoslynTools, but this pipeline never installs/bootstraps dnx. That makes the job depend on whatever happens to be preinstalled on the agent image/1ES template and can break when images change. Consider invoking the tool via dotnet tool install (as documented for Microsoft.RoslynTools) and run the installed roslyn-tools shim directly.
                "--dnceng-azdo-token", $azdoToken
                "--ci"
              )

              & dnx @arguments
  • Files reviewed: 2/2 changed files
  • Comments generated: 0 new
  • Review effort level: Lite

@JoeRobich
JoeRobich merged commit 631c5a0 into dotnet:main Aug 19, 2026
25 checks passed
@jjonescz jjonescz added this to the 18.11 milestone Aug 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants