Repository navigation
Move insertion PR tagger pipeline - #84955
Merged
JoeRobich merged 3 commits intoAug 19, 2026
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 1a94b267-96a7-4585-aed8-71aad787d33b
|
Azure Pipelines: Successfully started running 2 pipeline(s). There may be pipelines that require an authorized user to comment /azp run to run. |
dibarbet
approved these changes
Aug 18, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a dedicated Azure Pipelines YAML for the insertion PR tagger so the remaining active automation can live in dotnet/roslyn, enabling eventual archival of dotnet/roslyn-tools.
Changes:
- Added a new scheduled pipeline (
eng/pipelines/insertion-pr-tagger.yml) that runspr-taggerviadnxusing WIF-acquired Azure DevOps tokens plus a configured GitHub PAT. - Updated the repository file map documentation to point contributors to
eng/pipelines/for pipeline definitions/templates.
Show a summary per file
| File | Description |
|---|---|
eng/pipelines/insertion-pr-tagger.yml |
Introduces the scheduled PR tagger pipeline using 1ES templates, UseDotNet, and AzureCLI. |
.github/memory/FILE_MAP.md |
Documents that pipeline definitions/templates live under eng/pipelines/. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Lite
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Review details
Suppressed comments (1)
Previously missed (1) — in code that hasn't changed since the last review.
eng/pipelines/insertion-pr-tagger.yml:75
- The inline script invokes
pr-taggerwithout--ci(so interactive AzDO auth fallback can be enabled) and depends ondnxbeing available on the agent. For CI reliability, pass--ciand run the tool viadotnet tool install(similar toeng/pipelines/insert.yml) so the pipeline is self-contained and won’t hang if tokens are invalid/expired.
$arguments = @(
"Microsoft.RoslynTools"
"--prerelease"
"--add-source", "https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-eng/nuget/v3/index.json"
"--"
- Files reviewed: 2/2 changed files
- Comments generated: 0 new
- Review effort level: Lite
JoeRobich
commented
Aug 19, 2026
dibarbet
approved these changes
Aug 19, 2026
Contributor
There was a problem hiding this comment.
Review details
Suppressed comments (1)
Previously missed (1) — in code that hasn't changed since the last review.
eng/pipelines/insertion-pr-tagger.yml:76
- The script invokes
dnxto runMicrosoft.RoslynTools, but this pipeline never installs/bootstrapsdnx. That makes the job depend on whatever happens to be preinstalled on the agent image/1ES template and can break when images change. Consider invoking the tool viadotnet tool install(as documented for Microsoft.RoslynTools) and run the installedroslyn-toolsshim directly.
"--dnceng-azdo-token", $azdoToken
"--ci"
)
& dnx @arguments
- Files reviewed: 2/2 changed files
- Comments generated: 0 new
- Review effort level: Lite
This was referenced Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the last of the roslyn-tools code that was still active. We can move our pipeline over to this yml once merged and archive dotnet/roslyn-tools repo.
Microsoft Reviewers: Open in CodeFlow