Repository navigation
Switch rebuild to .NET Core - #84977
Merged
Merged
Conversation
|
Azure Pipelines: Successfully started running 2 pipeline(s). There may be pipelines that require an authorized user to comment /azp run to run. |
Open
3 tasks
jjonescz
changed the title
jjonescz
marked this pull request as ready for review
August 21, 2026 13:50
|
Azure Pipelines: Successfully started running 2 pipeline(s). There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
Pull request overview
Switches rebuild validation to .NET Core while preserving deterministic embedded-source blobs across runtime-specific compression differences.
Changes:
- Runs BuildValidator and bootstrap compilation on .NET Core.
- Reuses original embedded-source blobs during rebuild.
- Tests compressed
StringTextandLargeTextround trips.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
CSharpRebuildTests.cs |
Adds compression round-trip coverage. |
CompilationOptionsReader.cs |
Preserves original embedded-source blobs. |
SourceText.cs |
Accepts precomputed embedded blobs. |
LargeText.cs |
Propagates precomputed blobs for large sources. |
test-rebuild.ps1 |
Runs rebuild validation with .NET Core. |
jaredpar
approved these changes
Aug 21, 2026
333fred
approved these changes
Aug 21, 2026
| " --referencesPath `"$ArtifactsDir/bin`"" + | ||
| " --referencesPath `"$dotnetInstallDir/packs`"") | ||
| Exec-Command "$ArtifactsDir/bin/BuildValidator/$configuration/net472/BuildValidator.exe" $rebuildArgs | ||
| Exec-Command "$ArtifactsDir/bin/BuildValidator/$configuration/net10.0/BuildValidator.exe" $rebuildArgs |
Member
There was a problem hiding this comment.
It's possible this means we can drop the multi-targeting on BuildValidator itself. I couldn't entirely tell if the tool was running net472 and we added the net10 just for the nullable annotations.
Member
Author
There was a problem hiding this comment.
I can look into that in a follow up.
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Includes a fix for this issue: on .NET Core, embedded texts don't roundtrip because their compression doesn't roundtrip (but it does on .NET Framework, hence this worked before).
Microsoft Reviewers: Open in CodeFlow