Repository navigation
Prefer repository terminology in generated output - #85878
Merged
mwiemer-microsoft merged 4 commits intoOct 1, 2026
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This comment has been minimized.
This comment has been minimized.
mwiemer-microsoft
changed the title
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
mwiemer-microsoft
changed the title
mwiemer-microsoft
changed the title
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
mwiemer-microsoft
marked this pull request as ready for review
October 1, 2026 20:41
mwiemer-microsoft
enabled auto-merge (squash)
October 1, 2026 20:41
akhera99
approved these changes
Oct 1, 2026
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The instruction does not reliably prevent the ambiguity described by the PR.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Adds repository-specific terminology guidance for AI-generated output.
Changes:
- Adds a repo-wide terminology preference.
- One discrepancy identified: wording still permits “worker” and “router.”
| File | Description |
|---|---|
.github/copilot-instructions.md |
Adds terminology guidance. |
|
|
||
| > This is the **canonical** repo-wide agent entry point. `AGENTS.md` at the repo root points here. Path-scoped rules in `.github/instructions/{Compiler,IDE,Razor}.instructions.md` apply automatically by area and supplement this file. This file establishes the memory-first orientation protocol and doc-maintenance obligation. | ||
| > | ||
| > Across AI-generated output (code, documentation, and user-facing prose), prefer terminology already used in this repository. |
Member
There was a problem hiding this comment.
the Language Server telemetry router
This was the motivating example to get rid of it. 😄
333fred
added a commit
that referenced
this pull request
Oct 2, 2026
# By Sam Harwell (331) and others # Via GitHub (414) and others * upstream/main: (1352 commits) Document known issue workarounds inline (#85896) Restore automatic HTML test results for local runs (#85892) Report actual errors when strong-name HRESULT assertions fail (#85894) Restore main insertions after the VS 18.12 snap (#85824) Add "edit criteria" for AI doc updates (#85893) Handle cref type parameters in symbol lookup (#85840) Fix build warnings (#85754) Improve our Copilot instructions for testing [main] Update dependencies from dotnet/arcade (#85885) Rewrite 'router' phrasing Address review feedback Add option to disable cref paste fix Prefer repository terminology in generated output (#85878) Use cref for workspace extension handler Remove unnecessary static diagnostic registration Unsafe evolution: use safety documentation for unnecessary unsafe (#85842) Add Razor compiler team to code owners Unsafe evolution: avoid constructor recursion (#85773) Add roslyn-ide to Razor code owners Fix unexpected System.ArrayTypeMismatchException for captured method call receivers (#85811) ... Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: fd482dbd-c828-466b-87c6-6b2103be2089 # Conflicts: # src/Compilers/CSharp/Portable/Errors/ErrorCode.cs # src/Compilers/CSharp/Portable/Errors/MessageID.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AI is currently using ambiguous terms like "worker" and "router" instead of repo-specific terms. Hopefully this helps :)