Repository navigation
JIT: Consider making handles their own node type #104636
Description
The JIT has had a number of bugs related to the fact that handles are special and cannot participate in various opts, even though we represent them as GT_CNS_INT. #104634 is one latest example.
I think we should consider introducing a dedicated node type for the (opaque) handles to make these bugs less likely to be introduced.
cc @dotnet/jit-contrib
Activity
dotnet-policy-service commentedon Jul 9, 2024
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.
SingleAccretion commentedon Jul 9, 2024
Consideration: under Jit (
!opts.compReloc) it is ok to dissolve handles (they have their final values). It is only under AOT that handles are special.jakobbotsch commentedon Jul 9, 2024
@SingleAccretion Yeah, that's what I was alluding to by the "(opaque)". Though it would be nice to remove the handle flags from
GT_CNS_INTas well, but we use those for a few things (mostly to annotate disassembly, I think), so we probably wouldn't be able to do that if we left the runtime JIT handles asGT_CNS_INT.