Repository navigation
[Perf] Windows/x64: 1 Regression on 8/17/2024 12:12:18 AM #106708
Description
Run Information
| Name | Value |
|---|---|
| Architecture | x64 |
| OS | Windows 10.0.22631 |
| Queue | ViperWindows |
| Baseline | dab77acadb13387360ad87e2eb107d38fb2b751f |
| Compare | bb1b43a6a155eaeb45953a3c87f6e04b12979778 |
| Diff | Diff |
| Configs | CompilationMode:tiered, RunKind:micro |
Regressions in System.Reflection.Attributes
| Benchmark | Baseline | Test | Test/Base | Test Quality | Edge Detector | Baseline IR | Compare IR | IR Ratio |
|---|---|---|---|---|---|---|---|---|
| 66.04 ns | 104.80 ns | 1.59 | 0.20 | False |
Repro
General Docs link: https://github.com/dotnet/performance/blob/main/docs/benchmarking-workflow-dotnet-runtime.md
git clone https://github.com/dotnet/performance.git
py .\performance\scripts\benchmarks_ci.py -f net8.0 --filter 'System.Reflection.Attributes*'Details
System.Reflection.Attributes.IsDefinedClassMiss
ETL Files
Histogram
JIT Disasms
Docs
Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository
Activity
AaronRobinsonMSFT commentedon Aug 20, 2024
@DrewScoggins How was this determined I regressed the change? The Compare commit isn't from me.
DrewScoggins commentedon Aug 27, 2024
The compare commit is just the last commit that was used for the comparison. You need to look at the diff link, or find the diff manually using any of the test report html pages. Using the latter method this is the range of commits where the regression seemed to take place, 1a305e6...0d8e565.
That is why you were tagged as your change seemed the most likely. Hope this helps!
AaronRobinsonMSFT commentedon Aug 27, 2024
@DrewScoggins Yep. I found the issue and closed this with a fix in #106730.