Repository navigation
JIT: Assertion failed '!compIsForInlining()' during 'Morph - Inlining' in jit64_2 tests #112363
Description
Build Information
Build: https://dev.azure.com/dnceng-public/public/_build/results?buildId=945874&view=results
Build error leg or test failing:
Error Message
Fill the error message using step by step known issues guidance.
{
"ErrorMessage": "Assertion failed '!compIsForInlining()'",
"BuildRetry": false,
"ExcludeConsoleLog": false
}Configuration:
set DOTNET_TieredCompilation=0
set DOTNET_JitStress=1a7
Example log. cc @dotnet/jit-contrib
Known issue validation
Build: 🔎 https://dev.azure.com/dnceng-public/public/_build/results?buildId=945874
Error message validated: [Assertion failed '!compIsForInlining()']
Result validation: ✅ Known issue matched with the provided build.
Validation performed at: 2/10/2025 7:39:24 PM UTC
Report
| Build | Definition | Test | Pull Request |
|---|---|---|---|
| 945874 | dotnet/runtime | jit64_2.WorkItemExecution |
Summary
| 24-Hour Hit Count | 7-Day Hit Count | 1-Month Count |
|---|---|---|
| 0 | 1 | 1 |
Activity
dotnet-policy-service commentedon Feb 10, 2025
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.
EgorBo commentedon Feb 10, 2025
Looks like the assert complains that a function with varargs was attempted to be inlined
EgorBo commentedon Feb 10, 2025
Curious if it could be inliner-related changes in #111782 or #111948
JulieLeeMSFT commentedon Feb 10, 2025
CC @hez2010 if he can take a quick look at it and guess what might have caused this failure.
hez2010 commentedon Feb 11, 2025
It seems to be unrelated to my change.
The assertion here is to assert any callee of a method that being inlined cannot be
vararg, which seems to be incorrect.Here we are inlining:
which makes perfect sense, but then in the body of
MCCTest.MyClass:Mainwe have awhich is vararg, so the assertion triggers while importing
MCCTest.MyClass:Sumduring inliningMCCTest.MyClass:Main.I don't think we have any way to detect whether a method call inside an inlinee is vararg or not before actually import it, so this check seems wrong to me. Maybe we should simply remove this check and instead block inlining vararg calls.
hez2010 commentedon Feb 11, 2025
Here is the test binary: jit64_2.zip
To repro, set environment vairables
and run
jit64_2.dllwith corerun.EgorBo commentedon Feb 11, 2025
@hez2010 was it just exposed by your changes (.e.g. we know inline what we did not) ?
hez2010 commentedon Feb 11, 2025
Yeah, it seems to be a new valid inlinee that we didn't inline before. The actual issue should already exist in the JIT before my change.
AndyAyersMS commentedon Feb 12, 2025
I have a Jan 22 build lying around that also fails this way. Could just be random inline stress working its magic.
JIT: remove asserts about inlining methods that call varargs methods
JIT: remove asserts about inlining methods that call varargs methods (d…