Bounds check after overlapping span length checks

https://godbolt.org/z/3arPqT9oP

public static bool Foo(ReadOnlySpan<char> span)
{
    for (int i = 0; i < span.Length; i++)
    {
        if (span[i] == '%' && (uint)(i + 2) < (uint)span.Length)
        {
            if (span[i + 1] == 'F' && // Bounds check
                span[i + 2] == 'F')
            {
                return true;
            }
        }
    }
    
    return false;
}

(uint)i < (uint)span.Length && (uint)(i + 2) < (uint)span.Length implies that i + 1 is also in range.

E.g.

runtime/src/libraries/System.Private.Uri/src/System/Uri.cs

Lines 3682 to 3686 in 0ad494b

    
           if ((uint)(i + 2) >= (uint)uriString.Length || 
        
               colonOffset == 0 || 
        
               // Redundant checks to eliminate range checks below 
        
               (uint)i >= (uint)uriString.Length || 
        
               (uint)(i + 1) >= (uint)uriString.Length)

or
https://github.com/MihaZupan/runtime/blob/299818ab507ff37b0ef74918fdc35463b7e2d5e1/src/libraries/System.Private.Uri/src/System/UriHelper.cs#L321-L325 from #121261

@JulieLeeMSFT

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

This issue is being tracked in #109677. Marking this as future for now.

Remove bounds checks for 'i + cns < len' pattern (#124242)

Remove bounds checks for 'i + cns < len' pattern (dotnet#124242)

Navigation Menu

Repository navigation

Bounds check after overlapping span length checks #121262

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	if ((uint)(i + 2) >= (uint)uriString.Length \|\|
	colonOffset == 0 \|\|
	// Redundant checks to eliminate range checks below
	(uint)i >= (uint)uriString.Length \|\|
	(uint)(i + 1) >= (uint)uriString.Length)

Bounds check after overlapping span length checks #121262

Description

Activity

dotnet-policy-service commented on Nov 1, 2025

JulieLeeMSFT commented on Dec 11, 2025

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions