Improve custom attribute decoding tests #16552

Activity

1. nguerrera

   self-assigned this

   on Mar 1, 2016
2. nguerrera

   changed the title [-]Assert correctness of all custom attribute decoding tests[/-] [+]Improve custom attribute decoding tests[/+] on Mar 1, 2016
3. karelz

   unassigned

   nguerrera

   on Nov 11, 2016
4. YongseopKim commented on Sep 13, 2017

   

   YongseopKim

   on Sep 13, 2017

   Last edited by YongseopKim

   Contributor

   More actions

   Anyone has worked for this issue? I'm facing the wrong tc in System.Reflection.Metadata.Tests. (https://github.com/dotnet/corefx/issues/23937).
   In short, the tc System.Reflection.Metadata.Decoding.Tests.CustomAttributeDecoderTests.TestCustomAttributeDecoder supposes that the first elem of reader.GetCustomAttributes(typeDefHandle) is [Test] which has no arguments. Contents of CustomAttributes are same to each other but orders of CustomAttributes are different. Therefore, I think the tc should be fixed to care unsorted CustomAttributes.

   This question has related the problem.
5. msftgits

   transferred this issue fromdotnet/corefxon Jan 31, 2020
6. msftgits

   added this to the Future milestone on Jan 31, 2020
7. maryamariyan

   added

   untriagedNew issue has not been triaged by the area ownerNew issue has not been triaged by the area owner

   on Feb 23, 2020
8. ericstj

   removed

   untriagedNew issue has not been triaged by the area ownerNew issue has not been triaged by the area owner

   on Jun 29, 2020
9. joperezr

   added this to Triage POD for Reflection, META, etc. and removed this from Triage POD for Reflection, META, etc.on Nov 2, 2021
10. joperezr

    moved this to Future in Triage POD for Reflection, META, etc.on Nov 2, 2021
11. joperezr

    added this to Triage POD for Reflection, META, etc.on Nov 2, 2021
12. buyaa-n commented on Aug 3, 2022

    

    buyaa-n

    on Aug 3, 2022

    Contributor

    More actions

    Updated tests with #72561. There is some inconsistency when Enum type used for constructor argument or named parameter. Most likely related to:

    runtime/src/libraries/System.Reflection.Metadata/tests/Metadata/Decoding/CustomAttributeDecoderTests.cs

    Line 357 in bb3be81

    Type runtimeType = Type.GetType(type.Replace('/', '+')); // '/' vs '+' is only difference between ilasm and reflection notation for fixed set below.

    
    Because sometimes it produces System.Reflection.Metadata.Decoding.Tests.CustomAttributeDecoderTests+SByteEnum or sometimes System.Reflection.Metadata.Decoding.Tests.CustomAttributeDecoderTests/SByteEnum

    Leaving this issue open to investigate that, some of the test attributes that causing this issue are commented out with reference to this issue.