Repository navigation
EventArgs type not Serializable #24461
Description
MSBuild uses EventArgs base class to derive all build events and messages (see BuildEventArgs).
As part of our effort to migrate to netstandard2.0, we need this type to be marked Serializable in order to maintain compatibility between full framework and Core versions. Ideally this needs to be included in 2.0 servicing in the VS15.6 timeframe.
@danmosemsft
Activity
karelz commentedon Dec 15, 2017
cc @ViktorHofer
danmoseley commentedon Dec 15, 2017
We should just do this. It's an empty base type. They are not asking for any derived types.
ViktorHofer commentedon Dec 15, 2017
PRs are open for coreclr (src), corefx (tests) and docs. This issue should be closed after the PR into the servicing branch is merged.
jkotas commentedon Dec 15, 2017
@AndyGerlicher Where is msbuild going to use binary serialization for this in .NET Core?
AndyGerlicher commentedon Dec 15, 2017
We use binary serialization for many things, in particular cache files and IPC for multi-proc builds. The type I linked (BuildEventArgs) is the base class for all our build messages/events which derives from BuildEvent (and is not ISerializable). And customers can (and do) create custom types that derive from our build event types.
danmoseley commentedon Jun 28, 2018
We allow serialization of EventArgs itself. No further changes planned.