Repository navigation
xunit warnings: Non-serializable data #30324
Description
We are currently hiding thousands of warnings that indicate that our test data is not serializable. See aspnet/SignalR#1649 for more details.
Switching from xunit.console to dotnet test/vstest displays those warnings by default. I think we should at least investigate if the warnings are valid and consider fixing them.
Test branch with dotnet vstest for local validation: https://github.com/ViktorHofer/corefx/tree/DotNetTest
Related: dotnet/arcade#3333
Attaching the xunit log from System.Text.RegularExpressions.Tests: xunit-warnings.txt
cc @danmosemsft @safern
Activity
ViktorHofer commentedon Jul 21, 2019
XUnit unfortunately doesn't support theory member data serialization which means you need to implement
IXunitSerializableto make that work: xunit/xunit#429 (comment)This is really unfortunate and I'm surprised that there isn't a solution for that yet. Maybe just switching off the diagnostics warnings (if possible) is easier... The downside, you won't be able to debug individual test cases in VS Test Explorer.
ViktorHofer commentedon Jul 21, 2019
Submitted dotnet/arcade#3334
ViktorHofer commentedon Jul 21, 2019
What aspnet did was to just ignore those warnings... I'm not exactly sure how we should proceed here. This is a feature omission in xunit and should be fixed there but I don't think this will happen anytime soon. When switching to dotnet vstest those warnings will shop up and can only be turned off by also turning-off diagnostic messages which are needed for diagnosing long-running tests.
cc @stephentoub for opinions
stephentoub commentedon Jul 21, 2019
We use a bunch of types in theories that will never be serializable. I don't see xunit being able to address that fully, nor should we bend over backwards to make theory data serializable in order to have individual inputs show up in VS Test explorer; it's simply not worth it.
We can't suppress individual warning types? That's the feature I'd want from xunit if it doesn't already exist, ala being able to suppress C# compiler warning X but not Y.
ViktorHofer commentedon Jul 22, 2019
Unfortunately not. Currently it's either all diagnostics or none. I'm not sure if contributions are accepted at the moment given the staleness of the repo. The last official release was 9+ months ago.
stephentoub commentedon Jul 22, 2019
@bradwilson, would xunit welcome a PR to address this in some way?
bradwilson commentedon Jul 23, 2019
Yes, with a couple obvious caveats:
dotnet-policy-service commentedon Dec 26, 2024
Due to lack of recent activity, this issue has been marked as a candidate for backlog cleanup. It will be closed if no further activity occurs within 14 more days. Any new comment (by anyone, not necessarily the author) will undo this process.
This process is part of our issue cleanup automation.
dotnet-policy-service commentedon Jan 9, 2025
This issue will now be closed since it had been marked
no-recent-activitybut received no further activity in the past 14 days. It is still possible to reopen or comment on the issue, but please note that the issue will be locked if it remains inactive for another 30 days.