Skip to content

Microsoft.Extensions.Http test failure on mono #34023

Closed
Closed
Microsoft.Extensions.Http test failure on mono#34023
Labels
area-Extensions-HttpClientFactoryblocking-clean-ciBlocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms'runtime-monospecific to the Mono runtime
Milestone
6.0.0

Description

@maryamariyan
maryamariyan
opened on Mar 24, 2020

This issue tracks Http test failing on Mono:

Microsoft.Extensions.Http.DefaultHttpClientFactoryTest.Factory_CleanupCycle_DisposesLiveHandler

https://helix.dot.net/api/2019-06-17/jobs/c6ed46b1-0512-4f5d-b721-ecaaaa01dc59/workitems/Microsoft.Extensions.Http.Tests/console

Discovering: Microsoft.Extensions.Http.Tests (method display = ClassAndMethod, method display options = None)
  Discovered:  Microsoft.Extensions.Http.Tests (found 70 test cases)
  Starting:    Microsoft.Extensions.Http.Tests (parallel test collections = on, max threads = 2)
    Microsoft.Extensions.Http.DefaultHttpClientFactoryTest.Factory_CleanupCycle_DisposesLiveHandler [FAIL]
      Cleanup entry disposable
      Expected: True
      Actual:   False
      Stack Trace:
        /_/src/libraries/Microsoft.Extensions.Http/tests/DefaultHttpClientFactoryTest.cs(449,0): at Microsoft.Extensions.Http.DefaultHttpClientFactoryTest.Factory_CleanupCycle_DisposesLiveHandler()
        --- End of stack trace from previous location ---
  Finished:    Microsoft.Extensions.Http.Tests

Activity

  1. maryamariyan
    added
    area-Microsoft.Extensions
    on Mar 24, 2020
  2. Dotnet-GitSync-Bot
    added
    untriagedNew issue has not been triaged by the area owner
    on Mar 24, 2020

  3. safern commented on Mar 24, 2020

    @safern
    safern
    on Mar 24, 2020
    Member

    Added console output to description since the file links might expire.

  4. danmoseley
    added
    runtime-monospecific to the Mono runtime
    on Mar 25, 2020

  5. danmoseley commented on Mar 25, 2020

    @danmoseley
    danmoseley
    on Mar 25, 2020
    Contributor

    @maryamariyan there is a label runtime-mono that is handy for mono specific issues

  6. maryamariyan
    added
    area-Extensions-HttpClientFactory
    and removed
    area-Microsoft.Extensions
    on Apr 2, 2020

  7. danmoseley commented on Apr 10, 2020

    @danmoseley
    danmoseley
    on Apr 10, 2020
    Contributor

    Likely relates to different GC behavior on Mono. Test says "depends on the GC and timing."

  8. maryamariyan
    removed
    untriagedNew issue has not been triaged by the area owner
    on Jun 18, 2020
  9. maryamariyan
    added this to the Future milestone on Jun 18, 2020

  10. jkotas commented on Jul 22, 2020

    @jkotas
    jkotas
    on Jul 22, 2020
    Member

    Failed in #39717

  11. jkotas
    added
    blocking-clean-ciBlocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms'
    on Jul 22, 2020

  12. danmoseley commented on Jul 22, 2020

    @danmoseley
    danmoseley
    on Jul 22, 2020
    Contributor

    @maryamariyan please fix or disable

  13. akoeplinger commented on Jul 22, 2020

    @akoeplinger
    akoeplinger
    on Jul 22, 2020
    Member

    @maryamariyan I think this is the result of different GC on Mono, we disabled some similar tests with the PlatformDetection.IsPreciseGcSupported which returns false on Mono. The same should be done with this test.

  14. directhex commented on Sep 30, 2020

    @directhex
    directhex
    on Sep 30, 2020
    Contributor

    Closing the issue, since the test in question is now annotated with IsPreciseGcSupported. If Mono ever supports that, we can revisit related issues.

  15. directhex
    closed this as completedon Sep 30, 2020
  16. ghost locked as resolved and limited conversation to collaborators on Dec 10, 2020
  17. karelz
    modified the milestones: Future, 5.0.x, 6.0.0 on May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area-Extensions-HttpClientFactoryblocking-clean-ciBlocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms'runtime-monospecific to the Mono runtime

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions