Skip to content

ARM64: Optimize pair of "str reg, [reg]" to stp #35133

Closed
#84135
Closed
ARM64: Optimize pair of "str reg, [reg]" to stp#35133
#84135
Labels
arch-arm64area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Milestone
Future

Description

@kunalspathak
kunalspathak
opened on Apr 17, 2020
str     x13, [x12]
str     x14, [x12,#8]

can be combined into stp if the stores are happening in subsequent memory.

stp x13, x14, [x12]

I collected no. of such str pairs in framework libraries and found approx. 1000 pairs in 400 methods.

Details:

str_str_x_to_stp.txt

category:cq
theme:optimization
skill-level:intermediate
cost:small
impact:medium

Activity

  1. Dotnet-GitSync-Bot
    added
    area-Meta
    untriagedNew issue has not been triaged by the area owner
    on Apr 17, 2020
  2. kunalspathak
    added
    arch-arm64
    area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
    and removed
    area-Meta
    on Apr 17, 2020
  3. BruceForstall
    added this to the Future milestone on Apr 20, 2020
  4. BruceForstall
    removed
    untriagedNew issue has not been triaged by the area owner
    on Apr 20, 2020
  5. BruceForstall
    added
    JitUntriagedCLR JIT issues needing additional triage
    on Oct 28, 2020
  6. kunalspathak
    modified the milestones: Future, 6.0.0 on Nov 9, 2020
  7. kunalspathak
    removed
    JitUntriagedCLR JIT issues needing additional triage
    on Nov 9, 2020
  8. JulieLeeMSFT
    modified the milestones: 6.0.0, Future on Mar 23, 2021
  9. BruceForstall
    added a commit that references this issue on Jan 12, 2023

    Replace successive "ldr" and "str" instructions with "ldp" and "stp"

    261c710
  10. kunalspathak
    added a commit that references this issue on Jan 27, 2023

    Replace successive "ldr" and "str" instructions with "ldp" and "stp" (#…

    acc409e
  11. ghost added
    in-prThere is an active PR which will close this issue when it is merged
    on Mar 30, 2023
  12. kunalspathak
    closed this as completedin #84135on Mar 31, 2023
  13. ghost removed
    in-prThere is an active PR which will close this issue when it is merged
    on Mar 31, 2023
  14. kunalspathak
    reopened this on Apr 6, 2023

  15. kunalspathak commented on Apr 27, 2023

    @kunalspathak
    kunalspathak
    on Apr 27, 2023
    ContributorAuthor

    Fixed in #85032

  16. kunalspathak
    closed this as completedon Apr 27, 2023
  17. ghost locked as resolved and limited conversation to collaborators on May 27, 2023
  18. JulieLeeMSFT
    added this to .NET Core CodeGenon Jun 5, 2024
  19. JulieLeeMSFT
    moved this to Done in .NET Core CodeGenon Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    arch-arm64area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

    Type

    No type

    Projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions