Skip to content

[Perf -14%] System.Reflection.Attributes.GetCustomAttributesClassHit (2) #44816

Closed
Closed
[Perf -14%] System.Reflection.Attributes.GetCustomAttributesClassHit (2)#44816
Labels
arch-x64area-System.Reflectionos-linuxLinux OS (any supported distro)tenet-performancePerformance related issuetenet-performance-benchmarksIssue from performance benchmark
Milestone
8.0.0

Description

@DrewScoggins
DrewScoggins
opened on Nov 17, 2020

Run Information

Architecture x64
OS ubuntu 18.04
Baseline fcce1608222d542eea0b419bcee3c62775c1c418
Compare 52d405e92db4eaaf7f3c52ac615d9cd4f5341315
Diff Diff

Regressions in System.Reflection.Attributes

Benchmark Baseline Test Test/Base Baseline IR Compare IR IR Ratio Baseline ETL Compare ETL
GetCustomAttributesMethodBaseHit 945.36 ns 1.15 μs 1.21
GetCustomAttributesClassHit 922.46 ns 1.12 μs 1.21

Related Issue on x64 Windows

[Perf -9%] System.Reflection.Attributes.GetCustomAttributesMethodBaseHitInherit

Related Issue on x86 Windows

[Perf -8%] System.Reflection.Attributes.IsDefinedMethodBaseMiss

graph
graph
Historical Data in Reporting System

Repro

git clone https://github.com/dotnet/performance.git
python3 .\performance\scripts\benchmarks_ci.py -f netcoreapp5.0 --filter 'System.Reflection.Attributes*'
Details

Histogram

System.Reflection.Attributes.GetCustomAttributesMethodBaseHit

[ 922.398 ;  956.872) | @@@@@@@@@@@@@@@@@@@@@@@@@@
[ 956.872 ;  976.632) | @@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@
[ 976.632 ; 1000.064) | @@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@
[1000.064 ; 1040.480) | @@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@
[1040.480 ; 1081.836) | @@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@
[1081.836 ; 1120.491) | @@@@@@@@@@@@@@
[1120.491 ; 1161.110) | @@@@@@@@@@@@@@@@@
[1161.110 ; 1188.058) | @@
[1188.058 ; 1225.138) | @@@@@@
[1225.138 ; 1269.293) | @
[1269.293 ; 1327.442) | @

System.Reflection.Attributes.GetCustomAttributesClassHit

[ 911.653 ;  934.782) | @@@@@@@@@@@
[ 934.782 ;  957.356) | @@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@
[ 957.356 ;  978.971) | @@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@
[ 978.971 ; 1001.011) | @@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@
[1001.011 ; 1023.298) | @@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@
[1023.298 ; 1058.032) | @@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@
[1058.032 ; 1084.649) | @@@@@@@@@@@@@@@
[1084.649 ; 1109.994) | @@@@@@@@@@@@
[1109.994 ; 1139.926) | @@@@@@@@
[1139.926 ; 1181.718) | @@@@@@
[1181.718 ; 1211.032) | @@
[1211.032 ; 1251.199) | @
[1251.199 ; 1296.092) | @
[1296.092 ; 1356.578) | @@@

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

Activity

  1. DrewScoggins
    added
    os-linuxLinux OS (any supported distro)
    tenet-performancePerformance related issue
    tenet-performance-benchmarksIssue from performance benchmark
    arch-x64
    on Nov 17, 2020
  2. Dotnet-GitSync-Bot
    added
    area-System.Reflection
    untriagedNew issue has not been triaged by the area owner
    on Nov 17, 2020

  3. steveharter commented on Nov 24, 2020

    @steveharter
    steveharter
    on Nov 24, 2020
    Contributor

    Not sure on source of regression although #45121 may help.

  4. steveharter
    removed
    untriagedNew issue has not been triaged by the area owner
    on Nov 24, 2020
  5. steveharter
    added this to the 6.0.0 milestone on Nov 24, 2020

  6. danmoseley commented on Nov 25, 2020

    @danmoseley
    danmoseley
    on Nov 25, 2020
    Contributor

    cc @benaadams

  7. danmoseley commented on Nov 25, 2020

    @danmoseley
    danmoseley
    on Nov 25, 2020
    Contributor

    It's a wierd regression, on both the scenarios it creeps up noisily during the Nov 13th. Hard to interpret such behavior, it's as if training data was rotting or something.

  8. krwq commented on Jul 22, 2021

    @krwq
    krwq
    on Jul 22, 2021
    Member

    [Triage] Is this tracking the same work as #44713 ? In the meantime we're moving this to 7.0 as it seems non-essential for 6.0

  9. krwq
    modified the milestones: 6.0.0, 7.0.0 on Jul 22, 2021
  10. joperezr
    added this to Triage POD for Reflection, META, etc. and removed this from Triage POD for Reflection, META, etc.on Nov 2, 2021
  11. joperezr
    moved this to Future in Triage POD for Reflection, META, etc.on Nov 2, 2021
  12. joperezr
    added this to Triage POD for Reflection, META, etc.on Nov 2, 2021
  13. buyaa-n
    modified the milestones: 7.0.0, 8.0.0 on Jul 11, 2022

  14. steveharter commented on Dec 5, 2022

    @steveharter
    steveharter
    on Dec 5, 2022
    Contributor

    Closing; old issue with no obvious root cause. There were various perf improvements made in V6 #53152 based off of #45121.

    [Triage] Is this tracking the same work as #44713 ? In the meantime we're moving this to 7.0 as it seems non-essential for 6.0

    No - that other issue was tracking "all attributes" while GetCustomAttributesClassHit was only selecting a single attribute.

  15. steveharter
    closed this as completedon Dec 5, 2022
  16. Repository owner moved this from Future to Done in Triage POD for Reflection, META, etc.on Dec 5, 2022
  17. ghost locked as resolved and limited conversation to collaborators on Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    arch-x64area-System.Reflectionos-linuxLinux OS (any supported distro)tenet-performancePerformance related issuetenet-performance-benchmarksIssue from performance benchmark

    Type

    No type

    Projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions