Skip to content

We can validate closure of our shared framework transport packages #52562

Description

@ericstj

Today we publish a shared framework package for ASP.NET and include an arbitrary set of files:

<File Include="$(ASPNETCoreAppPackageRefPath)\*.*;@(_libDocs)" TargetPath="ref\$(NetCoreAppCurrent)" />
<File Include="$(ASPNETCoreAppPackageRuntimePath)\*.*" Exclude="@(_libDocs)" TargetPath="lib\$(NetCoreAppCurrent)" />

Nothing guarantees that we aren't omitting dependencies here, and that isn't validated until the transport package reaches ASP.NET.

We do validate dependencies for our own shared framework:
https://github.com/dotnet/arcade/blob/44324e2d3563921f60b1522fccf3fef45dcfe636/src/Microsoft.DotNet.SharedFramework.Sdk/targets/sharedfx.targets#L437-L464

We could do this for the ASP.NET transport package as well, ensuring we pass the files that are part of the base shared framework as candidates. We could do the same for a WindowsDesktop transport package, should we produce one in the future.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions