Skip to content

Optimize DispatchProxyGenerator code path by using MetdataToken #53285

Closed
#55801
Closed
Optimize DispatchProxyGenerator code path by using MetdataToken#53285
#55801
Labels
area-System.ReflectionenhancementProduct code improvement that does NOT require public API changes/additionshelp wanted[up-for-grabs] Good issue for external contributorsneeds-further-triageIssue has been initially triaged, but needs deeper consideration or reconsideration
Milestone
Future

Description

@ViktorHofer
ViktorHofer
opened on May 26, 2021

See comment:

runtime/src/libraries/System.Reflection.DispatchProxy/src/System/Reflection/DispatchProxyGenerator.cs

Lines 834 to 836 in e8875e3

// This assembly should work in netstandard1.3,
// so we cannot use MemberInfo.MetadataToken here.
// Therefore, it compares honestly referring ECMA-335 I.8.6.1.6 Signature Matching.

With #53283, we won't build a netstandard1.x configuration of this library anymore and the code path can be optimized. FWIW this could have already be done in the past via ifdef compiler directives.

cc @buyaa-n @joperezr @krwq @steveharter @jeffhandley

Activity

  1. ViktorHofer
    added
    area-System.Reflection
    on May 26, 2021
  2. ghost added
    untriagedNew issue has not been triaged by the area owner
    on May 26, 2021
  3. buyaa-n
    added this to the 6.0.0 milestone on May 27, 2021
  4. buyaa-n
    removed
    untriagedNew issue has not been triaged by the area owner
    on May 27, 2021
  5. krwq
    added
    enhancementProduct code improvement that does NOT require public API changes/additions
    help wanted[up-for-grabs] Good issue for external contributors
    on Jul 15, 2021
  6. krwq
    modified the milestones: 6.0.0, Future on Jul 15, 2021

  7. FatTigerWang commented on Jul 16, 2021

    @FatTigerWang
    FatTigerWang
    on Jul 16, 2021
    Contributor

    @ViktorHofer I will use MethodInfo.MetadataTokenn and MethodInfo.Module.Name to judge

  8. ghost added
    needs-further-triageIssue has been initially triaged, but needs deeper consideration or reconsideration
    on Jul 16, 2021
  9. ghost added
    in-prThere is an active PR which will close this issue when it is merged
    on Jul 16, 2021
  10. jkotas
    closed this as completedin #55801on Jul 20, 2021
  11. ghost removed
    in-prThere is an active PR which will close this issue when it is merged
    on Jul 20, 2021
  12. ghost locked as resolved and limited conversation to collaborators on Aug 19, 2021
  13. joperezr
    added this to Triage POD for Reflection, META, etc.on Nov 2, 2021
  14. joperezr
    moved this to Done in Triage POD for Reflection, META, etc.on Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area-System.ReflectionenhancementProduct code improvement that does NOT require public API changes/additionshelp wanted[up-for-grabs] Good issue for external contributorsneeds-further-triageIssue has been initially triaged, but needs deeper consideration or reconsideration

    Type

    No type

    Projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions