Repository navigation
[wasm] STJ.Serialization.Tests.JsonIgnoreAttribute_UnsupportedCollection failing on main #71981
Description
System.Text.Json.Serialization.Tests.PropertyVisibilityTestsDynamic.JsonIgnoreAttribute_UnsupportedCollection [FAIL]
System.UriFormatException : Invalid URI: The hostname could not be parsed.
Stack Trace:
/_/src/libraries/System.Private.Uri/src/System/UriExt.cs(42,0): at System.Uri.CreateThis(String uri, Boolean dontEscape, UriKind uriKind, UriCreationOptions& creationOptions)
/_/src/libraries/System.Private.Uri/src/System/Uri.cs(369,0): at System.Uri..ctor(String uriString)
/_/src/libraries/System.Text.Json/tests/Common/PropertyVisibilityTests.cs(1193,0): at System.Text.Json.Serialization.Tests.PropertyVisibilityTests.JsonIgnoreAttribute_UnsupportedCollection()
--- End of stack trace from previous location ---
Finished: System.Text.Json.Tests
Activity
Disable another STJ failing test - dotnet#71981
[wasm] Disable `S.T.RegularExpressions FunctionalTests` tests failing…
krwq commentedon Jul 12, 2022
FYI disabled tests are no longer blocking CI so removing label
radical commentedon Jul 12, 2022
Oops, sorry, missed this one!
eiriktsarpalis commentedon Jul 12, 2022
@radical PTAL at this comment: https://github.com/dotnet/runtime/pull/71875/files#r919266335
Judging by the original code in this change, this appears to be a regression in System.Uri contructor validation.
radical commentedon Jul 12, 2022
@eiriktsarpalis Do you want me to revert this, or would you want to do it as part of the fixing the validation?
eiriktsarpalis commentedon Jul 12, 2022
I think simply reverting the accidental change would be good for now.