Generic attributes lack testing #73735

Activity

1. MichalStrehovsky

   added

   area-System.Reflection

   help wanted[up-for-grabs] Good issue for external contributors[up-for-grabs] Good issue for external contributors

   on Aug 10, 2022
2. ghost added

   untriagedNew issue has not been triaged by the area ownerNew issue has not been triaged by the area owner

   on Aug 10, 2022
4. buyaa-n commented on Aug 11, 2022

   

   buyaa-n

   on Aug 11, 2022

   Contributor

   More actions

   We have some tests, but might need to improve the coverage
5. buyaa-n

   added this to the Future milestone on Aug 11, 2022
6. ghost removed

   untriagedNew issue has not been triaged by the area ownerNew issue has not been triaged by the area owner

   on Aug 11, 2022
7. MichalStrehovsky commented on Aug 12, 2022

   

   MichalStrehovsky

   on Aug 12, 2022

   MemberAuthor

   More actions

   The specific tests that are needed are tests that are using the generic type's T in the signatures (that's the bug we ran into).

   So things like:

   class FooAttribute<T>: Attribute { public FooAttribute(T value, T[] othervalue) { } }
   class BarAttribute<T> : Attribute { public T SomeValue { get; set; } }

   The existing tests are not testing much because they don't use the T.

   👍React with 👍1Reacted by Buyaa Namnan
8. MichalStrehovsky commented on Aug 12, 2022

   

   MichalStrehovsky

   on Aug 12, 2022

   MemberAuthor

   More actions

   I would definitely at least put it in 8.0 but AFAIK generic attributes are new in C# for .NET 7.0 so we should have testing in place to make sure reflection on them actually works in various scenarios.

   Cc @333fred
9. buyaa-n commented on Aug 12, 2022

   

   buyaa-n

   on Aug 12, 2022

   Contributor

   More actions

   I would definitely at least put it in 8.0 but AFAIK generic attributes are new in C# for .NET 7.0 so we should have testing in place to make sure reflection on them actually works in various scenarios.

   Sure, we will reevaluate all issue during 8.0 planning
10. 333fred commented on Aug 12, 2022

    

    333fred

    on Aug 12, 2022

    Member

    More actions

    AFAIK generic attributes are new in C# for .NET 7.0

    That's correct.
11. steveharter

    modified the milestones: Future, 8.0.0 on Nov 7, 2022
12. steveharter commented on Jul 24, 2023

    

    steveharter

    on Jul 24, 2023

    Contributor

    More actions

    Moving to 9; the mono bug linked above unfortunately didn't add a test that would have helped here.
13. steveharter

    modified the milestones: 8.0.0, 9.0.0 on Jul 24, 2023
14. steveharter

    added

    test-enhancementImprovements of test source codeImprovements of test source code

    on Jul 24, 2024
15. steveharter

    modified the milestones: 9.0.0, 10.0.0 on Jul 24, 2024
16. koenigst

    added a commit that references this issue on Aug 21, 2024

    Added additional tests for generic attributes.

    ...

    This issue will close once commit c29b7e0 is merged into the 'main' branch.

    c29b7e0
17. dotnet-policy-service

    added

    in-prThere is an active PR which will close this issue when it is mergedThere is an active PR which will close this issue when it is merged

    on Aug 21, 2024
18. buyaa-n

    closed this as completedin #106745on Aug 29, 2024
19. buyaa-n

    closed this as completedin 92d0ed4on Aug 29, 2024
20. ivdiazsa

    added a commit that references this issue on Aug 29, 2024

    Added additional tests for generic attributes. (dotnet#106745)

    ...

    This issue will close once commit 92d0ed4 is merged into the 'main' branch.

    92d0ed4
21. jtschuster

    added a commit that references this issue on Sep 17, 2024

    Added additional tests for generic attributes. (dotnet#106745)

    ...

    This issue will close once commit 42b55e9 is merged into the 'main' branch.

    42b55e9
22. github-actions

    locked and limited conversation to collaborators on Oct 2, 2024
23. mikelle-rogers

    added a commit that references this issue on Dec 10, 2024

    Added additional tests for generic attributes. (dotnet#106745)

    ...

    This issue will close once commit 4f43414 is merged into the 'main' branch.

    4f43414