Repository navigation
Spmi-diff is showing diffs that are not related to the PR #74287
Description
Activity
@dotnet/jit-contrib
Interesting. The second diff looks like RBO. Maybe the baseline jit is not getting updated or something?
I did check the GUIDs and they look accurate. For example, #74090 the baseline is supposed to be
1b9551b8-21f4-4233-9c90-f3eabd6a322bwhich is the case as seen in https://helixre107v0xdeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-pull-74090-merge-f0df5552204b43709e/win-x64/1/console.56c5c11e.log?helixlogtype=result.Even the
superpmi-collectseems to be uploading to the right guid. This one is from last successful run.[21:50:55] Using JIT/EE Version from jiteeversionguid.h: 1b9551b8-21f4-4233-9c90-f3eabd6a322b [21:50:55] SuperPMI uploadSeems like those are GUIDs for
.mch. I don't see logging for baseline jit. May be we should add it.Locally (making changes on top of 9cd1a32) I don't see any spurious diffs.
By the way, from past few days, I am seeing this error on AzDo, not sure what it meant:
Locally (making changes on top of 9cd1a32) I don't see any spurious diffs.
And for that even superpmi diff is clean. https://dev.azure.com/dnceng/public/_build/results?buildId=1950687&view=ms.vss-build-web.run-extensions-tab
Look in the "setup" leg for the jit download from the cloud -- eg from https://dev.azure.com/dnceng/public/_build/results?buildId=1954972&view=logs&jobId=011e1ec8-6569-5e69-4f06-baf193d1351e&j=011e1ec8-6569-5e69-4f06-baf193d1351e&t=bf6cf4cf-6432-59cf-d384-6b3bcf32ede2
We should surface this warning more visibly
So evidently, we're missing some baseline jits.
Look in the "setup" leg for the jit download from the cloud -- eg from https://dev.azure.com/dnceng/public/_build/results?buildId=1954972&view=logs&jobId=011e1ec8-6569-5e69-4f06-baf193d1351e&j=011e1ec8-6569-5e69-4f06-baf193d1351e&t=bf6cf4cf-6432-59cf-d384-6b3bcf32ede2
We should surface this warning more visibly
Yep, I was trying to find where that is logged. Thanks for finding it.
I see that they are getting uploaded correctly in the rolling jit build job.
he baseline is supposed to be
1b9551b8-21f4-4233-9c90-f3eabd6a322bwhich is the case as seenI forgot that for baseline jit, we go with the git_hash.
If I look at the (internal) baseline JIT pipeline https://dev.azure.com/dnceng/internal/_build?definitionId=902, it hasn't built all the JIT changes merged to public 'main'.
We should surface this warning more visibly
It would help if we suppressed some of the download progress status messages.
@kunalspathak This has been understood and resolved, so I'm going to close it.
- ghost locked as resolved and limited conversation to collaborators
on Sep 23, 2022
I believe there is something wrong with spmi-diff pipeline. Even for PRs that shouldn't have code diffs is showing diffs.
I looked into the
spmi-difffor #74090 and the diffs looks unrelated. The following diff is coming from #74110, but is reported in #74090.Likewise, below diff is unrelated to #74090 as well as #74110.