HttpClient creates Quic threads even if HTTP/3 is not in use #74629

Activity

1. wfurt

   added

   tenet-compatibilityIncompatibility with previous versions or .NET FrameworkIncompatibility with previous versions or .NET Framework

   area-System.Net.Quic

   on Aug 26, 2022
3. ghost added

   untriagedNew issue has not been triaged by the area ownerNew issue has not been triaged by the area owner

   on Aug 26, 2022
4. rzikm commented on Aug 26, 2022

   

   rzikm

   on Aug 26, 2022

   Last edited by rzikm

   Member

   More actions

   I think we can simply try opening and closing the API registration (that should deallocate the internal MsQuic threadpool), and then lazily reopen it when we actually intend to use it.

   👍React with 👍2Reacted by Tomas Weinfurt and Natalia Kondratyeva
5. stephentoub

   added this to the 7.0.0 milestone on Aug 28, 2022
6. ghost removed

   untriagedNew issue has not been triaged by the area ownerNew issue has not been triaged by the area owner

   on Aug 28, 2022
7. stephentoub

   added

   area-System.Net.Http

   on Aug 28, 2022
9. stephentoub

   removed

   area-System.Net.Quic

   on Aug 28, 2022
10. rzikm

    self-assigned this

    on Aug 29, 2022
11. ghost added

    in-prThere is an active PR which will close this issue when it is mergedThere is an active PR which will close this issue when it is merged

    on Aug 29, 2022
12. karelz commented on Aug 30, 2022

    

    karelz

    on Aug 30, 2022

    Member

    More actions

    Triage: This contributes to 1MB per core Working set regression on Windows 2022/Win11+ and on Linux when msquic is present.
    We should fix it in 7.0.
13. karelz

    added

    tenet-performancePerformance related issuePerformance related issue

    and removed

    tenet-compatibilityIncompatibility with previous versions or .NET FrameworkIncompatibility with previous versions or .NET Framework

    on Aug 30, 2022
14. 35 remaining items

    Load more

15. karelz commented on Sep 13, 2022

    

    karelz

    on Sep 13, 2022

    Last edited by karelz

    Member

    More actions

    Open questions:

    • Is System.Net.Http.Functional - HTTP/3 timeouts (mostly on NativeAOT) #75493 regression caused by unloading msquic and will this change address it?
    • CR feedback - take another look if we can avoid touching msquic more - [release/7.0] Unload MsQuic after checking for QUIC support to free resources (#75163) #75330 (comment)
      • Will be discussed in team meeting with @stephentoub in presence
16. ghost removed

    in-prThere is an active PR which will close this issue when it is mergedThere is an active PR which will close this issue when it is merged

    on Sep 23, 2022
17. karelz commented on Sep 23, 2022

    

    karelz

    on Sep 23, 2022

    Last edited by karelz

    Member

    More actions

    Fixed in main (8.0) in PRs #75163 and #75441 and in 7.0 (GA) in PR #75521 and in 6.0.15 in PR #80785.
18. karelz

    closed this as completedon Sep 23, 2022
19. ghost locked as resolved and limited conversation to collaborators on Oct 23, 2022
20. jeffhandley

    removed

    Regression

    on Dec 28, 2022
21. karelz commented on Jan 20, 2023

    

    karelz

    on Jan 20, 2023

    Member

    More actions

    We have customers impacted on 6.0 as well - only via Kestrel. Reopening for 6.0.x backport.
22. karelz

    reopened this on Jan 20, 2023
23. karelz

    modified the milestones: 7.0.0, 6.0.x on Jan 20, 2023
24. karelz

    assigned

    ManickaP

    and unassigned

    rzikm

    on Jan 20, 2023
25. ManickaP commented on Feb 15, 2023

    

    ManickaP

    on Feb 15, 2023

    Last edited by ManickaP

    Member

    More actions

    Closing as #80785 is merged
26. ManickaP

    closed this as completedon Feb 15, 2023
27. karelz commented on Feb 21, 2023

    

    karelz

    on Feb 21, 2023

    Member

    More actions

    Fixed also in 6.0.15 in PR #80785 -- see #74629 (comment) for details.