Description
|
IncrementalValueProvider<(Compilation, ImmutableArray<ClassDeclarationSyntax>)> compilationAndClasses = |
|
context.CompilationProvider.Combine(classDeclarations.Collect()); |
I think having the Compilation in the generator pipeline will cause it to fully run on every change, so this is losing the benefits of being incremental.
cc @333fred
Reproduction Steps
Expected behavior
Generator pipeline shouldn't have a Compilation or ISymbols, etc.
Actual behavior
Regression?
No response
Known Workarounds
No response
Configuration
No response
Other information
No response
Description
runtime/src/libraries/Microsoft.Extensions.Logging.Abstractions/gen/LoggerMessageGenerator.Roslyn4.0.cs
Lines 34 to 35 in 985eedd
I think having the Compilation in the generator pipeline will cause it to fully run on every change, so this is losing the benefits of being incremental.
cc @333fred
Reproduction Steps
Expected behavior
Generator pipeline shouldn't have a
CompilationorISymbols, etc.Actual behavior
Regression?
No response
Known Workarounds
No response
Configuration
No response
Other information
No response