Repository navigation
Default IsDynamicCodeSupported feature switch to true for CoreCLR #80398
Copy link
Copy link
Closed
Labels
area-System.Reflection.Emitin-prThere is an active PR which will close this issue when it is mergedThere is an active PR which will close this issue when it is mergedsize-reductionIssues impacting final app size primary for size sensitive workloadsIssues impacting final app size primary for size sensitive workloads
Milestone
Description
Activity
- addedsize-reductionIssues impacting final app size primary for size sensitive workloadsIssues impacting final app size primary for size sensitive workloads
on Jan 9, 2023 - ghost addeduntriagedNew issue has not been triaged by the area ownerNew issue has not been triaged by the area owner
on Jan 9, 2023 - ghost removeduntriagedNew issue has not been triaged by the area ownerNew issue has not been triaged by the area owner
on Jan 11, 2023 @eerhardt is this still relevant for 8.0?
- addedneeds-author-actionAn issue or pull request that requires more info or actions from the author.An issue or pull request that requires more info or actions from the author.
on Jul 24, 2023 - ghost addedneeds-further-triageIssue has been initially triaged, but needs deeper consideration or reconsiderationIssue has been initially triaged, but needs deeper consideration or reconsideration
on Jul 24, 2023 - ghost removedneeds-author-actionAn issue or pull request that requires more info or actions from the author.An issue or pull request that requires more info or actions from the author.
on Jul 24, 2023 - removedneeds-further-triageIssue has been initially triaged, but needs deeper consideration or reconsiderationIssue has been initially triaged, but needs deeper consideration or reconsideration
on Aug 2, 2023 Moving to v9; assuming #96539 won't be done in v8.
- addedin-prThere is an active PR which will close this issue when it is mergedThere is an active PR which will close this issue when it is merged
on Jun 17, 2024 - added a commit that references this issue
on Jun 21, 2024 - added a commit that references this issue
on Jun 24, 2024 - locked and limited conversation to collaborators
on Jul 23, 2024
Metadata
Metadata
Assignees
Labels
area-System.Reflection.Emitin-prThere is an active PR which will close this issue when it is mergedThere is an active PR which will close this issue when it is mergedsize-reductionIssues impacting final app size primary for size sensitive workloadsIssues impacting final app size primary for size sensitive workloads
With #80246, we added a feature switch for
RuntimeFeature.IsDynamicCodeSupported. Previously when you published a trimmed CoreCLR app,RuntimeFeature.IsDynamicCodeSupportedwas hard-coded totrue, so any logic switching on that property was eligible to be trimmed. For example:runtime/src/libraries/System.Text.Json/src/System/Text/Json/Serialization/JsonSerializerOptions.cs
Lines 599 to 601 in b900a09
When you publish a CoreCLR trimmed app, the
ReflectionMemberAccessorclass could be trimmed. Now that we have a feature switch, the property is no longer a constant.We could enable this by setting
featuredefault=truein the ILLink.Substitutions.xml file, but that runs into the issue described in #96539.This issue is to track enabling this for trimmed CoreCLR applications. It is blocked by #96539.