generation of RID graph no longer works

I was trying add new RID (ubuntu 23.04). I added entry to runtimeGroups.props in Microsoft.NETCore.Platforms and run dotnet.sh pack /p:UpdateRuntimeFiles=true as usually.
But no updates were made to runtime.json and runtime.compatibility.json
Release/6.0 branch still works but I experienced same issue with release/7.0.

6.0 PR with changes that were successfully created with the generator: #82120
7.0 PR with changes that couldn't get created with the generator: #82123

With .NET 7, source-build for unknown distros manages to successfully update the graph and then use that graph in the build. The task for that (GenerateRuntimeJson) is similar to the one used here (UpdateRuntimeJson).

runtime/src/libraries/Microsoft.NETCore.Platforms/src/Microsoft.NETCore.Platforms.csproj

Lines 60 to 79 in 53bb518

    
             <Target Name="GenerateRuntimeJson" AfterTargets="Build" Condition="'$(AdditionalRuntimeIdentifiers)' != ''"> 
        
               <MakeDir Directories="$(IntermediateOutputPath)" /> 
        
               <GenerateRuntimeGraph RuntimeGroups="@(RuntimeGroupWithQualifiers)" 
        
                                     AdditionalRuntimeIdentifiers="$(AdditionalRuntimeIdentifiers)" 
        
                                     AdditionalRuntimeIdentifierParent="$(AdditionalRuntimeIdentifierParent)" 
        
                                     RuntimeJson="$(BaseOutputPath)runtime.json" 
        
                                     UpdateRuntimeFiles="True" /> 
        
             </Target> 
        
             <Target Name="UpdateRuntimeJson"> 
        
               <!-- Generates a Runtime graph using RuntimeGroups and diffs it with the graph described by runtime.json and runtime.compatibility.json 
        
                    Specifying UpdateRuntimeFiles=true skips the diff and updates those files. 
        
                    The graph can be visualized using the generated dmgl --> 
        
               <MakeDir Directories="$(OutputPath)" /> 
        
               <GenerateRuntimeGraph RuntimeGroups="@(RuntimeGroupWithQualifiers)" 
        
                                     RuntimeJson="runtime.json" 
        
                                     CompatibilityMap="runtime.compatibility.json" 
        
                                     RuntimeDirectedGraph="$(OutputPath)runtime.json.dgml" 
        
                                     UpdateRuntimeFiles="$(UpdateRuntimeFiles)" /> 
        
             </Target>

@wfurt

Here's yet another PR that successfully uses the infrastructure in main: #82185. @wfurt please give it another try.

What do you want me to try? Just run the pack command as documentation suggest?
https://github.com/dotnet/runtime/blob/main/src/libraries/Microsoft.NETCore.Platforms/readme.md

Use generated runtime.json when building shared framework packages. (#…

I was looking for any console indication of why it doesn't work anymore but disregard as I just found the culprit: #76068

@ViktorHofer

thanks for looking into it @ViktorHofer

See cd2f0ff#r100777231.

The change was also backported to 6.0 with some differences: #77510.

Navigation Menu

Repository navigation

generation of RID graph no longer works #82125

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	<Target Name="GenerateRuntimeJson" AfterTargets="Build" Condition="'$(AdditionalRuntimeIdentifiers)' != ''">
	<MakeDir Directories="$(IntermediateOutputPath)" />
	<GenerateRuntimeGraph RuntimeGroups="@(RuntimeGroupWithQualifiers)"
	AdditionalRuntimeIdentifiers="$(AdditionalRuntimeIdentifiers)"
	AdditionalRuntimeIdentifierParent="$(AdditionalRuntimeIdentifierParent)"
	RuntimeJson="$(BaseOutputPath)runtime.json"
	UpdateRuntimeFiles="True" />
	</Target>

	<Target Name="UpdateRuntimeJson">
	<!-- Generates a Runtime graph using RuntimeGroups and diffs it with the graph described by runtime.json and runtime.compatibility.json
	Specifying UpdateRuntimeFiles=true skips the diff and updates those files.
	The graph can be visualized using the generated dmgl -->
	<MakeDir Directories="$(OutputPath)" />
	<GenerateRuntimeGraph RuntimeGroups="@(RuntimeGroupWithQualifiers)"
	RuntimeJson="runtime.json"
	CompatibilityMap="runtime.compatibility.json"
	RuntimeDirectedGraph="$(OutputPath)runtime.json.dgml"
	UpdateRuntimeFiles="$(UpdateRuntimeFiles)" />
	</Target>

generation of RID graph no longer works #82125

Description

Activity

carlossanlop commented on Feb 14, 2023

tmds commented on Feb 15, 2023

ViktorHofer commented on Feb 15, 2023

wfurt commented on Feb 15, 2023

ViktorHofer commented on Feb 15, 2023

wfurt commented on Feb 15, 2023

tmds commented on Feb 15, 2023

tmds commented on Feb 15, 2023

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions