Skip to content

Follow up with removing INLINE_GETTHREAD_CONSTANT_POOL pattern, in the context of coreclr #85732

Closed
Closed
Follow up with removing INLINE_GETTHREAD_CONSTANT_POOL pattern, in the context of coreclr#85732
Assignees
VSadov
Labels
area-VM-coreclr
Milestone
Future

Description

@VSadov
VSadov
opened on May 3, 2023

Re: #85689 (comment)

The pattern is less common in coreclr that in NativeAOT, but it makes sense to do the same change as in #85689

Also may make sense to try the same for win-arm32. At least for consistency.

Also take a look at mangling like SETALIAS gCurrentThreadInfo, ?gCurrentThreadInfo@@3UThreadLocalInfo@@A. That may not be necessary.

Activity

  1. ghost added
    needs-area-labelAn area label is needed to ensure this gets routed to the appropriate area owners
    on May 3, 2023
  2. VSadov
    self-assigned this
    on May 3, 2023
  3. ghost added
    untriagedNew issue has not been triaged by the area owner
    on May 3, 2023
  4. VSadov
    added
    area-VM-coreclr
    and removed
    needs-area-labelAn area label is needed to ensure this gets routed to the appropriate area owners
    on May 3, 2023
  5. mangod9
    removed
    untriagedNew issue has not been triaged by the area owner
    on Jul 24, 2023
  6. mangod9
    added this to the Future milestone on Jul 24, 2023

  7. VSadov commented on Apr 18, 2024

    @VSadov
    VSadov
    on Apr 18, 2024
    MemberAuthor

    this was done in #99648

  8. VSadov
    closed this as completedon Apr 18, 2024
  9. github-actions
    locked and limited conversation to collaborators on May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

area-VM-coreclr

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions