Repository navigation
ServiceProviderEngineScope should aggregate exceptions in Dispose rather than throwing on the first. #86426
Description
Activity
I don't think we'll want framework components to swallow exceptions here. Is this an ask to try to capture an exception and rethrow as
AggregateExceptionwhen disposing all services in?Of is this an ask to make the Blazor CircuitHost to make the dispose exception more visible: https://github.com/dotnet/aspnetcore/blob/39564d529f84f7a3bbac5b28ba11060e8ac30375/src/Components/Server/src/Circuits/CircuitHost.cs#L199
Yes, it was about both aforementioned variants:
- We expected that the scope would try to dispose all disposable services and then throw an exception. But the scope just stop disposing.
It is important for us because we have some services which start timers and we need to stop them when the services are disposed. But they are not disposed because of broken service.
public class Service: IDisposable { private readonly ITimerService timerService; private ITimer timer; public TimeSpan UpdateInterval { get; set; } = TimeSpan.FromMinutes(2); public Task SetupAsync() { timer = timerService.Create(); timer.Interval = UpdateInterval; timer.Tick += TimerOnTick; timer.IsEnabled = true; return Task.CompletedTask; } private void TimerOnTick(object sender, EventArgs e) { } public void Dispose() { if (timer!=null) { timer.IsEnabled = false; timer.Tick -= TimerOnTick; timer = null; } } }We have modular app structure and some services can be written by other developers.
- Yes, we also expected that Blazor CircuitHost dispose exception would be more visible.
@swsyn can you open a separate issue in https://github.com/dotnet/aspnetcore with an ask for Blazor CircuitHost to stop hiding these exceptions?
Let this issue track a request to change the behavior of ServiceProviderEngineScope to not halt on the first Dispose exception, but to instead proceed and aggregate exceptions that might occur.
- changed the title
[-]Exception in Dispose() prevents disposing of all other services[/-][+]ServiceProviderEngineScope should aggregate exceptions in Dispose rather than throwing on the first.[/+]on May 24, 2023 Moving to 9.0; ServiceProviderEngineScope should try to run Dispose() on all services.
we had the same problem today - if one service throws an exception - all other services do not call Dispose any more!
- added a commit that references this issue
on Feb 2, 2026 - marked IServiceScope.Dispose() and DisposeAsync() should not stop disposing other services if one throws an exception #113563 as a duplicate of this issue
on Feb 27, 2026 - added a commit that references this issue
on Mar 2, 2026 - locked and limited conversation to collaborators
on Mar 28, 2026 Created a breaking change issue dotnet/docs#55654.
I understand that there is CA1065 rule
but
We run into errors during disposing some services in our Blazor Server App. We can wrap all our code in Dispose with try/catch but there can be third party services. It comes quite difficult to find the reason of some services were not disposed (also because Blazor's CircuitHost logs _disposeFailed with Debug level).
It seems difficult to assume that Dispose() will never throw an exception somewhere.