Skip to content

[Webassembly] dotnet/runtime update broke the aspnetcore build #88250

Closed

Description

@javiercn

There was a dotnet/runtime dependency update that broke the aspnetcore build (apparently, someone on our team merged on red) https://github.com/dotnet/aspnetcore/pull/49075/checks?check_run_id=14669346751

The issue seems to be related to localization/globalization with some languages.

Could you folks take a look asap?

/cc: @lewing @maraf @ilonatommy

Activity

  1. ghost added
    needs-area-labelAn area label is needed to ensure this gets routed to the appropriate area owners
    on Jun 30, 2023
  2. ghost added
    untriagedNew issue has not been triaged by the area owner
    on Jun 30, 2023
  3. ilonatommy commented on Jun 30, 2023

    @ilonatommy
    Member

    It might be this line:

    - const applicationCulture = resourceLoader.startOptions.applicationCulture || (navigator.languages && navigator.languages[0]);
    + const applicationCulture = resourceLoader.startOptions.applicationCulture || ENVIRONMENT_IS_WEB ? (navigator.languages && navigator.languages[0]) : Intl.DateTimeFormat().resolvedOptions().locale;
    

    because we apparently load en-US instead of cultures we would like to test. It means the applicationCulture is recognized incorrectly. The change to that line was done between the last successful update and the one that is failing, in #86255. I will try to test if this theory is correct.

  4. ghost added
    in-prThere is an active PR which will close this issue when it is merged
    on Jun 30, 2023
  5. removed
    needs-area-labelAn area label is needed to ensure this gets routed to the appropriate area owners
    on Jun 30, 2023
  6. ghost removed
    in-prThere is an active PR which will close this issue when it is merged
    on Jun 30, 2023
  7. ghost locked as resolved and limited conversation to collaborators on Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions