Repository navigation
Remove asm versions of Monitor helpers and use portable C++ versions instead #8932
Description
Ideally should be done before or as part of https://github.com/dotnet/coreclr/issues/13980
{{ message }}
Ideally should be done before or as part of https://github.com/dotnet/coreclr/issues/13980
Activity
benaadams commentedon Sep 14, 2017
Is an interesting difference; Windows has custom asm, and linux goes straight to C++?
kouvel commentedon Sep 14, 2017
Yep, I don't expect there will be much change in perf
benaadams commentedon Sep 14, 2017
Might make the Windows version worse; and the Linux version is already worse
kouvel commentedon Sep 14, 2017
That would be some good data to act on :)
kouvel commentedon Sep 23, 2017
In the referenced PR that removes the asm helpers, it looks like the Windows version is worse than the asm mainly because of some register allocation issues, but the difference in perf doesn't seem to be significant. I didn't see much difference between Windows/Linux in the perf of the hottest fast paths (unlocked cases). Another difference is GetThread() is slower on Linux, not much can be done about that at the moment.