[wasm] Optimize bundled_resources key creation, hashing, and comparison#101460
Merged
Conversation
ghost
added
the
Contributor
|
Tagging subscribers to 'arch-wasm': @lewing |
This was referenced Apr 24, 2024
Closed
kg
force-pushed
the
bundled-resources-opt
branch
from
9b0064b to
0c58523
Compare
This was referenced Apr 24, 2024
Closed
Closed
lambdageek
reviewed
May 13, 2024
lambdageek
reviewed
May 13, 2024
lambdageek
reviewed
May 13, 2024
lambdageek
reviewed
May 13, 2024
| char *key; | ||
| if (dn_simdhash_ptr_ptr_try_get_value (bundled_resource_key_lookup_table, (void *)value->id, (void **)&key)) { | ||
| dn_simdhash_ptr_ptr_try_remove (bundled_resource_key_lookup_table, (void *)value->id); | ||
| g_free (key); |
Member
There was a problem hiding this comment.
Ah ok, this is what is cleaning up the key.
lambdageek
approved these changes
May 13, 2024
lambdageek
left a comment
lambdageek
left a comment
Member
There was a problem hiding this comment.
LGTM
consider moving g_memrchr to eglib (remember to also update eglib-remap.h)
Ruihan-Yin
pushed a commit
to Ruihan-Yin/runtime
that referenced
this pull request
May 30, 2024
…on (dotnet#101460) Optimize bundled_resources key creation and hashing Migrate bundled_resources to simdhash
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In startup profiles we spend a lot of time in
bundled_resources_resource_id_equaland..._id_hash.