Skip to content

Add a regression test for double Content-Length header in HttpWebRequest#102989

Merged
MihaZupan merged 1 commit into
dotnet:mainfrom
MihaZupan:web-client
Jun 6, 2024
Merged

Add a regression test for double Content-Length header in HttpWebRequest#102989
MihaZupan merged 1 commit into
dotnet:mainfrom
MihaZupan:web-client

Conversation

@MihaZupan

@MihaZupan MihaZupan commented Jun 3, 2024

Copy link
Copy Markdown
Member

Replaces #102986

Adds a test for the impacted scenario.

@MihaZupan MihaZupan added this to the 9.0.0 milestone Jun 3, 2024
@MihaZupan MihaZupan requested a review from ManickaP June 3, 2024 12:22
@MihaZupan MihaZupan self-assigned this Jun 3, 2024
@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

@MihaZupan

Copy link
Copy Markdown
Member Author

/azp run runtime-libraries-coreclr outerloop

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@liveans liveans left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can you add a test for this case?

Comment thread src/libraries/System.Net.Requests/src/System/Net/HttpWebRequest.cs Outdated
@ManickaP

ManickaP commented Jun 4, 2024

Copy link
Copy Markdown
Member

Should we at least keep the test from this PR?

@MihaZupan MihaZupan reopened this Jun 4, 2024
@MihaZupan MihaZupan changed the title Fix double Content-Length header in HttpWebRequest Add a regression test for double Content-Length header in HttpWebRequest Jun 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-System.Net.Http test-enhancement Improvements of test source code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants