Skip to content

pal init: Move InitializeFlushProcessWriteBuffers() after VIRTUALInitialize() - #107100

Merged
janvorli merged 1 commit into
dotnet:mainfrom
harisokanovic:dev/harisokn/fixup-membarrier-init-freebsd
Aug 28, 2024
Merged

janvorli merged 1 commit into
dotnet:mainfrom
harisokanovic:dev/harisokn/fixup-membarrier-init-freebsd

Conversation

@harisokanovic

Copy link
Copy Markdown
Contributor

A fixup of commit 27ee590 that's broken on platforms which don't
support membarrier() syscall: GetVirtualPageSize() is called in the
fallback path of InitializeFlushProcessWriteBuffers() and attempts to
mmap() zero bytes.

Move InitializeFlushProcessWriteBuffers() after VIRTUALInitialize() but
before the first thread is created.

Fixes #106892
Fixes #106722

@ghost ghost added the area-PAL-coreclr only for closed issues label Aug 28, 2024
@dotnet-policy-service dotnet-policy-service Bot added the community-contribution Indicates that the PR has been added by a community member label Aug 28, 2024
…ialize()

A fixup of commit 27ee590 that's broken on platforms which don't
support membarrier() syscall: GetVirtualPageSize() is called in the
fallback path of InitializeFlushProcessWriteBuffers() and attempts to
mmap() zero bytes.

Move InitializeFlushProcessWriteBuffers() after VIRTUALInitialize() but
before the first thread is created.

Fixes dotnet#106892
Fixes dotnet#106722
@harisokanovic
harisokanovic force-pushed the dev/harisokn/fixup-membarrier-init-freebsd branch from 5bc42ed to 86b2026 Compare August 28, 2024 18:03
@mangod9

mangod9 commented Aug 28, 2024

Copy link
Copy Markdown
Member

@janvorli as well..

@janvorli janvorli left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@janvorli
janvorli merged commit c655529 into dotnet:main Aug 28, 2024
@jkotas

jkotas commented Aug 28, 2024

Copy link
Copy Markdown
Member

/backport to release/9.0

@github-actions

Copy link
Copy Markdown
Contributor

Started backporting to release/9.0: https://github.com/dotnet/runtime/actions/runs/10605307097

jtschuster pushed a commit to jtschuster/runtime that referenced this pull request Sep 17, 2024
…ialize() (dotnet#107100)

A fixup of commit 27ee590 that's broken on platforms which don't
support membarrier() syscall: GetVirtualPageSize() is called in the
fallback path of InitializeFlushProcessWriteBuffers() and attempts to
mmap() zero bytes.

Move InitializeFlushProcessWriteBuffers() after VIRTUALInitialize() but
before the first thread is created.

Fixes dotnet#106892
Fixes dotnet#106722

Co-authored-by: Haris Okanovic <harisokn@amazon.com>
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-PAL-coreclr only for closed issues community-contribution Indicates that the PR has been added by a community member

Projects

None yet

4 participants