Assert pointer relocs are aligned - #113069
Merged
Merged
Conversation
ghost
added
the
Contributor
There was a problem hiding this comment.
PR Overview
This pull request introduces debug assertions to ensure pointer relocations are properly aligned during object emission.
- Adds a DEBUG-only block to iterate over relocations and check for pointer relocation alignment
- Verifies the node content's alignment against the target pointer size
Reviewed Changes
| File | Description |
|---|---|
| src/coreclr/tools/aot/ILCompiler.Compiler/Compiler/ObjectWriter/ObjectWriter.cs | Introduces debug assertions ensuring pointer relocs and node alignment are verified |
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
filipnavara
approved these changes
Mar 3, 2025
jkotas
reviewed
Jul 15, 2025
Member
Author
|
/azp run runtime-nativeaot-outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Jul 15, 2025
Open
Member
Author
|
/azp run runtime-nativeaot-outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
@dotnet/ilc-contrib could someone have a look? This is just a new assert. The Pri1 test failures are all #117654 that was fixed |
Member
Author
|
/ba-g test failures are #117654 that was fixed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a prerequisite for disabling data dehydration on Windows by default. Straddling pointers are not a big deal with dehydration, but straddling a page boundary with a reloc on Windows is a (perf) problem.
Cc @dotnet/ilc-contrib