[RuntimeAsync] Move runtime async to the main repo - #113976

Closed

VSadov wants to merge 221 commits into

dotnet:mainfrom

Commits on Nov 16, 2023

More updates
davidwrighton
committed
0beb3f0
more tweaks
davidwrighton
committed
783754d
It builds
davidwrighton
committed
8c43a9a
ItCompilesButConvertingFromAsyncVariantsIsntRight
davidwrighton
committed
545509c
It builds and it should work... but doesn't
davidwrighton
committed
20eb76e
Oops pMethod can be NULL
davidwrighton
committed
ad0bd71
We are able to load Task<T> methods which are virtual again, next to actually write some "async" and start breaking things again
davidwrighton
committed
8d416cb
Add some simple benchmarks of the existing situation
davidwrighton
committed
0fbd60c
Add Test case for synchronous behavior
davidwrighton
committed
3270fdf
Now we should be forcing transient lookup which wont' work
davidwrighton
committed
84ae54d
Fix method classification for async2 methods
davidwrighton
committed
84f7148
We are now triggering the transient IL compilation for the thunks
davidwrighton
committed
51e2011
Calling Sample Works! Now to implement an actual async implementation and see if suspension works
davidwrighton
committed
6fc166a
WithYield runtime task test
davidwrighton
committed
0b10933
- Add async to Task stub
davidwrighton
committed
34a2219
Runtime handled tasks markdown for experiment
davidwrighton
committed
38b2087
Writeup managed side of runtime driven suspension. Need to write details into doc, but managed code may have the right logic :)
davidwrighton
committed
b7b00de
Add the logic to try to flow ExecutionContext and SynchronizationContext as appropriate
davidwrighton
committed
8353bd8
It compiles, but doesn't link
davidwrighton
committed
2aac618
C++ portion builds
davidwrighton
committed
0e82446
In theory, this should work?
davidwrighton
committed
718aa39
native part builds
davidwrighton
committed
6d1e7b7
Merged PR 34323: make things build

VSadov
authored and
davidwrighton
committed
d20bb17
It successfully captures... and unwind doesn't quite work
davidwrighton
committed
aee9b9f
Basic unwind support mostly works. Expected that it crashes unpredictably in the presence of Suspend operations, but other stuff seems to work. Now to rework Task generation to avoid multithreaded …
davidwrighton
committed
df91ac6
It runs? Doesn't handle return value correctly, but runs for the right number of iterations, I think
davidwrighton
committed
56178c3
Free memory properly
davidwrighton
committed
52f272b
Merged PR 34523: remove DEFINE_METHOD for no longer existing methods

VSadov
authored and
davidwrighton
committed
204633e
Fix returns within async2 tasks... returning value to outer task is still not working
davidwrighton
committed
f30fa3f
Set the return value on output from this whole thing! The example works!
davidwrighton
committed
19b5c99
Fix for code which uses the 32 byte parameter area on X64
davidwrighton
committed
4174447
Add corjit flags and corinfo for the new async work
davidwrighton
committed
989c4cb
Add test case compiled with the new compiler
davidwrighton
committed
9c7a444
Fix issue exposed by merging to latest main bits
davidwrighton
committed
bd38a81
Add GC Support to unwind based async implementation
davidwrighton
committed
41aaae8
Merged PR 34691: Prototype for generating state machines in JIT for async

jakobbotsch
authored and
davidwrighton
committed
18d7cdd
Merged PR 34735: Simplify the async2 api surface
davidwrighton
committed
4cc1f18
Merged PR 34743: Update compiler and such
davidwrighton
committed
7645bfd
Merged PR 34707: Get basic thunk working for JIT state machines

jakobbotsch
authored and
davidwrighton
committed
9e4389b
Add test case with new logic which doesn't actually yield, but has all the various yield points in there
davidwrighton
committed
6d1091b
Closer to correct implementation of thunk which uses UnsafeAwaitAwaiterFromRuntimeAsync
davidwrighton
committed
669eb44
Merged PR 34763: Get suspension working with jit state machines

jakobbotsch
authored and
davidwrighton
committed
34897d7
Fixes to make it all build and run properly
davidwrighton
committed
2fd8029
Merged PR 34776: replaces couple IL tests with trivial C# variants, adds a test for object capture, and a fix to make it pass

VSadov
authored and
davidwrighton
committed
51a3a87
Merged PR 34773: Get MinOpts and OSR working with JIT state machines

jakobbotsch
authored and
davidwrighton
committed
5caa51e
Merged PR 34838: Upgrade the markdown doc with a somewhat better description of the unwinder approach
davidwrighton
committed
b7baed9
Merged PR 34841: Make BYREF CSEs unavailable across suspension points

jakobbotsch
authored and
davidwrighton
committed
604e50f
Merged PR 34886: update roslyn reference for impement/override support, add a few tests

VSadov
authored and
davidwrighton
committed
7d241b7
Merged PR 34865: Make Continuation a class

jakobbotsch
authored and
davidwrighton
committed
fe0f8bb
Merged PR 34889: Implement SPMI support for JIT state machine JIT<->EE APIs

jakobbotsch
authored and
davidwrighton
committed
6449b63
Merged PR 34910: Update and merge design document for JIT generated state machines into David's document

jakobbotsch
authored and
davidwrighton
committed
00519cf
Merged PR 34897: Implement proper GC reporting for async continuation returns

jakobbotsch
authored and
davidwrighton
committed
65fa227
Merged PR 34912: Add support for void returning Async2 methods, and ValueTask
davidwrighton
committed
15af83a
Merged PR 34919: Add support for ValueTask<T> and Task/ValueTask nongeneric to async2 Jit model
davidwrighton
committed
2909b7f
Fix build failure

jakobbotsch
authored and
davidwrighton
committed
4aa0bcf
Fix test build

jakobbotsch
authored and
davidwrighton
committed
ed1e50b
Fix getting return value from continuation

jakobbotsch
authored and
davidwrighton
committed
b3f5b6f
Merged PR 34944: Add EH support to the JIT SM prototype

jakobbotsch
authored and
davidwrighton
committed
e7d4a00
Merged PR 35015: Fix type of RuntimeAsyncMaintainedData

jakobbotsch
authored and
davidwrighton
committed
92f852f
Merged PR 35022: test for generics and a roslyn update to compile it

VSadov
authored and
davidwrighton
committed
2fc5a2a
Merged PR 35000: Handle retbufs properly in JIT SM prototype

jakobbotsch
authored and
davidwrighton
committed
851c7c3
Merged PR 34896: Add "varying yields" benchmark; optimize/fix prototypes for it

jakobbotsch
authored and
davidwrighton
committed
335e302
Merged PR 35032: Avoid boxing return values in the resumed path when unnecessary

jakobbotsch
authored and
davidwrighton
committed
626de90
Merged PR 35049: Call async2 entry from thunks with direct "call" IL instruction

jakobbotsch
authored and
davidwrighton
committed
1edab00
Merged PR 35055: initial compiler support for ValueTask

VSadov
authored and
davidwrighton
committed
848d734
Merged PR 35075: Fix ValueTask handling for async2
davidwrighton
committed
9dce32d
Fix incorrect resume BB insertion

jakobbotsch
authored and
davidwrighton
committed
00da10f
Skip post-async2 functions for GC stress

jakobbotsch
authored and
davidwrighton
committed
55e9410
Run jit-format

jakobbotsch
authored and
davidwrighton
committed
b9190c6
Fix mixing up struct slot indices with GC data array indices

jakobbotsch
authored and
davidwrighton
committed
6ac1f06
Merged PR 35077: Add an EH performance benchmark
davidwrighton
committed
fba68af
Update outdated comment

jakobbotsch
authored and
davidwrighton
committed
350cf5a
Fix a JITDUMP

jakobbotsch
authored and
davidwrighton
committed
6ac06db
Update design document for latest JIT SM changes

jakobbotsch
authored and
davidwrighton
committed
e762f70
Remove dead/unnecessary code

jakobbotsch
authored and
davidwrighton
committed
0828e72
Fix non-generic async1 -> async2 thunks

jakobbotsch
authored and
davidwrighton
committed
177c3b2
Add a list of expected test failures

jakobbotsch
authored and
davidwrighton
committed
2c4257a
Merged PR 35118: Add a writeup based on the EH microbenchmark I wrote up
davidwrighton
committed
6c3e6a4
Merged PR 35196: Switching to the new syntax

VSadov
authored and
davidwrighton
committed
5ba6888
Merged PR 35215: Writeup about span/byref and runtime-async

VSadov
authored and
davidwrighton
committed
d9fbc66
Update buildroslynnugets.cmd script to use public github details
davidwrighton
committed
11f8bd2
Add readme for async2 experiment
davidwrighton
committed
a6a45ed
Follow instructions in the Create an experiment document
davidwrighton
committed
6fec721
Correct issue number for async2 work
davidwrighton
committed
9495c90
Fix readme even more
davidwrighton
committed
75319ab
Merged PR 35233: Add measurement of async2 logic with Execution and SynchronizationContext capture/restore (#2421)
davidwrighton
authored
c4a2eb3
Fix the roslyn build script (#2422)
davidwrighton
authored
6b47db0

Commits on Nov 17, 2023

Null out TLS head continuation reference
jakobbotsch
committed
842ad04
Manual CSE
jakobbotsch
committed
282218b
Fix paths in buildroslynnugets.cmd (#2426)
jakobbotsch
authored
5e9973b
Switch to JIT prototype by default; add support matrix (#2427)
jakobbotsch
authored
0b1105a
Rename GetHeadContinuation -> UnlinkHeadContinuation
jakobbotsch
committed
fc15ad6
Merge pull request #2429 from jakobbotsch/tls-continuation-ref
jakobbotsch
authored
7b79279

Commits on Nov 28, 2023

Fix resumption stub target in the presence of backpatching (#2428)
jakobbotsch
authored
ba3bbb0

Commits on Nov 30, 2023

[Async-2] A few small tweaks on the managed side of state-machine based implementation. (#2431)
VSadov
authored
a691996

Commits on Dec 12, 2023

[Async-2]: Tasklet aging (#2425)
VSadov
authored
5205ef3

Commits on Dec 25, 2023

Bump the roslyn commit to a version supporting top-level async2 functions. Add a test. (#2470)
VSadov
authored
ff668bd

Commits on Jan 2, 2024

Benchmark of interaction between async1 and async2 (#2469)
davidwrighton
authored
4ba1bc5

Commits on Jan 9, 2024

Fix typo
IS4Code
authored
c5a199c
Merge pull request #2479 from IS4Code/patch-1
Dan Moseley
authored
0c15f95

Commits on Jan 23, 2024

Writeup on C# Language changes in async2 experiment. (#2488)

authored
e69dda5

Commits on Oct 15, 2024

Merge remote-tracking branch 'upstream/main' into update-to-main
jakobbotsch
committed
ce82124
Adapt SPC and JIT
jakobbotsch
committed
f538fc9
mdc -> mdf
jakobbotsch
committed
16bb36a
Rename
jakobbotsch
committed
43fd4d9
Regenerate JIT-EE interface
jakobbotsch
committed
a91a99b
Last VM fixes
jakobbotsch
committed
b0fe4c5
Run API compat suppression generator
jakobbotsch
committed
07e8e59

Commits on Oct 17, 2024

point to rebased Roslyn branch
VSadov
committed
badb398
fix the build
VSadov
committed
6996857

Commits on Oct 21, 2024

Merge remote-tracking branch 'upstream-main/main' into update-to-main
jakobbotsch
committed
9b89c68
Fix AllocContinuation
jakobbotsch
committed
94d8614
Fix recognition of async2 RuntimeHelpers intrinsics
jakobbotsch
committed
26924fa
Set likelihoods in async transformation
jakobbotsch
committed
1e6fabc
Ensure async continuation is busy
jakobbotsch
committed
b0f3179
Fix recognition of Async2CallContinuation intrinsic
jakobbotsch
committed
0f73c40
Compute DFS tree for liveness
jakobbotsch
committed
bef94ed
Rename likelihood
jakobbotsch
committed
1ba32a4
Fix storing results on no EH rethrow
jakobbotsch
committed
4ca306b
Fix resuming with 2 states
jakobbotsch
committed
a1bdae0
Spill only for async2 methods
jakobbotsch
committed
f99ea2b
Fix type of VA cookie
jakobbotsch
committed
0647500
Merge pull request #2717 from jakobbotsch/update-to-main
jakobbotsch
authored
8f27c2a

Commits on Oct 28, 2024

Deleting parts of suspension-async flavor. (#2738)
VSadov
authored
083681c

Commits on Nov 11, 2024

[Runtime Async] Addressing test failures. (#2760)
VSadov
authored
cc268ed

Commits on Nov 12, 2024

[Runtime Async] Add support for shared generics (#2755)
jakobbotsch
authored
0a10db8

Commits on Nov 13, 2024

[RuntimeAsync] Add x86 support (#2767)
jakobbotsch
authored
19ce23f

Commits on Nov 14, 2024

[RuntimeAsync] Clean up and fix async2 tests (#2768)
jakobbotsch
authored
0c66941
[RuntimeAsync] Add support for arm64 (#2769)
jakobbotsch
authored
efb2892
Fix linux-x64 support (#2770)
jakobbotsch
authored
36b4305

Commits on Nov 15, 2024

Add arm32 support (#2773)
jakobbotsch
authored
0933305

Commits on Nov 18, 2024

awaits of Task-returning methods from async2 are done as thunk calls. (#2781)

VSadov
and
jakobbotsch
authored
81e5c1e

Commits on Nov 26, 2024

[RuntimeAsync] Add support for async struct instance methods (potential implementation 2) (#2805)
jakobbotsch
authored
4e7c442

Commits on Nov 28, 2024

[RuntimeAsync] Keep `LoaderAllocator` objects alive from continuations (#2812)
jakobbotsch
authored
4daa761

Commits on Dec 4, 2024

[RuntimeAsync] Fix support for pinvokes (#2847)
jakobbotsch
authored
d38e953

Commits on Dec 5, 2024

[RuntimeAsync] Fix a couple of cases where x86 would overwrite ecx on return (#2854)
jakobbotsch
authored
d95f6ea

Commits on Dec 14, 2024

[RuntimeAsync] Switch the implementation to the new shape of runtime async methods. (#2818)

VSadov
and
jakobbotsch
authored
7624a38

Commits on Dec 18, 2024

Merge pull request #2895 from jakobbotsch/update-to-main
jakobbotsch
authored
9151883

Commits on Jan 9, 2025

Format async2 JIT code (#2915)
jakobbotsch
authored
b077e29

Commits on Feb 24, 2025

Implement a change in IL API to use RuntimeHelpers.Await<T>(Task<T>) and similar helpers. (#2951)

VSadov
and
jakobbotsch
authored
de4719c

Commits on Mar 6, 2025

Merge remote-tracking branch 'upstream-main/main' into merge-from-upstream
jakobbotsch
committed
be99a4d
Fixes after merge
jakobbotsch
committed
fdd554b
Run jit-format
jakobbotsch
committed
b4257bf

Commits on Mar 7, 2025

bump roslyn ref to a newer drop
VSadov
committed
320a565
Fix one assert
jakobbotsch
committed
2922a4e
Update to handle custom layouts properly
jakobbotsch
committed
ce5fd93
FIx more JIT asserts
jakobbotsch
committed
8fb0f4c
Fix inlining with AsyncContinuation
jakobbotsch
committed
d32d2e8
Fix `JIT_ResumeOSRWorker` holding lock for too long
jakobbotsch
committed
2cea79a
Stop capturing ret buff arg
jakobbotsch
committed
f342fe7
Disable object stack allocation in async2 methods
jakobbotsch
committed
22c4d06
[RuntimeAsync] Merge from upstream (#3030)
jakobbotsch
committed
fcc449d

Commits on Mar 11, 2025

[RuntimeAsync] Some VM cleanups, TODOs, renames and better comments. (#3032)
VSadov
committed
917982f

Commits on Mar 15, 2025

fix build (#3041)
VSadov
committed
a0d704d

Commits on Mar 18, 2025

[RuntimeAsync] Normalize the box type in resume stubs (#3042)
VSadov
committed
a6e563b

Commits on Mar 21, 2025

Made Fibonacci tests to actually run Fibonacci algorithm (#3050)
VSadov
committed
76f1d17

Commits on Mar 26, 2025

Commits on Mar 27, 2025

reconcile root and eng files with runtime repo
VSadov
committed
eae52ed
Merge remote-tracking branch 'upstream/main' into a2move
VSadov
committed
33887a4

Commits on Mar 28, 2025

fix build
VSadov
committed
f788e1e
disable building runtime async tests for now
VSadov
committed
1efcc66
fix for unix
VSadov
committed
5de877a
another fix for unix
VSadov
committed
d74066d
another unix fix
VSadov
committed
c9284cf
build fixes for x86
VSadov
committed
1ff64f1
build fix for mono
VSadov
committed
e93475a
jit formatting
VSadov
committed
5f48abb
trailing whitespaces
VSadov
committed
f42e260
build fix for riscv
VSadov
committed
9558af6

Commits on Mar 29, 2025

Commits on Mar 30, 2025

Commits on Mar 31, 2025

Merge branch 'main' into a2move
VSadov
authored
0a52d75
more build fixes for RISCV
VSadov
committed
f9facc3
Restore CODEOWNERS
jakobbotsch
committed
d105671
Add license headers for new files
jakobbotsch
committed
b8450d9
Delete unused file
jakobbotsch
committed
d796485
Undo whitespace change
jakobbotsch
committed
66c8239
Remove new unused code slot methods
jakobbotsch
committed
3190a60
Remove new unused EmitUNBOX method
jakobbotsch
committed
e6078fc
Revert a logging change
jakobbotsch
committed
479d4f4
Update src/coreclr/jit/codegenriscv64.cpp

VSadov
and
am11
authored
33d026d
Merge branch 'main' into a2move
VSadov
authored
b3c2804
Remove unused IsInCurrentFrame
jakobbotsch
committed
21981a9
Remove unused new CLASSID_SYSTEM_BYTE
jakobbotsch
committed
5299ec7
Refactor and split up async2 transformation
jakobbotsch
committed
688466b

Commits on Apr 1, 2025

Write function headers for new JIT functions
jakobbotsch
committed
3a76d37
Remove unused functions
jakobbotsch
committed
828e7b2
More function headers and clean up
jakobbotsch
committed
52ce4f7
Rename async2 -> async
jakobbotsch
committed
d9487b2
Rename in RISC-V and LA64 as well
jakobbotsch
committed
7364c0c

Commits on Apr 3, 2025

remove code added to eetwain and gcinfodecoder
VSadov
committed
e659987
merge from upstream
VSadov
committed
fd1c224
fix after merge
VSadov
committed
0aff212

Commits on Apr 4, 2025

Commits on Apr 5, 2025

remove unnecessary change
VSadov
committed
af84887
fix for x86
VSadov
committed
7ba09e8
fix for arm32
VSadov
committed
50e1e85
Merge branch 'main' into a2move
VSadov
authored
4cce333
more fixing for arm32
VSadov
committed
b1fe9e2
typo
VSadov
committed
030c988

Commits on Apr 6, 2025

actual fix?
VSadov
committed
3f3fe9e
hide async2 variants from reflection
VSadov
committed
d5e4faf
undo reflection workaround
VSadov
committed
6e43cad

Commits on Apr 7, 2025