Improve gtDispConst for CNS_STR - #117350
Merged
Merged
Conversation
github-actions
Bot
added
the
area-CodeGen-coreclr
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
This was referenced Jul 6, 2025
Open
jkoritzinsky
reviewed
Jul 7, 2025
EgorBo
marked this pull request as ready for review
July 16, 2025 11:54
Co-authored-by: Jeremy Koritzinsky <jkoritzinsky@gmail.com>
This was referenced Jul 17, 2025
Member
Author
|
PTAL @jkoritzinsky @dotnet/jit-contrib - debug only change to improve JITDUMP for GT_CNS_STR nodes and get rid of |
jakobbotsch
approved these changes
Jul 17, 2025
jkoritzinsky
approved these changes
Jul 17, 2025
EgorBo
enabled auto-merge (squash)
July 17, 2025 22:30
Member
Author
|
/ba-g "NetCore-Public 80 timeout" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
it used to just print
"<string constant>"for any string literal.Also, it looks like
convertUtf16ToUtf8ForPrintingwas broken.