JIT: Simplify Compiler::getHWIntrinsicImmTypes - #117784
Merged
amanasifkhalid merged 4 commits intoJul 22, 2025
Merged
Conversation
github-actions
Bot
added
the
area-CodeGen-coreclr
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
This was referenced Jul 17, 2025
Open
Contributor
Author
|
@dotnet/jit-contrib PTAL. No diffs. |
a74nh
approved these changes
Jul 18, 2025
a74nh
left a comment
a74nh
left a comment
Contributor
There was a problem hiding this comment.
This LGTM. Cleans up more than I expected.
tannergooding
approved these changes
Jul 21, 2025
tannergooding
approved these changes
Jul 22, 2025
amanasifkhalid
enabled auto-merge (squash)
July 22, 2025 17:29
Contributor
Author
|
/ba-g linux_musl libraries tests timed out |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Numerous SVE2 PRs have had to expand the checks in this function to catch new intrinsics. These checks aren't necessary for computing the intrinsic's immediates' sizes/types. They are essentially debug checks that are (or ought to be) checked downstream. Removing them simplifies later intrinsic additions, and cleans up the function quite a bit.
cc @dotnet/arm64-contrib