Conversation
…t recent SharedPatchBypassBuffer changes
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses allocation failures in the Linux debugger caused by recent changes to SharedPatchBypassBuffer. The fix increases debugger memory allocation constants to accommodate the larger buffer size requirements.
Key Changes
- Increases
DBG_MAX_EXECUTABLE_ALLOC_SIZEfrom 112 to 120 bytes to match the size of SharedPatchBypassBuffer - Doubles
EXPECTED_CHUNKSIZEfrom 128 to 256 bytes to provide adequate space for the larger allocation size plus metadata overhead
Contributor
|
Tagging subscribers to this area: @steveisok, @dotnet/dotnet-diag |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
steveisok
self-requested a review
July 19, 2025 00:10
steveisok
approved these changes
Jul 19, 2025
hoyosjs
approved these changes
Jul 19, 2025
tommcdon
enabled auto-merge (squash)
July 19, 2025 00:26
Member
Author
|
/ba-g failures are unrelated |
tommcdon
added a commit
to tommcdon/runtime
that referenced
this pull request
Jul 22, 2025
…17843) * Update DBG_MAX_EXECUTABLE_ALLOC_SIZE and EXPECTED_CHUNKSIZE to account recent SharedPatchBypassBuffer changes * Comment-only update Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Improve EXPECTED_CHUNKSIZE comment --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
jeffschwMSFT
added a commit
that referenced
this pull request
Jul 23, 2025
…#117912) * Update DBG_MAX_EXECUTABLE_ALLOC_SIZE and EXPECTED_CHUNKSIZE to account recent SharedPatchBypassBuffer changes * Comment-only update * Improve EXPECTED_CHUNKSIZE comment --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Jeff Schwartz <jeffschw@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recent change to SharedPatchBypassBuffer caused allocation failures in the debugger, leading to linux debugging to fail. This change increases the buffer sizes to allow for the increased size to SharedPatchBypassBuffer