[MONO] Partially revert "Clean up in Number.Formatting.cs (#110955)" - #118499
Conversation
This reverts commit 4020e05.
There was a problem hiding this comment.
Pull Request Overview
This PR partially reverts performance regression introduced in PR #110955 that affected Mono runtime significantly. The changes revert optimizations in number formatting that used ReadOnlySpan<byte> properties back to static readonly byte arrays to restore performance.
- Reverts
TwoDigitsCharsAsBytesandTwoDigitsBytesfromReadOnlySpan<byte>properties back tostatic readonly byte[]fields - Updates references from
MemoryMarshal.GetReferencetoMemoryMarshal.GetArrayDataReferenceto match the reverted field types - Adds
.ToArray()calls to convert the concatenated UTF-8 string literals back to byte arrays
github-actions
Bot
added
the
needs-area-label
|
PTAL @stephentoub @lewing |
I expect that the rewrite would have to be ifdefed out for Mono as well, to avoid introducing even worse perf regression. |
lewing
left a comment
lewing
left a comment
There was a problem hiding this comment.
approving for wasm/mono since this we see this in key scenarios, I'm fine with an ifdef if that is preferred.
|
Added if-defs, PTAL @jkotas |
jkotas
left a comment
jkotas
left a comment
There was a problem hiding this comment.
Thanks! LGTM. I assume that this is zero-diff change for CoreCLR and NAOT.
|
/ba-g coreclr android timeouts are known and resolved on the tip of main |
Some changes in #110955 PR regressed Mono runtime significantly (>150 benchmarks) given number formatting is often a perf sensitive area I'm reverting that change for now, we'll figure out it later in 11.