Skip to content

Clarify how to interpret the Variant value on Guid. - #118987

Merged
tannergooding merged 3 commits into
mainfrom
nohwnd-patch-1
Aug 25, 2025
Merged

tannergooding merged 3 commits into
mainfrom
nohwnd-patch-1

Conversation

@nohwnd

@nohwnd nohwnd commented Aug 22, 2025

Copy link
Copy Markdown
Member

The original description makes it hard to understand when you are not already an expert, and don't know that "don't care" bits are a term used in the linked specification.

The original description makes it hard to understand when you are not already an expert, and don't know that "don't care" bits are a term used in the linked specification.
Copilot AI review requested due to automatic review settings August 22, 2025 10:44
@github-actions github-actions Bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Aug 22, 2025

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR improves the documentation for the Guid.Variant property to make it more accessible to developers who aren't already familiar with UUID specification terminology. The change clarifies how to interpret the variant value and provides a concrete example.

  • Explains that only the first 2 bits might be relevant depending on the UUID variant
  • Clarifies what "don't-care" bits means in this context
  • Adds a practical example showing how to interpret the value for UUIDv7

Comment thread src/libraries/System.Private.CoreLib/src/System/Guid.cs Outdated
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@jkotas jkotas added area-System.Runtime and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Aug 22, 2025
@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @dotnet/area-system-runtime
See info in area-owners.md if you want to be subscribed.

@jkotas

jkotas commented Aug 22, 2025

Copy link
Copy Markdown
Member

API introduced by #104124. cc @tannergooding

Comment thread src/libraries/System.Private.CoreLib/src/System/Guid.cs Outdated

@tannergooding tannergooding left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll want to make a similar change against dotnet-api-docs to ensure that the official docs are updated.

@tannergooding
tannergooding merged commit f05f25b into main Aug 25, 2025
142 of 144 checks passed
@tannergooding
tannergooding deleted the nohwnd-patch-1 branch August 25, 2025 16:14
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants