Repository navigation
[Wasm RyuJIT] Fix for assert in obscure block store scenario - #126392
Merged
Merged
Conversation
kg
added
arch-wasm
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a WASM RyuJIT assertion/regalloc issue in an edge-case block-store lowering/codegen path by avoiding creation/consumption of temporary regs when using native memory.copy/memory.fill and the corresponding address is marked non-faulting.
Changes:
- Adjusted WASM lowering (
LowerBlockStore) to only mark src/dst addresses as multiply-used when null-checking (or non-native lowering) requires it. - Updated WASM codegen for
GT_STORE_BLKto skipGetMultiUseOperandRegin native-op + non-faulting cases, and tightened an invariant with a debug assert.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/coreclr/jit/lowerwasm.cpp |
Refines when block-store src/dst addresses are marked multiply-used to avoid unnecessary temps for non-faulting native ops. |
src/coreclr/jit/codegenwasm.cpp |
Avoids fetching temp regs for native memory.copy/fill when no null check is needed; adds an assert guarding a contained-src path. |
This was referenced Apr 1, 2026
Open
kg
marked this pull request as ready for review
April 1, 2026 18:43
Contributor
Author
|
@dotnet/jit-contrib PTAL |
SingleAccretion
approved these changes
Apr 2, 2026
AndyAyersMS
approved these changes
Apr 2, 2026
This was referenced Apr 3, 2026
radekdoulik
pushed a commit
to radekdoulik/runtime
that referenced
this pull request
Apr 9, 2026
…126392) This fixes the assert about temporary regs from ```System.ValueTuple`4[System.__Canon,System.__Canon,System.__Canon,System.__Canon]:System.IComparable.CompareTo(System.Object):int:this``` in dotnet#125756
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the assert about temporary regs from
System.ValueTuple`4[System.__Canon,System.__Canon,System.__Canon,System.__Canon]:System.IComparable.CompareTo(System.Object):int:thisin #125756