Repository navigation
[cDAC] Prepare for dacdbi stackwalk - #128679
Merged
Merged
Conversation
rcj1
changed the title
Contributor
|
Tagging subscribers to this area: @steveisok, @tommcdon, @dotnet/dotnet-diag |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors cDAC stack walking to expose native marker states while preserving legacy SOSDAC-visible filtering for existing IXCLRDataStackWalk consumers.
Changes:
- Adds
StackWalkStateto the stack walk contract and exposesGetState. - Splits native stack walk states into initial/native-marker/Frame states.
- Updates legacy stack walking to skip newly surfaced native-only frames.
Show a summary per file
| File | Description |
|---|---|
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Legacy/ClrDataStackWalk.cs |
Filters the expanded stack walk back to legacy-visible frame states. |
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/StackWalk/StackWalk_1.ExceptionHandling.cs |
Restricts funclet checks to managed frameless states. |
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Contracts/StackWalk/StackWalk_1.cs |
Adds native marker states to stack walk iteration and GC-reference filtering. |
src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Abstractions/Contracts/IStackWalk.cs |
Moves StackWalkState into the contract abstraction and adds GetState. |
docs/design/datacontracts/StackWalk.md |
Documents the new stack walk state API. |
Copilot's findings
- Files reviewed: 5/5 changed files
- Comments generated: 3
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
rcj1
marked this pull request as draft
May 28, 2026 13:46
max-charlamb
approved these changes
May 28, 2026
max-charlamb
left a comment
max-charlamb
left a comment
Member
There was a problem hiding this comment.
looks good to me once tests pass
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR attempts to prepare for the DacDbi stackwalk APIs by refactoring the stackwalking iterator to return all frames. Specifically, we want to surface from the cDAC API the native marker frames that the SosDac does not consume but the DacDbi stack walk will consume. We then filter at the consumer level which frames we want to see.
In addition, we fill out a couple branches of a StackWalk Request API.