[wasm] Bail R2R for SIMD16 store-indirect and SIMD16 parameters#130101
Merged
AndyAyersMS merged 1 commit intoJul 2, 2026
Conversation
Vector128 parameters are lowered to i32 in the wasm signature and a SIMD16 store-indirect emits v128.store with an i32 operand, both of which produce invalid modules; bail such methods to the interpreter via NYI_WASM_SIMD until SIMD16 is properly supported. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
github-actions
Bot
added
the
area-CodeGen-coreclr
Member
Author
|
@adamperlin PTAL |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds additional WebAssembly (wasm) SIMD-related “not yet implemented” bailouts in CoreCLR JIT codegen to avoid generating invalid wasm modules (notably in ReadyToRun scenarios) when TYP_SIMD16 values flow through unsupported code paths.
Changes:
- Bail out when a method has
TYP_SIMD16(Vector128) parameters, since they are currently represented asi32in the wasm signature. - Bail out when emitting an indirect store of a
TYP_SIMD16value to avoid producing invalidv128.storesequences.
adamperlin
approved these changes
Jul 1, 2026
Contributor
|
Tagging subscribers to 'arch-wasm': @lewing, @pavelsavara |
lewing
added a commit
that referenced
this pull request
Jul 9, 2026
Vector2 (`TYP_SIMD8`) and Vector3 (`TYP_SIMD12`) parameters are lowered to `i32` in the wasm signature, the same as Vector128 (`TYP_SIMD16`), but the argument-spill prolog in `genBeginFnProlog` only bailed R2R for `TYP_SIMD16`. As a result, a method with an 8-byte SIMD parameter — e.g. `System.Numerics.Matrix3x2.CreateRotation(float, Vector2)` — emitted an `f64.store` fed by the `i32` parameter local, producing an invalid module that fails wasm validation: ``` func 20691 failed to validate type mismatch: expected f64, found i32 ``` This currently prevents `System.Private.CoreLib` from producing a valid R2R image (both single-file and composite). ## Fix Broaden the parameter bail from `== TYP_SIMD16` to `varTypeIsSIMD(...)` so `SIMD8`/`SIMD12`/`SIMD16` parameters are all sent to the interpreter until SIMD parameters are supported in the wasm calling convention. This is a direct follow-up to the SIMD16 parameter bail added in #130101 ("Fix a few missing SIMD bail outs that prevent SPC from validating") — it was the same class of bug, just missed for the smaller SIMD sizes. ## Validation With this change, crossgen2 `--targetos wasi --targetarch wasm` on `System.Private.CoreLib` (and a composite including it) produces a module that passes `wasm-tools validate --features all`. Verified locally on macOS/arm64. > [!NOTE] > This change was authored with the assistance of GitHub Copilot. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a few missing SIMD bail outs that prevent SPC from validating.