Skip to content

Add public Property for VersionMadeBy flag in zipfiles#130109

Merged
alinpahontu2912 merged 4 commits into
dotnet:mainfrom
alinpahontu2912:public_versionmadeby
Jul 7, 2026
Merged

Add public Property for VersionMadeBy flag in zipfiles#130109
alinpahontu2912 merged 4 commits into
dotnet:mainfrom
alinpahontu2912:public_versionmadeby

Conversation

@alinpahontu2912

Copy link
Copy Markdown
Member

Fixes #124755

@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @karelz, @dotnet/area-system-io-compression
See info in area-owners.md if you want to be subscribed.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new public API on ZipArchiveEntry to expose the ZIP “version made by” field (two bytes: host platform + ZIP spec version) so callers can inspect the original metadata from the central directory.

Changes:

  • Add ZipArchiveEntry.VersionMadeBy (public ushort, [CLSCompliant(false)]) computed from the stored “made by” platform/spec fields.
  • Update the System.IO.Compression ref assembly to include the new public property.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
src/libraries/System.IO.Compression/src/System/IO/Compression/ZipArchiveEntry.cs Adds the new VersionMadeBy public property and its XML documentation.
src/libraries/System.IO.Compression/ref/System.IO.Compression.cs Exposes ZipArchiveEntry.VersionMadeBy in the reference assembly surface.

Copilot AI review requested due to automatic review settings July 7, 2026 09:13

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

@rzikm rzikm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alinpahontu2912 alinpahontu2912 merged commit f7ac8dc into dotnet:main Jul 7, 2026
85 of 88 checks passed
@dotnet-milestone-bot dotnet-milestone-bot Bot added this to the 11.0-preview7 milestone Jul 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[API Proposal]: Make ZipArchiveEntry ZipVersionMadeByPlatform byte public

4 participants